[PATCH] hw/nvme/ctrl: fix functions style

Gollu Appalanaidu posted 1 patch 2 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210521060842.25516-1-anaidu.gollu@samsung.com
Maintainers: Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>
hw/nvme/ctrl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] hw/nvme/ctrl: fix functions style
Posted by Gollu Appalanaidu 2 years, 11 months ago
Identify command related functions style fix.

Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
---
 hw/nvme/ctrl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 0bcaf7192f..40a7efcea9 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -4291,7 +4291,7 @@ static uint16_t nvme_identify_ns_attached_list(NvmeCtrl *n, NvmeRequest *req)
 }
 
 static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
-        bool active)
+                                     bool active)
 {
     NvmeNamespace *ns;
     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
@@ -4326,7 +4326,7 @@ static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
 }
 
 static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
-        bool active)
+                                     bool active)
 {
     NvmeNamespace *ns;
     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
@@ -4373,7 +4373,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
 }
 
 static uint16_t nvme_identify_nslist_csi(NvmeCtrl *n, NvmeRequest *req,
-        bool active)
+                                         bool active)
 {
     NvmeNamespace *ns;
     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
-- 
2.17.1


Re: [PATCH] hw/nvme/ctrl: fix functions style
Posted by Klaus Jensen 2 years, 11 months ago
On May 21 11:38, Gollu Appalanaidu wrote:
>Identify command related functions style fix.
>
>Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>---
> hw/nvme/ctrl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
>index 0bcaf7192f..40a7efcea9 100644
>--- a/hw/nvme/ctrl.c
>+++ b/hw/nvme/ctrl.c
>@@ -4291,7 +4291,7 @@ static uint16_t nvme_identify_ns_attached_list(NvmeCtrl *n, NvmeRequest *req)
> }
>
> static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                     bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>@@ -4326,7 +4326,7 @@ static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
> }
>
> static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                     bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>@@ -4373,7 +4373,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
> }
>
> static uint16_t nvme_identify_nslist_csi(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                         bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>-- 
>2.17.1
>
>

Thanks, applied to nvme-next.

Please just use 'hw/nvme:' in the commit title, we don't need to specify 
the sub-subsystem ;)
Re: [PATCH] hw/nvme/ctrl: fix functions style
Posted by Gollu Appalanaidu 2 years, 11 months ago
On Fri, May 21, 2021 at 09:13:51AM +0200, Klaus Jensen wrote:
>On May 21 11:38, Gollu Appalanaidu wrote:
>>Identify command related functions style fix.
>>
>>Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>>---
>>hw/nvme/ctrl.c | 6 +++---
>>1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
>>index 0bcaf7192f..40a7efcea9 100644
>>--- a/hw/nvme/ctrl.c
>>+++ b/hw/nvme/ctrl.c
>>@@ -4291,7 +4291,7 @@ static uint16_t nvme_identify_ns_attached_list(NvmeCtrl *n, NvmeRequest *req)
>>}
>>
>>static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
>>-        bool active)
>>+                                     bool active)
>>{
>>    NvmeNamespace *ns;
>>    NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>>@@ -4326,7 +4326,7 @@ static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
>>}
>>
>>static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
>>-        bool active)
>>+                                     bool active)
>>{
>>    NvmeNamespace *ns;
>>    NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>>@@ -4373,7 +4373,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
>>}
>>
>>static uint16_t nvme_identify_nslist_csi(NvmeCtrl *n, NvmeRequest *req,
>>-        bool active)
>>+                                         bool active)
>>{
>>    NvmeNamespace *ns;
>>    NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>>-- 
>>2.17.1
>>
>>
>
>Thanks, applied to nvme-next.
>
>Please just use 'hw/nvme:' in the commit title, we don't need to 
>specify the sub-subsystem ;)

Sure Klaus, Thanks :)