[RFC PATCH] meson.build: fix cosmetics of compiler display

Alex Bennée posted 1 patch 2 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210521134411.31658-1-alex.bennee@linaro.org
meson.build | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[RFC PATCH] meson.build: fix cosmetics of compiler display
Posted by Alex Bennée 2 years, 11 months ago
If you specify something like --cc="ccache gcc" on your configure line
the summary output misses the rest of the cmd_array. Do some string
joining to make it complete.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 meson.build | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meson.build b/meson.build
index 1559e8d873..ca65552f31 100644
--- a/meson.build
+++ b/meson.build
@@ -2510,15 +2510,15 @@ summary(summary_info, bool_yn: true, section: 'Configurable features')
 summary_info = {}
 summary_info += {'host CPU':          cpu}
 summary_info += {'host endianness':   build_machine.endian()}
-summary_info += {'C compiler':        meson.get_compiler('c').cmd_array()[0]}
-summary_info += {'Host C compiler':   meson.get_compiler('c', native: true).cmd_array()[0]}
+summary_info += {'C compiler':        ' '.join(meson.get_compiler('c').cmd_array())}
+summary_info += {'Host C compiler':   ' '.join(meson.get_compiler('c', native: true).cmd_array())}
 if link_language == 'cpp'
-  summary_info += {'C++ compiler':      meson.get_compiler('cpp').cmd_array()[0]}
+  summary_info += {'C++ compiler':    ' '.join(meson.get_compiler('cpp').cmd_array())}
 else
   summary_info += {'C++ compiler':      false}
 endif
 if targetos == 'darwin'
-  summary_info += {'Objective-C compiler': meson.get_compiler('objc').cmd_array()[0]}
+  summary_info += {'Objective-C compiler': ' '.join(meson.get_compiler('objc').cmd_array())}
 endif
 if targetos == 'windows'
   if 'WIN_SDK' in config_host
-- 
2.20.1


Re: [RFC PATCH] meson.build: fix cosmetics of compiler display
Posted by Thomas Huth 2 years, 11 months ago
On 21/05/2021 15.44, Alex Bennée wrote:
> If you specify something like --cc="ccache gcc" on your configure line
> the summary output misses the rest of the cmd_array. Do some string
> joining to make it complete.
> 
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   meson.build | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 1559e8d873..ca65552f31 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2510,15 +2510,15 @@ summary(summary_info, bool_yn: true, section: 'Configurable features')
>   summary_info = {}
>   summary_info += {'host CPU':          cpu}
>   summary_info += {'host endianness':   build_machine.endian()}
> -summary_info += {'C compiler':        meson.get_compiler('c').cmd_array()[0]}
> -summary_info += {'Host C compiler':   meson.get_compiler('c', native: true).cmd_array()[0]}
> +summary_info += {'C compiler':        ' '.join(meson.get_compiler('c').cmd_array())}
> +summary_info += {'Host C compiler':   ' '.join(meson.get_compiler('c', native: true).cmd_array())}
>   if link_language == 'cpp'
> -  summary_info += {'C++ compiler':      meson.get_compiler('cpp').cmd_array()[0]}
> +  summary_info += {'C++ compiler':    ' '.join(meson.get_compiler('cpp').cmd_array())}
>   else
>     summary_info += {'C++ compiler':      false}
>   endif
>   if targetos == 'darwin'
> -  summary_info += {'Objective-C compiler': meson.get_compiler('objc').cmd_array()[0]}
> +  summary_info += {'Objective-C compiler': ' '.join(meson.get_compiler('objc').cmd_array())}
>   endif
>   if targetos == 'windows'
>     if 'WIN_SDK' in config_host
> -- 2.20.1
> 

Tested-by: Thomas Huth <thuth@redhat.com>