From nobody Sun May 5 20:27:39 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1621824513; cv=none; d=zohomail.com; s=zohoarc; b=EHK+dxAwySHJoVlBNxYz736KfnHhLreKwAj/RZJaf0fAKZXZLg1Jc/D4bZ2wU9SPBP1Eotq/VlibF5LF3lZWkefCAF8YDY3DOpFPsNa95iRNlxXnJ0SDTwX9dgRKT80iZYVYRNbxtqA5n+YyIUOhYS5SfpwwvDL9Y8iJfjJyAw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621824513; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=owX1dSajuIIOVl4+GXzt2HodR9xCC+UKr/4IiMuHaA0=; b=CI5nIQi2r+EgawCCnfLwYuUszQpEdunpDch1Za+vidp08Dioaz0xjmRik6igP070Lu/KdRWWKD7iqZDe45NMHt4ggus1XV7qvnR6hTIrhWtlaXvoNnsgGnvlgdXT2n4F0lOgW3uahH0LyIbX+jgCJHO0o94B4foqLgGPqoBw8d0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621824513697517.046733087764; Sun, 23 May 2021 19:48:33 -0700 (PDT) Received: from localhost ([::1]:60918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ll0ds-0004ZC-P5 for importer2@patchew.org; Sun, 23 May 2021 22:48:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ll0d1-0003id-QL; Sun, 23 May 2021 22:47:39 -0400 Received: from mta-12-4.privateemail.com ([198.54.127.107]:17814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ll0d0-0007qw-49; Sun, 23 May 2021 22:47:39 -0400 Received: from mta-12.privateemail.com (localhost [127.0.0.1]) by mta-12.privateemail.com (Postfix) with ESMTP id 42ED580063; Sun, 23 May 2021 22:47:23 -0400 (EDT) Received: from hal-station.. (unknown [10.20.151.249]) by mta-12.privateemail.com (Postfix) with ESMTPA id AD4448005F; Sun, 23 May 2021 22:47:22 -0400 (EDT) From: Hamza Mahfooz To: Laurent Vivier Subject: [PATCH] linux-user: make process_pending_signals thread-safe Date: Sun, 23 May 2021 22:46:55 -0400 Message-Id: <20210524024655.11115-1-someguy@effective-light.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.54.127.107; envelope-from=someguy@effective-light.com; helo=MTA-12-4.privateemail.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Hamza Mahfooz Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Use pthread_sigmask instead of sigprocmask inside process_pending_signals to ensure that race conditions aren't possible. Signed-off-by: Hamza Mahfooz --- linux-user/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 7eecec46c4..81ff753c01 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -1005,9 +1005,8 @@ void process_pending_signals(CPUArchState *cpu_env) sigset_t *blocked_set; =20 while (qatomic_read(&ts->signal_pending)) { - /* FIXME: This is not threadsafe. */ sigfillset(&set); - sigprocmask(SIG_SETMASK, &set, 0); + pthread_sigmask(SIG_SETMASK, &set, 0); =20 restart_scan: sig =3D ts->sync_signal.pending; --=20 2.31.1