tests: Fix some minor Coverity issues

[PATCH 0/6] tests: Fix some minor Coverity issues

Peter Maydell posted 6 patches 2 years, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210525134458.6675-1-peter.maydell@linaro.org

Maintainers: Igor Mammedov <imammedo@redhat.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>

tests/qtest/bios-tables-test.c  |  8 ++++++--
tests/qtest/e1000e-test.c       |  3 ++-
tests/qtest/hd-geo-test.c       |  4 ++--
tests/qtest/pflash-cfi02-test.c |  2 +-
tests/qtest/tpm-tests.c         | 12 ++++--------
tests/unit/test-vmstate.c       |  2 ++
6 files changed, 17 insertions(+), 14 deletions(-)

Expand all Fold all

[PATCH 0/6] tests: Fix some minor Coverity issues

Posted by Peter Maydell 2 years, 11 months ago

We have a backlog of Coverity issues in tests (because we only
started running the scan on test code when we switched to meson
and started building the test code in "make" rather than only
in "make check"). This series fixes some of the easier ones.
There's nothing exciting here, it's all little nits.

thanks
-- PMM

Peter Maydell (6):
  tests/qtest/bios-tables-test: Check for dup2() failure
  tests/qtest/e1000e-test: Check qemu_recv() succeeded
  tests/qtest/hd-geo-test: Fix checks on mkstemp() return value
  tests/qtest/pflash-cfi02-test: Avoid potential integer overflow
  tests/qtest/tpm-tests: Remove unnecessary NULL checks
  tests/unit/test-vmstate: Assert that dup() and mkstemp() succeed

 tests/qtest/bios-tables-test.c  |  8 ++++++--
 tests/qtest/e1000e-test.c       |  3 ++-
 tests/qtest/hd-geo-test.c       |  4 ++--
 tests/qtest/pflash-cfi02-test.c |  2 +-
 tests/qtest/tpm-tests.c         | 12 ++++--------
 tests/unit/test-vmstate.c       |  2 ++
 6 files changed, 17 insertions(+), 14 deletions(-)

-- 
2.20.1