From nobody Wed May 1 18:32:59 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1622004131; cv=none; d=zohomail.com; s=zohoarc; b=Aoweo9Lk3ODyn6bX+oZ+7ZHPpjoWvkP7nUc1Km08WKlO6jS9KywM8+sIF3zXbA6kpOFYplmBL01wUTyc+L+EgYt0ZFmNEENYMDFujhNqqx7SXQBY+MgpSwBcJ/sk1YjpgpOA7nnJqzdIkz8HBxL/u6OBlW3EmNyiQlkLoe+u3p8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622004131; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=v+oYnD+OHTr3QhVvSiqrGNyfP0PjI1edshzvs+UeqHE=; b=lPGY7us1K3IMBCymVQTuHlGEK/TYZJtqIyBuvimA/HXmSm0ot9BCIVQHwznjukJvy4aSdoLME8Aqt82RJ/9R11z1GY51MjZ7ItXStkZgQp78eoFhe2TE2TZip0mvBoJfr0tNjYtyIB1bE75b+0J/D8Y+0R3P5RcOePIKBjbYmyw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622004131545836.2857722881269; Tue, 25 May 2021 21:42:11 -0700 (PDT) Received: from localhost ([::1]:59164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lllMw-0002s8-Gb for importer2@patchew.org; Wed, 26 May 2021 00:42:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lllKY-00022g-34 for qemu-devel@nongnu.org; Wed, 26 May 2021 00:39:42 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:45590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lllKV-0003rI-VN for qemu-devel@nongnu.org; Wed, 26 May 2021 00:39:41 -0400 Received: by mail-pj1-x1029.google.com with SMTP id ne24-20020a17090b3758b029015f2dafecb0so189607pjb.4 for ; Tue, 25 May 2021 21:39:36 -0700 (PDT) Received: from localhost ([2601:647:5180:4570:16dd:a9ff:fee7:6b79]) by smtp.gmail.com with ESMTPSA id w2sm14061461pjq.5.2021.05.25.21.39.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 May 2021 21:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mforney-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v+oYnD+OHTr3QhVvSiqrGNyfP0PjI1edshzvs+UeqHE=; b=tCb5Xtzgvgi5FbLfMSlhOLX153NX/gL8iINfGXyxAKiO6v4RZvzYqw1Fml5WwIwX6H cYITTKz1EkvmMYoWb5AeRjjHIFDsrJj4vet5RrA3N78zXIt7CbT83hckNi9YXDeKpjrl 3zOgryMj8ZOy4Ryzuax4jOqjtbTgxsw7yfqX5zXkzVvr5xMeymxjsilB0/XiKr3Tr45K 1CISkudsUdf256dKrMrzFAeO9RD+BFV+EJvWiIrhw1PUxkmck0tDTLEjLWrC7btReDnA dnRPBSQTcyKEPEBwGY+bHPmGdu/kU3LpD58B+JFq16jgfhOSIce8sQdPPNvBSYnb4Zj3 W6BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v+oYnD+OHTr3QhVvSiqrGNyfP0PjI1edshzvs+UeqHE=; b=m2Cjp4MFuUv2yGHea97nmOAsgTtjdBLoLu5RAVCh6syj+WOubmEP1ARO1pJBmpmKUD jO7BDlOxZOyKkEh7UVnOI6JR0DsTs8ewk6uKjWDApwXlBvrYK8cL2xFtKh04iKCp8+T+ dDuvGINkOP+zA9AUKl1eeQoDmyxP8IgoUQ97QJaN5aUBhnELFvzJnQPdLRS6u4SP+ldM +IWViBv4u7kvl0qM/MNG2vvSCSq7VlmvCzOc70ianMMT6KOFjUfIUHolYrV7ewHoxkkR Ewzoe0KAnitjMvNkfjav3TrW2uT9ODI3A66YAk1dkK8GbZCImZChF0a2jNCgZgWUDRlT trBQ== X-Gm-Message-State: AOAM532Vs//CgIy2fcmrpIXH9i0thAU+WUswPzYTaqBQml/JJ2RBhhZq YyxDJKA4eIzgncJ9tDYkNmslew== X-Google-Smtp-Source: ABdhPJw4mmu0RtmKqdmoPEa6FjT1KnGoYaps7aH5x4dTba6u8UbhIPYtQVQWvDnySweN20e255JG3Q== X-Received: by 2002:a17:902:76ca:b029:fd:9325:fd7d with SMTP id j10-20020a17090276cab02900fd9325fd7dmr815513plt.64.1622003975424; Tue, 25 May 2021 21:39:35 -0700 (PDT) From: Michael Forney To: Laurent Vivier Subject: [PATCH] linux-user: Remove unnecessary static assert involving __SIGRTMAX Date: Tue, 25 May 2021 21:39:28 -0700 Message-Id: <20210526043928.9586-1-mforney@mforney.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::1029; envelope-from=mforney@mforney.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @mforney-org.20150623.gappssmtp.com) Content-Type: text/plain; charset="utf-8" Since "linux-user: fix use of SIGRTMIN" (6bc024e7), qemu removed use of __SIGRTMAX except for in this QEMU_BUILD_BUG_ON assert. Presumably, this check is to ensure that the loop in signal_table_init from SIGRTMIN to SIGRTMAX falls within the bounds of host_to_target_signal_table (_NSIG). However, _NSIG is already defined to be the one larger than the largest signal supported by the system (as specified in the upcoming POSIX revision[0]), so the check is unnecessary. musl libc does not define __SIGRTMAX, so removing this check fixes one of the last remaining errors when building qemu. [0] https://www.austingroupbugs.net/view.php?id=3D741 Signed-off-by: Michael Forney --- If you prefer, I can send an alternate patch to leave the QEMU_BUILD_BUG_ON, but guard it by #ifdef __SIGRTMAX. linux-user/signal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 9016896dcd..6f62f2b528 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -38,7 +38,6 @@ static void host_signal_handler(int host_signum, siginfo_= t *info, * Signal number 0 is reserved for use as kill(pid, 0), to test whether * a process exists without sending it a signal. */ -QEMU_BUILD_BUG_ON(__SIGRTMAX + 1 !=3D _NSIG); static uint8_t host_to_target_signal_table[_NSIG] =3D { [SIGHUP] =3D TARGET_SIGHUP, [SIGINT] =3D TARGET_SIGINT, --=20 2.31.1