[v1] block: drop BlockDriverState::read_only

[PATCH 0/3] block: drop BlockDriverState::read_only

Vladimir Sementsov-Ogievskiy posted 3 patches 2 years, 11 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210526211534.524597-1-vsementsov@virtuozzo.com

Maintainers: Fam Zheng <fam@euphon.net>, Jeff Cody <codyprime@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>, Markus Armbruster <armbru@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

include/block/block_int.h        |  2 --
block.c                          | 16 +++++++---------
block/block-backend.c            | 10 ++--------
block/commit.c                   |  2 +-
block/io.c                       |  4 ++--
block/qapi.c                     |  2 +-
block/qcow2-snapshot.c           |  2 +-
block/qcow2.c                    |  4 ++--
block/snapshot.c                 |  2 +-
block/vhdx-log.c                 |  2 +-
blockdev.c                       |  4 +++-
tests/unit/test-block-iothread.c |  6 ------
12 files changed, 21 insertions(+), 35 deletions(-)

Expand all Fold all

[PATCH 0/3] block: drop BlockDriverState::read_only

Posted by Vladimir Sementsov-Ogievskiy 2 years, 11 months ago

Hi all!

The field duplicates information in .open_flags. We have to carefully
sync these two fields everywhere. It's simple to introduce a bug by
forgetting it.

Let's drop the field, and fix users to call bdrv_is_read_only() and
bdrv_is_writable() instead.

Vladimir Sementsov-Ogievskiy (3):
  block: consistently use bdrv_is_read_only()
  block: drop BlockDriverState::read_only
  block: drop BlockBackendRootState::read_only

 include/block/block_int.h        |  2 --
 block.c                          | 16 +++++++---------
 block/block-backend.c            | 10 ++--------
 block/commit.c                   |  2 +-
 block/io.c                       |  4 ++--
 block/qapi.c                     |  2 +-
 block/qcow2-snapshot.c           |  2 +-
 block/qcow2.c                    |  4 ++--
 block/snapshot.c                 |  2 +-
 block/vhdx-log.c                 |  2 +-
 blockdev.c                       |  4 +++-
 tests/unit/test-block-iothread.c |  6 ------
 12 files changed, 21 insertions(+), 35 deletions(-)

-- 
2.29.2