[PATCH] HMP: added cpustats to removed_features.rst

Bruno Larsen (billionai) posted 1 patch 2 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210527165034.23562-1-bruno.larsen@eldorado.org.br
docs/system/removed-features.rst | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] HMP: added cpustats to removed_features.rst
Posted by Bruno Larsen (billionai) 2 years, 10 months ago
Documented the removal of the HMP command cpustats

Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
---
 docs/system/removed-features.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst
index 5a462ac568..a88ff7aff4 100644
--- a/docs/system/removed-features.rst
+++ b/docs/system/removed-features.rst
@@ -249,6 +249,12 @@ Use ``migrate-set-parameters`` and ``info migrate-parameters`` instead.
 
 Use ``migrate-set-parameters`` instead.
 
+``cpustats`` (removed in 6.1)
+'''''''''''''''''''''''''''''
+
+This command didn't produce any output already. Removed to avoid expectations
+of maintaining/fixing it.
+
 Guest Emulator ISAs
 -------------------
 
-- 
2.17.1


Re: [PATCH] HMP: added cpustats to removed_features.rst
Posted by Greg Kurz 2 years, 10 months ago
On Thu, 27 May 2021 13:50:34 -0300
"Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote:

> Documented the removal of the HMP command cpustats
> 

It is the 'info cpustats' command.

> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> ---
>  docs/system/removed-features.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst
> index 5a462ac568..a88ff7aff4 100644
> --- a/docs/system/removed-features.rst
> +++ b/docs/system/removed-features.rst
> @@ -249,6 +249,12 @@ Use ``migrate-set-parameters`` and ``info migrate-parameters`` instead.
>  
>  Use ``migrate-set-parameters`` instead.
>  
> +``cpustats`` (removed in 6.1)
> +'''''''''''''''''''''''''''''

ditto

> +
> +This command didn't produce any output already. Removed to avoid expectations
> +of maintaining/fixing it.
> +

s/to avoid... it/with no replacement/ because that's what users
are interested in.

>  Guest Emulator ISAs
>  -------------------
>  


Re: [PATCH] HMP: added cpustats to removed_features.rst
Posted by Alex Bennée 2 years, 10 months ago
Greg Kurz <groug@kaod.org> writes:

> On Thu, 27 May 2021 13:50:34 -0300
> "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote:
>
>> Documented the removal of the HMP command cpustats
>> 
>
> It is the 'info cpustats' command.
>
>> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
>> ---
>>  docs/system/removed-features.rst | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst
>> index 5a462ac568..a88ff7aff4 100644
>> --- a/docs/system/removed-features.rst
>> +++ b/docs/system/removed-features.rst
>> @@ -249,6 +249,12 @@ Use ``migrate-set-parameters`` and ``info migrate-parameters`` instead.
>>  
>>  Use ``migrate-set-parameters`` instead.
>>  
>> +``cpustats`` (removed in 6.1)
>> +'''''''''''''''''''''''''''''
>
> ditto
>
>> +
>> +This command didn't produce any output already. Removed to avoid expectations
>> +of maintaining/fixing it.
>> +
>
> s/to avoid... it/with no replacement/ because that's what users
> are interested in.

We could point to alternatives:

  This command hasn't produced any output for some time and the build
  was broken anyway. If users are interested in gathering similar
  information in the future they should investigate collecting it with
  TCG plugins.

?

>
>>  Guest Emulator ISAs
>>  -------------------
>>  


-- 
Alex Bennée