[v1] STM32VLDISCOVERY Machine Model

[PATCH 0/2] STM32VLDISCOVERY Machine Model

Alexandre Iooss posted 2 patches 2 years, 10 months ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210608161028.4159582-1-erdnaxe@crans.org

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Alistair Francis <alistair@alistair23.me>

There is a newer version of this series

MAINTAINERS                             |  12 ++
default-configs/devices/arm-softmmu.mak |   1 +
hw/arm/Kconfig                          |  10 ++
hw/arm/meson.build                      |   2 +
hw/arm/stm32f100_soc.c                  | 182 ++++++++++++++++++++++++
hw/arm/stm32vldiscovery.c               |  66 +++++++++
include/hw/arm/stm32f100_soc.h          |  58 ++++++++
7 files changed, 331 insertions(+)
create mode 100644 hw/arm/stm32f100_soc.c
create mode 100644 hw/arm/stm32vldiscovery.c
create mode 100644 include/hw/arm/stm32f100_soc.h

Expand all Fold all

[PATCH 0/2] STM32VLDISCOVERY Machine Model

Posted by Alexandre Iooss 2 years, 10 months ago

This patch series adds the STM32VLDISCOVERY Machine to QEMU

Information on the board is available at:
https://www.st.com/en/evaluation-tools/stm32vldiscovery.html

Alexandre Iooss (2):
  stm32f100: Add the stm32f100 SoC
  stm32vldiscovery: Add the STM32VLDISCOVERY Machine

 MAINTAINERS                             |  12 ++
 default-configs/devices/arm-softmmu.mak |   1 +
 hw/arm/Kconfig                          |  10 ++
 hw/arm/meson.build                      |   2 +
 hw/arm/stm32f100_soc.c                  | 182 ++++++++++++++++++++++++
 hw/arm/stm32vldiscovery.c               |  66 +++++++++
 include/hw/arm/stm32f100_soc.h          |  58 ++++++++
 7 files changed, 331 insertions(+)
 create mode 100644 hw/arm/stm32f100_soc.c
 create mode 100644 hw/arm/stm32vldiscovery.c
 create mode 100644 include/hw/arm/stm32f100_soc.h

-- 
2.25.1

Re: [PATCH 0/2] STM32VLDISCOVERY Machine Model

Posted by Peter Maydell 2 years, 10 months ago

On Tue, 8 Jun 2021 at 17:10, Alexandre Iooss <erdnaxe@crans.org> wrote:
>
> This patch series adds the STM32VLDISCOVERY Machine to QEMU
>
> Information on the board is available at:
> https://www.st.com/en/evaluation-tools/stm32vldiscovery.html
>
> Alexandre Iooss (2):
>   stm32f100: Add the stm32f100 SoC
>   stm32vldiscovery: Add the STM32VLDISCOVERY Machine
>
>  MAINTAINERS                             |  12 ++
>  default-configs/devices/arm-softmmu.mak |   1 +
>  hw/arm/Kconfig                          |  10 ++
>  hw/arm/meson.build                      |   2 +
>  hw/arm/stm32f100_soc.c                  | 182 ++++++++++++++++++++++++
>  hw/arm/stm32vldiscovery.c               |  66 +++++++++
>  include/hw/arm/stm32f100_soc.h          |  58 ++++++++
>  7 files changed, 331 insertions(+)
>  create mode 100644 hw/arm/stm32f100_soc.c
>  create mode 100644 hw/arm/stm32vldiscovery.c
>  create mode 100644 include/hw/arm/stm32f100_soc.h

Looks generally OK to me, but cc'ing Alistair who wrote the
STM32F405 model in case he wants to have a look at it.

thanks
-- PMM

Re: [PATCH 0/2] STM32VLDISCOVERY Machine Model

Posted by Philippe Mathieu-Daudé 2 years, 10 months ago

On 6/14/21 6:05 PM, Peter Maydell wrote:
> On Tue, 8 Jun 2021 at 17:10, Alexandre Iooss <erdnaxe@crans.org> wrote:
>>
>> This patch series adds the STM32VLDISCOVERY Machine to QEMU
>>
>> Information on the board is available at:
>> https://www.st.com/en/evaluation-tools/stm32vldiscovery.html
>>
>> Alexandre Iooss (2):
>>   stm32f100: Add the stm32f100 SoC
>>   stm32vldiscovery: Add the STM32VLDISCOVERY Machine
>>
>>  MAINTAINERS                             |  12 ++
>>  default-configs/devices/arm-softmmu.mak |   1 +
>>  hw/arm/Kconfig                          |  10 ++
>>  hw/arm/meson.build                      |   2 +
>>  hw/arm/stm32f100_soc.c                  | 182 ++++++++++++++++++++++++
>>  hw/arm/stm32vldiscovery.c               |  66 +++++++++
>>  include/hw/arm/stm32f100_soc.h          |  58 ++++++++
>>  7 files changed, 331 insertions(+)
>>  create mode 100644 hw/arm/stm32f100_soc.c
>>  create mode 100644 hw/arm/stm32vldiscovery.c
>>  create mode 100644 include/hw/arm/stm32f100_soc.h
> 
> Looks generally OK to me, but cc'ing Alistair who wrote the
> STM32F405 model in case he wants to have a look at it.

The SoC in the STM32Fxxx family seems very similar.

Maybe OK for this one but next machines should consider reuse
components. Alexandre, if you plan to add more SoC, you might
want to look at how the abstract TYPE_ATMEGA_MCU handles multiples
MCU of the same family.

Regards,

Phil.