vhost-user-blk: Implement reconnection during realize

[PATCH 0/7] vhost-user-blk: Implement reconnection during realize

Kevin Wolf posted 7 patches 2 years, 10 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210609154658.350308-1-kwolf@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Jason Wang <jasowang@redhat.com>, Raphael Norwitz <raphael.norwitz@nutanix.com>, Stefan Hajnoczi <stefanha@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Gerd Hoffmann <kraxel@redhat.com>, Max Reitz <mreitz@redhat.com>, Fam Zheng <fam@euphon.net>

include/hw/virtio/vhost-backend.h |   5 +-
include/hw/virtio/vhost.h         |   6 +-
backends/cryptodev-vhost.c        |   5 +-
backends/vhost-user.c             |   4 +-
hw/block/vhost-user-blk.c         | 100 +++++++++++++++++++-----------
hw/display/vhost-user-gpu.c       |   6 +-
hw/input/vhost-user-input.c       |   6 +-
hw/net/vhost_net.c                |   8 ++-
hw/scsi/vhost-scsi.c              |   4 +-
hw/scsi/vhost-user-scsi.c         |   4 +-
hw/virtio/vhost-backend.c         |   6 +-
hw/virtio/vhost-user-fs.c         |   3 +-
hw/virtio/vhost-user-vsock.c      |  12 ++--
hw/virtio/vhost-user.c            |  71 +++++++++++----------
hw/virtio/vhost-vdpa.c            |   8 ++-
hw/virtio/vhost-vsock.c           |   3 +-
hw/virtio/vhost.c                 |  41 +++++++-----
17 files changed, 174 insertions(+), 118 deletions(-)

Expand all Fold all

[PATCH 0/7] vhost-user-blk: Implement reconnection during realize

Posted by Kevin Wolf 2 years, 10 months ago

My previous series removed the broken implementation of automatic
reconnection during .realize(). This series adds some error reporting
improvements that allow distinguishing cases where reconnecting could
help from permanent errors, and then uses it to re-implement the
automatic reconnection during .realize(), as was requested during review
of the previous series.

Kevin Wolf (7):
  vhost: Add Error parameter to vhost_dev_init()
  vhost: Distinguish errors in vhost_backend_init()
  vhost: Return 0/-errno in vhost_dev_init()
  vhost-user-blk: Add Error parameter to vhost_user_blk_start()
  vhost: Distinguish errors in vhost_dev_get_config()
  vhost-user-blk: Factor out vhost_user_blk_realize_connect()
  vhost-user-blk: Implement reconnection during realize

 include/hw/virtio/vhost-backend.h |   5 +-
 include/hw/virtio/vhost.h         |   6 +-
 backends/cryptodev-vhost.c        |   5 +-
 backends/vhost-user.c             |   4 +-
 hw/block/vhost-user-blk.c         | 100 +++++++++++++++++++-----------
 hw/display/vhost-user-gpu.c       |   6 +-
 hw/input/vhost-user-input.c       |   6 +-
 hw/net/vhost_net.c                |   8 ++-
 hw/scsi/vhost-scsi.c              |   4 +-
 hw/scsi/vhost-user-scsi.c         |   4 +-
 hw/virtio/vhost-backend.c         |   6 +-
 hw/virtio/vhost-user-fs.c         |   3 +-
 hw/virtio/vhost-user-vsock.c      |  12 ++--
 hw/virtio/vhost-user.c            |  71 +++++++++++----------
 hw/virtio/vhost-vdpa.c            |   8 ++-
 hw/virtio/vhost-vsock.c           |   3 +-
 hw/virtio/vhost.c                 |  41 +++++++-----
 17 files changed, 174 insertions(+), 118 deletions(-)

-- 
2.30.2

Re: [PATCH 0/7] vhost-user-blk: Implement reconnection during realize

Posted by Kevin Wolf 2 years, 10 months ago

Am 09.06.2021 um 17:46 hat Kevin Wolf geschrieben:
> My previous series removed the broken implementation of automatic
> reconnection during .realize(). This series adds some error reporting
> improvements that allow distinguishing cases where reconnecting could
> help from permanent errors, and then uses it to re-implement the
> automatic reconnection during .realize(), as was requested during review
> of the previous series.
> 
> Kevin Wolf (7):
>   vhost: Add Error parameter to vhost_dev_init()
>   vhost: Distinguish errors in vhost_backend_init()
>   vhost: Return 0/-errno in vhost_dev_init()
>   vhost-user-blk: Add Error parameter to vhost_user_blk_start()
>   vhost: Distinguish errors in vhost_dev_get_config()
>   vhost-user-blk: Factor out vhost_user_blk_realize_connect()
>   vhost-user-blk: Implement reconnection during realize

Thanks for the review, fixed up the series according to the minor
comments you had and applied it to my block branch.

Kevin