From nobody Sat Jul 12 04:29:31 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623304962; cv=none; d=zohomail.com; s=zohoarc; b=F3Kc5NjppHB/9Zpncna1urQbrz/zudjeHkugQ/RBt1hpf2sR7xeX3B9vhkiZBWR/s7rGUnPY0vVV/7SKRqg5IW/Oo2YMwe1iP3ghh8/zKUZIPTYF5CBSXvZ2bKqEa5o1S1mkZl+vY7aF/bjvPGW3hOoYDw5vH0pYUeMcoAHqo2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623304962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZZBIBypDtxJSJiM+f/nEPl3cXV/9a6YLFrIp/UYBmrw=; b=IIp/+pQVRAm7HEhfHgJGZLfDHHOUtscvm5R8vmtMsrNmi6sS+L5T2yZZCq5ShVsQi8xFCtJR9+ZneDEJaZxxLtAQ0Iesouf/GTJqpj5OFEG1So5RzToKygStkWku7I5RfJ2dViaz/+Pz2a/BTZeC2rhOC1iBkuusQI6kcBPfmaY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1623304962527180.23964294805728; Wed, 9 Jun 2021 23:02:42 -0700 (PDT) Received: from localhost ([::1]:55128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrDm5-0000Ys-C3 for importer2@patchew.org; Thu, 10 Jun 2021 02:02:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrDhy-0001Zi-9B for qemu-devel@nongnu.org; Thu, 10 Jun 2021 01:58:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrDhu-0001Ae-34 for qemu-devel@nongnu.org; Thu, 10 Jun 2021 01:58:26 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-543-PspOm8XYM_GUUVFfVYXaQA-1; Thu, 10 Jun 2021 01:58:16 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93007801B16; Thu, 10 Jun 2021 05:58:14 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-69.ams2.redhat.com [10.36.113.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9476E60853; Thu, 10 Jun 2021 05:57:56 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4711E18007A3; Thu, 10 Jun 2021 07:57:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623304700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZZBIBypDtxJSJiM+f/nEPl3cXV/9a6YLFrIp/UYBmrw=; b=Z25SnAUQtGRlBJKDYkwjKH+taplgDtWa6nUBOv6LYl5JmiESUkeTXku6EI5R0vkULQflY/ gUVWIf3hdqAE5HOB0UWgcNbWxi6LaAEF4g/LbeYAvVnH8hhTkSSar5aXCYrHxgE1lFoWw5 r/lGo0VtjSu2QLVzVcdy5wCP1bADSRw= X-MC-Unique: PspOm8XYM_GUUVFfVYXaQA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v2 01/18] modules: add metadata macros, add qxl module annotations Date: Thu, 10 Jun 2021 07:57:38 +0200 Message-Id: <20210610055755.538119-2-kraxel@redhat.com> In-Reply-To: <20210610055755.538119-1-kraxel@redhat.com> References: <20210610055755.538119-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , berrange@redhat.com, qemu-block@nongnu.org, "Michael S. Tsirkin" , Michael Roth , Cornelia Huck , Peter Lieven , Markus Armbruster , Max Reitz , Halil Pasic , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-s390x@nongnu.org, Gerd Hoffmann , Ronnie Sahlberg , Samuel Thibault , Paolo Bonzini , David Hildenbrand , Richard Henderson , Eric Blake , Christian Borntraeger Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Stealing an idea from the linux kernel: Place module metadata in an .modinfo elf section. This patch adds macros and qxl module annotations as example. Signed-off-by: Gerd Hoffmann --- include/qemu/module.h | 22 ++++++++++++++++++++++ hw/display/qxl.c | 4 ++++ 2 files changed, 26 insertions(+) diff --git a/include/qemu/module.h b/include/qemu/module.h index 944d403cbd15..d3cab3c25a2f 100644 --- a/include/qemu/module.h +++ b/include/qemu/module.h @@ -73,4 +73,26 @@ bool module_load_one(const char *prefix, const char *lib= _name, bool mayfail); void module_load_qom_one(const char *type); void module_load_qom_all(void); =20 +/* + * macros to store module metadata in a .modinfo section. + * qemu-modinfo utility will collect the metadata. + * + * Use "objdump -t -s -j .modinfo ${module}.so" to inspect. + */ + +#define ___PASTE(a, b) a##b +#define __PASTE(a, b) ___PASTE(a, b) + +#define modinfo(kind, value) \ + static const char __PASTE(kind, __LINE__)[] \ + __attribute__((__used__)) \ + __attribute__((section(".modinfo"))) \ + __attribute__((aligned(1))) \ + =3D stringify(kind) "=3D" value + +#define module_obj(name) modinfo(obj, name) +#define module_dep(name) modinfo(dep, name) +#define module_arch(name) modinfo(arch, name) +#define module_opts(name) modinfo(opts, name) + #endif diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 6e1f8ff1b2a7..84f99088e0a0 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -2522,6 +2522,7 @@ static const TypeInfo qxl_primary_info =3D { .parent =3D TYPE_PCI_QXL, .class_init =3D qxl_primary_class_init, }; +module_obj("qxl-vga"); =20 static void qxl_secondary_class_init(ObjectClass *klass, void *data) { @@ -2538,6 +2539,7 @@ static const TypeInfo qxl_secondary_info =3D { .parent =3D TYPE_PCI_QXL, .class_init =3D qxl_secondary_class_init, }; +module_obj("qxl"); =20 static void qxl_register_types(void) { @@ -2547,3 +2549,5 @@ static void qxl_register_types(void) } =20 type_init(qxl_register_types) + +module_dep("ui-spice-core"); --=20 2.31.1