[PATCH] accel/tcg: Use MiB in tcg_init_machine

Richard Henderson posted 1 patch 2 days, 6 hours ago
Failed in applying to current master (apply log)
accel/tcg/tcg-all.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] accel/tcg: Use MiB in tcg_init_machine

Posted by Richard Henderson 2 days, 6 hours ago
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

This sits in the middle of my "Clean up code_gen_buffer allocation"
patch set.  Alex mentioned it during review, and I had already made
the change.

This is the only patch in the set that has not been posted and
reviewed.  Rather than re-posting the entire set, I'm just
sending this one and will queue the whole thing to tcg-next.


r~

---
 accel/tcg/tcg-all.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c
index e990180c4b..1ee89902c3 100644
--- a/accel/tcg/tcg-all.c
+++ b/accel/tcg/tcg-all.c
@@ -32,6 +32,7 @@
 #include "qemu/error-report.h"
 #include "qemu/accel.h"
 #include "qapi/qapi-builtin-visit.h"
+#include "qemu/units.h"
 #include "internal.h"
 
 struct TCGState {
@@ -115,7 +116,7 @@ static int tcg_init_machine(MachineState *ms)
 
     page_init();
     tb_htable_init();
-    tcg_init(s->tb_size * 1024 * 1024, s->splitwx_enabled);
+    tcg_init(s->tb_size * MiB, s->splitwx_enabled);
 
 #if defined(CONFIG_SOFTMMU)
     /*
-- 
2.25.1


Re: [PATCH] accel/tcg: Use MiB in tcg_init_machine

Posted by Alex Bennée 1 day, 12 hours ago
Richard Henderson <richard.henderson@linaro.org> writes:

> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> This sits in the middle of my "Clean up code_gen_buffer allocation"
> patch set.  Alex mentioned it during review, and I had already made
> the change.
>
> This is the only patch in the set that has not been posted and
> reviewed.  Rather than re-posting the entire set, I'm just
> sending this one and will queue the whole thing to tcg-next.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée

RE: [PATCH] accel/tcg: Use MiB in tcg_init_machine

Posted by Luis Fernando Fujita Pires 2 days, 6 hours ago
From: Richard Henderson <richard.henderson@linaro.org>
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> 
> This sits in the middle of my "Clean up code_gen_buffer allocation"
> patch set.  Alex mentioned it during review, and I had already made the change.
> 
> This is the only patch in the set that has not been posted and reviewed.  Rather
> than re-posting the entire set, I'm just sending this one and will queue the whole
> thing to tcg-next.
> 
> 
> r~
> 
> ---
>  accel/tcg/tcg-all.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>

--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>

Re: [PATCH] accel/tcg: Use MiB in tcg_init_machine

Posted by Philippe Mathieu-Daudé 2 days, 5 hours ago
On 6/10/21 6:40 PM, Richard Henderson wrote:
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> 
> This sits in the middle of my "Clean up code_gen_buffer allocation"
> patch set.  Alex mentioned it during review, and I had already made
> the change.
> 
> This is the only patch in the set that has not been posted and
> reviewed.  Rather than re-posting the entire set, I'm just
> sending this one and will queue the whole thing to tcg-next.
> 
> 
> r~
> 
> ---
>  accel/tcg/tcg-all.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>