[RFC PATCH v2 0/7] pSeries base FORM2 NUMA affinity support

Daniel Henrique Barboza posted 7 patches 2 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/next-importer-push tags/patchew/20210616011944.2996399-1-danielhb413@gmail.com
Maintainers: Greg Kurz <groug@kaod.org>, "Michael S. Tsirkin" <mst@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Igor Mammedov <imammedo@redhat.com>
hw/mem/nvdimm.c             |  31 +++++
hw/ppc/spapr.c              |  60 ++++-----
hw/ppc/spapr_hcall.c        |   4 +
hw/ppc/spapr_numa.c         | 257 +++++++++++++++++++++++++++++++++---
hw/ppc/spapr_nvdimm.c       |   5 +-
include/hw/mem/nvdimm.h     |  12 ++
include/hw/ppc/spapr.h      |   1 +
include/hw/ppc/spapr_numa.h |   6 +-
include/hw/ppc/spapr_ovec.h |   1 +
9 files changed, 318 insertions(+), 59 deletions(-)
[RFC PATCH v2 0/7] pSeries base FORM2 NUMA affinity support
Posted by Daniel Henrique Barboza 2 years, 10 months ago
Hi,

This new version contains changes made after reviews from Aneesh
and David in v1.

changes from v1:
- patches 1 and 2: switched places
- patch 3: folded into patch 2
- patch 2:
    * only make CAS related changes when using the newest
    machine version
- patch 3 (former 4):
    * only advertise FORM2 support for the newest machine version
- patches 5 and 6 (former 6 and 7):
    * detect if 'device-node' was set in the command line, and if not,
    use the 'node' value when writing in the device tree

v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg03617.html



Daniel Henrique Barboza (7):
  spapr_numa.c: split FORM1 code into helpers
  spapr: move NUMA data init to post-CAS
  spapr_numa.c: base FORM2 NUMA affinity support
  spapr: simplify spapr_numa_associativity_init params
  nvdimm: add PPC64 'device-node' property
  spapr_numa, spapr_nvdimm: write secondary NUMA domain for nvdimms
  spapr: move memory/cpu less check to spapr_numa_FORM1_affinity_init()

 hw/mem/nvdimm.c             |  31 +++++
 hw/ppc/spapr.c              |  60 ++++-----
 hw/ppc/spapr_hcall.c        |   4 +
 hw/ppc/spapr_numa.c         | 257 +++++++++++++++++++++++++++++++++---
 hw/ppc/spapr_nvdimm.c       |   5 +-
 include/hw/mem/nvdimm.h     |  12 ++
 include/hw/ppc/spapr.h      |   1 +
 include/hw/ppc/spapr_numa.h |   6 +-
 include/hw/ppc/spapr_ovec.h |   1 +
 9 files changed, 318 insertions(+), 59 deletions(-)

-- 
2.31.1


Re: [RFC PATCH v2 0/7] pSeries base FORM2 NUMA affinity support
Posted by David Gibson 2 years, 10 months ago
On Tue, Jun 15, 2021 at 10:19:37PM -0300, Daniel Henrique Barboza wrote:
> Hi,
> 
> This new version contains changes made after reviews from Aneesh
> and David in v1.

I might hold off on reviewing the qemu patches until the kernel
patches (and the exact design of the dt stuff) are more settled.

> 
> changes from v1:
> - patches 1 and 2: switched places
> - patch 3: folded into patch 2
> - patch 2:
>     * only make CAS related changes when using the newest
>     machine version
> - patch 3 (former 4):
>     * only advertise FORM2 support for the newest machine version
> - patches 5 and 6 (former 6 and 7):
>     * detect if 'device-node' was set in the command line, and if not,
>     use the 'node' value when writing in the device tree
> 
> v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg03617.html
> 
> 
> 
> Daniel Henrique Barboza (7):
>   spapr_numa.c: split FORM1 code into helpers
>   spapr: move NUMA data init to post-CAS
>   spapr_numa.c: base FORM2 NUMA affinity support
>   spapr: simplify spapr_numa_associativity_init params
>   nvdimm: add PPC64 'device-node' property
>   spapr_numa, spapr_nvdimm: write secondary NUMA domain for nvdimms
>   spapr: move memory/cpu less check to spapr_numa_FORM1_affinity_init()
> 
>  hw/mem/nvdimm.c             |  31 +++++
>  hw/ppc/spapr.c              |  60 ++++-----
>  hw/ppc/spapr_hcall.c        |   4 +
>  hw/ppc/spapr_numa.c         | 257 +++++++++++++++++++++++++++++++++---
>  hw/ppc/spapr_nvdimm.c       |   5 +-
>  include/hw/mem/nvdimm.h     |  12 ++
>  include/hw/ppc/spapr.h      |   1 +
>  include/hw/ppc/spapr_numa.h |   6 +-
>  include/hw/ppc/spapr_ovec.h |   1 +
>  9 files changed, 318 insertions(+), 59 deletions(-)
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson