On Wed, Jun 16, 2021 at 06:14:05PM +0200, Philippe Mathieu-Daudé wrote:
> This is a respin of Zoltan's patch:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg714711.html
>
> Since v2, tried to address Corey's review comments resulting
> in a i2c_send_recv() removal and code easier to review (to my
> taste at least).
Yes, this is much better. I had a few minor comments, and Richard did,
too, but with those fixed this is a big improvement over the existing
code.
I can give you an:
Acked-by: Corey Minyard <cminyard@mvista.com>
for all of these, or I can take them into my tree. I'm fine either way.
-corey
>
> Supersedes: <20200623063123.20776-1-f4bug@amsat.org>
>
> BALATON Zoltan (1):
> hw/i2c: Make i2c_start_transfer() direction argument a boolean
>
> Philippe Mathieu-Daudé (12):
> hw/input/lm832x: Move lm832x_key_event() declaration to "lm832x.h"
> hw/input/lm832x: Define TYPE_LM8323 in public header
> hw/display/sm501: Simplify sm501_i2c_write() logic
> hw/display/sm501: Replace i2c_send_recv() by i2c_recv() & i2c_send()
> hw/i2c/ppc4xx_i2c: Add reference to datasheet
> hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()
> hw/misc/auxbus: Fix MOT/classic I2C mode
> hw/misc/auxbus: Explode READ_I2C / WRITE_I2C_MOT cases
> hw/misc/auxbus: Replace 'is_write' boolean by its value
> hw/misc/auxbus: Replace i2c_send_recv() by i2c_recv() & i2c_send()
> hw/i2c: Remove confusing i2c_send_recv()
> hw/i2c: Rename i2c_set_slave_address() -> i2c_slave_set_address()
>
> include/hw/i2c/i2c.h | 21 +++++++++---
> include/hw/input/lm832x.h | 28 ++++++++++++++++
> hw/arm/nseries.c | 3 +-
> hw/arm/pxa2xx.c | 2 +-
> hw/arm/spitz.c | 4 +--
> hw/display/ati.c | 2 +-
> hw/display/sm501.c | 16 +++++----
> hw/display/xlnx_dp.c | 2 +-
> hw/i2c/core.c | 56 ++++++++++++++-----------------
> hw/i2c/imx_i2c.c | 2 +-
> hw/i2c/ppc4xx_i2c.c | 15 ++++++---
> hw/input/lm832x.c | 2 +-
> hw/misc/auxbus.c | 69 +++++++++++++++++++++++++++++----------
> MAINTAINERS | 1 +
> 14 files changed, 149 insertions(+), 74 deletions(-)
> create mode 100644 include/hw/input/lm832x.h
>
> --
> 2.31.1
>