[PATCH v17 0/6] MTE support for KVM guest

Steven Price posted 6 patches 2 years, 10 months ago
Failed in applying to current master (apply log)
Documentation/virt/kvm/api.rst             | 61 ++++++++++++++++
arch/arm64/include/asm/kvm_arm.h           |  3 +-
arch/arm64/include/asm/kvm_emulate.h       |  3 +
arch/arm64/include/asm/kvm_host.h          | 12 ++++
arch/arm64/include/asm/kvm_mte.h           | 66 +++++++++++++++++
arch/arm64/include/asm/mte-def.h           |  1 +
arch/arm64/include/asm/mte.h               |  4 +-
arch/arm64/include/asm/pgtable.h           | 22 +++++-
arch/arm64/include/asm/sysreg.h            |  3 +-
arch/arm64/include/uapi/asm/kvm.h          | 11 +++
arch/arm64/kernel/asm-offsets.c            |  2 +
arch/arm64/kernel/mte.c                    | 18 +++--
arch/arm64/kvm/arm.c                       | 16 +++++
arch/arm64/kvm/guest.c                     | 82 ++++++++++++++++++++++
arch/arm64/kvm/hyp/entry.S                 |  7 ++
arch/arm64/kvm/hyp/exception.c             |  3 +-
arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 21 ++++++
arch/arm64/kvm/mmu.c                       | 64 ++++++++++++++++-
arch/arm64/kvm/reset.c                     |  4 ++
arch/arm64/kvm/sys_regs.c                  | 32 +++++++--
include/uapi/linux/kvm.h                   |  2 +
21 files changed, 419 insertions(+), 18 deletions(-)
create mode 100644 arch/arm64/include/asm/kvm_mte.h
[PATCH v17 0/6] MTE support for KVM guest
Posted by Steven Price 2 years, 10 months ago
This series adds support for using the Arm Memory Tagging Extensions
(MTE) in a KVM guest.

Changes since v16[1]:

 - Dropped the first patch ("Handle race when synchronising tags") as
   it's not KVM specific and by restricting MAP_SHARED in KVM there is
   no longer a dependency.

 - Change return code when creating a memslot with VM_SHARED regions to
   -EFAULT (and correctly jump to out_unlock on this error case).

 - Clarify documentation thanks to Catalin.

 - Rebase onto v5.13-rc4.

 - Add Reviewed-by tags from Catalin - thanks!

[1] https://lore.kernel.org/r/20210618132826.54670-1-steven.price%40arm.com

Steven Price (6):
  arm64: mte: Sync tags for pages where PTE is untagged
  KVM: arm64: Introduce MTE VM feature
  KVM: arm64: Save/restore MTE registers
  KVM: arm64: Expose KVM_ARM_CAP_MTE
  KVM: arm64: ioctl to fetch/store tags in a guest
  KVM: arm64: Document MTE capability and ioctl

 Documentation/virt/kvm/api.rst             | 61 ++++++++++++++++
 arch/arm64/include/asm/kvm_arm.h           |  3 +-
 arch/arm64/include/asm/kvm_emulate.h       |  3 +
 arch/arm64/include/asm/kvm_host.h          | 12 ++++
 arch/arm64/include/asm/kvm_mte.h           | 66 +++++++++++++++++
 arch/arm64/include/asm/mte-def.h           |  1 +
 arch/arm64/include/asm/mte.h               |  4 +-
 arch/arm64/include/asm/pgtable.h           | 22 +++++-
 arch/arm64/include/asm/sysreg.h            |  3 +-
 arch/arm64/include/uapi/asm/kvm.h          | 11 +++
 arch/arm64/kernel/asm-offsets.c            |  2 +
 arch/arm64/kernel/mte.c                    | 18 +++--
 arch/arm64/kvm/arm.c                       | 16 +++++
 arch/arm64/kvm/guest.c                     | 82 ++++++++++++++++++++++
 arch/arm64/kvm/hyp/entry.S                 |  7 ++
 arch/arm64/kvm/hyp/exception.c             |  3 +-
 arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 21 ++++++
 arch/arm64/kvm/mmu.c                       | 64 ++++++++++++++++-
 arch/arm64/kvm/reset.c                     |  4 ++
 arch/arm64/kvm/sys_regs.c                  | 32 +++++++--
 include/uapi/linux/kvm.h                   |  2 +
 21 files changed, 419 insertions(+), 18 deletions(-)
 create mode 100644 arch/arm64/include/asm/kvm_mte.h

-- 
2.20.1

Re: [PATCH v17 0/6] MTE support for KVM guest
Posted by Marc Zyngier 2 years, 10 months ago
On Mon, 21 Jun 2021 12:17:10 +0100, Steven Price wrote:
> This series adds support for using the Arm Memory Tagging Extensions
> (MTE) in a KVM guest.
> 
> Changes since v16[1]:
> 
>  - Dropped the first patch ("Handle race when synchronising tags") as
>    it's not KVM specific and by restricting MAP_SHARED in KVM there is
>    no longer a dependency.
> 
> [...]

Applied to next, thanks!

[1/6] arm64: mte: Sync tags for pages where PTE is untagged
      commit: 69e3b846d8a753f9f279f29531ca56b0f7563ad0
[2/6] KVM: arm64: Introduce MTE VM feature
      commit: ea7fc1bb1cd1b92b42b1d9273ce7e231d3dc9321
[3/6] KVM: arm64: Save/restore MTE registers
      commit: e1f358b5046479d2897f23b1d5b092687c6e7a67
[4/6] KVM: arm64: Expose KVM_ARM_CAP_MTE
      commit: 673638f434ee4a00319e254ade338c57618d6f7e
[5/6] KVM: arm64: ioctl to fetch/store tags in a guest
      commit: f0376edb1ddcab19a473b4bf1fbd5b6bbed3705b
[6/6] KVM: arm64: Document MTE capability and ioctl
      commit: 04c02c201d7e8149ae336ead69fb64e4e6f94bc9

I performed a number of changes in user_mem_abort(), so please
have a look at the result. It is also pretty late in the merge
cycle, so if anything looks amiss, I'll just drop it.

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.



Re: [PATCH v17 0/6] MTE support for KVM guest
Posted by Steven Price 2 years, 10 months ago
On 22/06/2021 15:21, Marc Zyngier wrote:
> On Mon, 21 Jun 2021 12:17:10 +0100, Steven Price wrote:
>> This series adds support for using the Arm Memory Tagging Extensions
>> (MTE) in a KVM guest.
>>
>> Changes since v16[1]:
>>
>>  - Dropped the first patch ("Handle race when synchronising tags") as
>>    it's not KVM specific and by restricting MAP_SHARED in KVM there is
>>    no longer a dependency.
>>
>> [...]
> 
> Applied to next, thanks!
> 
> [1/6] arm64: mte: Sync tags for pages where PTE is untagged
>       commit: 69e3b846d8a753f9f279f29531ca56b0f7563ad0
> [2/6] KVM: arm64: Introduce MTE VM feature
>       commit: ea7fc1bb1cd1b92b42b1d9273ce7e231d3dc9321
> [3/6] KVM: arm64: Save/restore MTE registers
>       commit: e1f358b5046479d2897f23b1d5b092687c6e7a67
> [4/6] KVM: arm64: Expose KVM_ARM_CAP_MTE
>       commit: 673638f434ee4a00319e254ade338c57618d6f7e
> [5/6] KVM: arm64: ioctl to fetch/store tags in a guest
>       commit: f0376edb1ddcab19a473b4bf1fbd5b6bbed3705b
> [6/6] KVM: arm64: Document MTE capability and ioctl
>       commit: 04c02c201d7e8149ae336ead69fb64e4e6f94bc9
> 
> I performed a number of changes in user_mem_abort(), so please
> have a look at the result. It is also pretty late in the merge
> cycle, so if anything looks amiss, I'll just drop it.

It all looks good to me - thanks for making those changes.

Steve