1. Patchew
  2. QEMU
  3. View series

[PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

Jonathan Albrecht posted 2 patches 2 years, 10 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
linux-user/s390x/cpu_loop.c     |  19 +++---
tests/tcg/s390x/Makefile.target |   1 +
tests/tcg/s390x/trap.c          | 100 ++++++++++++++++++++++++++++++++
3 files changed, 111 insertions(+), 9 deletions(-)
create mode 100644 tests/tcg/s390x/trap.c
[PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by Jonathan Albrecht 2 years, 10 months ago 
qemu-s390x signals with SIGILL on compare-and-trap instructions. This
breaks OpenJDK which expects SIGFPE in its implementation of implicit
exceptions.

This patch depends on [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr
reporting.
https://lore.kernel.org/qemu-devel/20210602002210.3144559-1-iii@linux.ibm.com/

Based-on: 20210602002210.3144559-1-iii@linux.ibm.com

Jonathan Albrecht (2):
  linux-user/s390x: signal with SIGFPE on compare-and-trap
  tests/tcg: Test that compare-and-trap raises SIGFPE

 linux-user/s390x/cpu_loop.c     |  19 +++---
 tests/tcg/s390x/Makefile.target |   1 +
 tests/tcg/s390x/trap.c          | 100 ++++++++++++++++++++++++++++++++
 3 files changed, 111 insertions(+), 9 deletions(-)
 create mode 100644 tests/tcg/s390x/trap.c

-- 
2.31.1
Re: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by Cornelia Huck 2 years, 9 months ago 
On Mon, Jun 21 2021, Jonathan Albrecht <jonathan.albrecht@linux.vnet.ibm.com> wrote:

> qemu-s390x signals with SIGILL on compare-and-trap instructions. This
> breaks OpenJDK which expects SIGFPE in its implementation of implicit
> exceptions.
>
> This patch depends on [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr
> reporting.
> https://lore.kernel.org/qemu-devel/20210602002210.3144559-1-iii@linux.ibm.com/
>
> Based-on: 20210602002210.3144559-1-iii@linux.ibm.com
>
> Jonathan Albrecht (2):
>   linux-user/s390x: signal with SIGFPE on compare-and-trap
>   tests/tcg: Test that compare-and-trap raises SIGFPE
>
>  linux-user/s390x/cpu_loop.c     |  19 +++---
>  tests/tcg/s390x/Makefile.target |   1 +
>  tests/tcg/s390x/trap.c          | 100 ++++++++++++++++++++++++++++++++
>  3 files changed, 111 insertions(+), 9 deletions(-)
>  create mode 100644 tests/tcg/s390x/trap.c

Assuming that this will also go through the linux-user tree:

Acked-by: Cornelia Huck <cohuck@redhat.com>
Re: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by jonathan.albrecht 2 years, 9 months ago 
On 2021-07-05 5:29 am, Cornelia Huck wrote:
> On Mon, Jun 21 2021, Jonathan Albrecht
> <jonathan.albrecht@linux.vnet.ibm.com> wrote:
> 
>> qemu-s390x signals with SIGILL on compare-and-trap instructions. This
>> breaks OpenJDK which expects SIGFPE in its implementation of implicit
>> exceptions.
>> 
>> This patch depends on [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr
>> reporting.
>> https://lore.kernel.org/qemu-devel/20210602002210.3144559-1-iii@linux.ibm.com/
>> 
>> Based-on: 20210602002210.3144559-1-iii@linux.ibm.com
>> 
>> Jonathan Albrecht (2):
>>   linux-user/s390x: signal with SIGFPE on compare-and-trap
>>   tests/tcg: Test that compare-and-trap raises SIGFPE
>> 
>>  linux-user/s390x/cpu_loop.c     |  19 +++---
>>  tests/tcg/s390x/Makefile.target |   1 +
>>  tests/tcg/s390x/trap.c          | 100 
>> ++++++++++++++++++++++++++++++++
>>  3 files changed, 111 insertions(+), 9 deletions(-)
>>  create mode 100644 tests/tcg/s390x/trap.c
> 
> Assuming that this will also go through the linux-user tree:
> 
> Acked-by: Cornelia Huck <cohuck@redhat.com>

Thanks and yes, IIUC, 
https://lore.kernel.org/qemu-devel/20210705210434.45824-1-iii@linux.ibm.com/
is going through the linux-user tree so this should as well.

I'm going to send a v2 of this patch shortly to fix conflicts with the 
latest
tests/tcg/s390x/Makefile.target changes.

Jon
Re: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by no-reply@patchew.org 2 years, 10 months ago 
Patchew URL: https://patchew.org/QEMU/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com
Subject: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210526142438.281477-1-f4bug@amsat.org -> patchew/20210526142438.281477-1-f4bug@amsat.org
 - [tag update]      patchew/20210614083800.1166166-1-richard.henderson@linaro.org -> patchew/20210614083800.1166166-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com -> patchew/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com
Switched to a new branch 'test'
c6b3ba6 tests/tcg: Test that compare-and-trap raises SIGFPE
7bab442 linux-user/s390x: signal with SIGFPE on compare-and-trap

=== OUTPUT BEGIN ===
1/2 Checking commit 7bab4427a5e9 (linux-user/s390x: signal with SIGFPE on compare-and-trap)
2/2 Checking commit c6b3ba625805 (tests/tcg: Test that compare-and-trap raises SIGFPE)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

ERROR: do not initialise globals to 0 or NULL
#71: FILE: tests/tcg/s390x/trap.c:42:
+int sigfpe_count = 0;

ERROR: do not initialise globals to 0 or NULL
#72: FILE: tests/tcg/s390x/trap.c:43:
+int sigill_count = 0;

ERROR: trailing whitespace
#83: FILE: tests/tcg/s390x/trap.c:54:
+    $

ERROR: trailing whitespace
#116: FILE: tests/tcg/s390x/trap.c:87:
+        : $

total: 4 errors, 1 warnings, 104 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew 2.1-devel-8c64711

© 2016 - 2024 Red Hat, Inc.