[PATCH 0/2] build improvments

Konstantin Kostiuk posted 2 patches 1 year, 11 months ago
Only 0 patches received!
There is a newer version of this series
configure                 | 3 +++
qga/vss-win32/meson.build | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
[PATCH 0/2] build improvments
Posted by Konstantin Kostiuk 1 year, 11 months ago
Konstantin Kostiuk (2):
  configure: Add cross prefix for widl tool
  qga-vss: always build qga-vss.tlb when qga-vss.dll is built

 configure                 | 3 +++
 qga/vss-win32/meson.build | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

--
2.25.1
Re: [PATCH 0/2] build improvments
Posted by Paolo Bonzini 1 year, 11 months ago
On 4/28/22 20:21, Konstantin Kostiuk wrote:
> Konstantin Kostiuk (2):
>    configure: Add cross prefix for widl tool
>    qga-vss: always build qga-vss.tlb when qga-vss.dll is built
> 
>   configure                 | 3 +++
>   qga/vss-win32/meson.build | 4 ++--
>   2 files changed, 5 insertions(+), 2 deletions(-)

Both titles make sense, but they didn't reach the mailing list.

Paolo
Re: [PATCH 0/2] build improvments
Posted by Daniel P. Berrangé 1 year, 11 months ago
On Fri, Apr 29, 2022 at 12:10:34AM +0200, Paolo Bonzini wrote:
> On 4/28/22 20:21, Konstantin Kostiuk wrote:
> > Konstantin Kostiuk (2):
> >    configure: Add cross prefix for widl tool
> >    qga-vss: always build qga-vss.tlb when qga-vss.dll is built
> > 
> >   configure                 | 3 +++
> >   qga/vss-win32/meson.build | 4 ++--
> >   2 files changed, 5 insertions(+), 2 deletions(-)
> 
> Both titles make sense, but they didn't reach the mailing list.

They did, but were each sent as standalone mail threads before this
cover letter was sent.

Konstantin: I'd suggest using 'git-publish' for sending patches in
future, as it automatically does the right thing, ensuring that the
threading is set correctly, and has many other benefits over sending
patch emails manually

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH 0/2] build improvments
Posted by Konstantin Kostiuk 1 year, 11 months ago
Hi Daniel,

This was my mistake when I sent patches.
Thanks for your comment.

Best Regards,
Konstantin Kostiuk.


On Tue, May 3, 2022 at 11:59 AM Daniel P. Berrangé <berrange@redhat.com>
wrote:

> On Fri, Apr 29, 2022 at 12:10:34AM +0200, Paolo Bonzini wrote:
> > On 4/28/22 20:21, Konstantin Kostiuk wrote:
> > > Konstantin Kostiuk (2):
> > >    configure: Add cross prefix for widl tool
> > >    qga-vss: always build qga-vss.tlb when qga-vss.dll is built
> > >
> > >   configure                 | 3 +++
> > >   qga/vss-win32/meson.build | 4 ++--
> > >   2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > Both titles make sense, but they didn't reach the mailing list.
>
> They did, but were each sent as standalone mail threads before this
> cover letter was sent.
>
> Konstantin: I'd suggest using 'git-publish' for sending patches in
> future, as it automatically does the right thing, ensuring that the
> threading is set correctly, and has many other benefits over sending
> patch emails manually
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-
> https://www.instagram.com/dberrange :|
>
>