[v1] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper

[PATCH 4/7] block: Make bdrv_co_pwrite() take a const buffer

Posted by Alberto Faria 3 years, 2 months ago

It does not mutate the buffer.

Signed-off-by: Alberto Faria <afaria@redhat.com>
---
 include/block/block_int-io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/block/block_int-io.h b/include/block/block_int-io.h
index bb454200e5..d4d3bed783 100644
--- a/include/block/block_int-io.h
+++ b/include/block/block_int-io.h
@@ -65,7 +65,7 @@ static inline int coroutine_fn bdrv_co_pread(BdrvChild *child,
 }
 
 static inline int coroutine_fn bdrv_co_pwrite(BdrvChild *child,
-    int64_t offset, unsigned int bytes, void *buf, BdrvRequestFlags flags)
+    int64_t offset, unsigned int bytes, const void *buf, BdrvRequestFlags flags)
 {
     QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
     IO_CODE();
-- 
2.35.3

Re: [PATCH 4/7] block: Make bdrv_co_pwrite() take a const buffer

Posted by Paolo Bonzini 3 years, 2 months ago

On 5/13/22 01:51, Alberto Faria wrote:
> It does not mutate the buffer.
> 
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---
>   include/block/block_int-io.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/block/block_int-io.h b/include/block/block_int-io.h
> index bb454200e5..d4d3bed783 100644
> --- a/include/block/block_int-io.h
> +++ b/include/block/block_int-io.h
> @@ -65,7 +65,7 @@ static inline int coroutine_fn bdrv_co_pread(BdrvChild *child,
>   }
>   
>   static inline int coroutine_fn bdrv_co_pwrite(BdrvChild *child,
> -    int64_t offset, unsigned int bytes, void *buf, BdrvRequestFlags flags)
> +    int64_t offset, unsigned int bytes, const void *buf, BdrvRequestFlags flags)
>   {
>       QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
>       IO_CODE();

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>