From nobody Fri Mar 29 08:05:25 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652425020; cv=none; d=zohomail.com; s=zohoarc; b=ReiBdkqWRRE8lt6jAemU0tuQw/wdZUd3FeFGdPFely2nBEIYXQ2xWr+Y6Cx9UG+obdgqkn2V5MwMtJ/s5bJb7C1NeUzu6JarnWMNWGM8noi6SvzKMurhCzAKWIJVaQYJltNhBKEkew5FEWtqiEwGhZHPygOaz2kSMC4v8Naephg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652425020; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=0okOiT0JN/X+4hgbnttpcxmH7C+3E6fDqYANI5U2lL4=; b=JUrkMIdENa/PMR/+f6YbLR4yrdQyR9RNFvHgXkpLtLrzVaZFZ5bpGm02QUAP+Xdx0OImh1M9V5p1K11+uIH+VbtaiyRI1egr+kFR08H8C2rWjAzxhZqFadRCehnh3C3OQ7xpAXTE0277HxzWPgcADqnnZoPmrrUpX6qghpPh+IQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652425020152993.1670410634331; Thu, 12 May 2022 23:57:00 -0700 (PDT) Received: from localhost ([::1]:49630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npPER-0006p4-0H for importer2@patchew.org; Fri, 13 May 2022 02:56:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npOy9-00072A-Mb for qemu-devel@nongnu.org; Fri, 13 May 2022 02:40:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:45747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npOy7-0002E4-LQ for qemu-devel@nongnu.org; Fri, 13 May 2022 02:40:09 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-PEQIOkR9PiOn1E3UseAQTQ-1; Fri, 13 May 2022 02:40:03 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC1953C11744; Fri, 13 May 2022 06:40:02 +0000 (UTC) Received: from thuth.com (unknown [10.39.193.0]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7C7B84010E20; Fri, 13 May 2022 06:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652424006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0okOiT0JN/X+4hgbnttpcxmH7C+3E6fDqYANI5U2lL4=; b=DBCO1ciQYY3Zjb3IenF4Zm078Gz8oWIhCw+BAQ8ZAxwTjGCqsJB7YZWC3WswC+zZQxsQR6 aW+hUK+JDHXvFQhMDJIhqjREzJzhoAM+eq3xujqc4OXJD4hOFd7dyowX59knPiQaIPDqTn hXoxMd6HC5ia9CrTLb+QArVEheQQmqI= X-MC-Unique: PEQIOkR9PiOn1E3UseAQTQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, Stefan Weil Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Yonggang Luo Subject: [PATCH v3] docs/about: Update the support statement for Windows Date: Fri, 13 May 2022 08:39:58 +0200 Message-Id: <20220513063958.1181443-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652425021882100001 Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to the API of Windows, and this is not easy to understand for the non-technical users. Additionally, glib sets the _WIN32_WINNT macro to 0x0601 already, which indicates the Windows 7 API, so QEMU effectively depends on the Windows 7 API, too. Thus let's bump the _WIN32_WINNT setting in QEMU to the same level as glib uses and adjust our support statement in the documentation to something similar that we're using for Linux and the *BSD systems (i.e. only the two most recent versions), which should hopefully be easier to understand for the users now. And since we're nowadays also compile-testing QEMU with MSYS2 on Windows itself, I think we could mention this build environment here, too. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/880 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Stefan Weil =20 Signed-off-by: Thomas Huth --- v3: - Add words about the dependency between glib and _WIN32_WINNT - Addded Reviewed-bys from Daniel and Stefan (if you don't like the new comments from v3, please complain!) docs/about/build-platforms.rst | 14 +++++++++----- configure | 2 ++ include/qemu/osdep.h | 2 +- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst index e9163ba556..1958edb430 100644 --- a/docs/about/build-platforms.rst +++ b/docs/about/build-platforms.rst @@ -86,11 +86,15 @@ similar versions. Windows ------- =20 -The project supports building with current versions of the MinGW toolchain, -hosted on Linux (Debian/Fedora). - -The version of the Windows API that's currently targeted is Vista / Server -2008. +The project aims to support the two most recent versions of Windows that a= re +still supported by the vendor. The minimum Windows API that is currently +targeted is "Windows 7", so theoretically the QEMU binaries can still be r= un +on older versions of Windows, too. However, such old versions of Windows a= re +not tested anymore, so it is recommended to use one of the latest versions= of +Windows instead. + +The project supports building QEMU with current versions of the MinGW +toolchain, either hosted on Linux (Debian/Fedora) or via MSYS2 on Windows. =20 .. _Homebrew: https://brew.sh/ .. _MacPorts: https://www.macports.org/ diff --git a/configure b/configure index e77b29b093..443d1741bf 100755 --- a/configure +++ b/configure @@ -1490,6 +1490,8 @@ fi ########################################## # glib support probe =20 +# When bumping glib_req_ver, please check also whether we should increase +# the _WIN32_WINNT setting in osdep.h according to the value from glib glib_req_ver=3D2.56 glib_modules=3Dgthread-2.0 if test "$modules" =3D yes; then diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 1c1e7eca98..a72e99db85 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -75,7 +75,7 @@ QEMU_EXTERN_C int daemon(int, int); #ifdef _WIN32 /* as defined in sdkddkver.h */ #ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0600 /* Vista */ +#define _WIN32_WINNT 0x0601 /* Windows 7 API (should be in sync with glib)= */ #endif /* reduces the number of implicitly included headers */ #ifndef WIN32_LEAN_AND_MEAN --=20 2.27.0