[PATCH] target/arm/helper.c: Delete stray obsolete comment

Peter Maydell posted 1 patch 1 week ago
target/arm/helper.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] target/arm/helper.c: Delete stray obsolete comment
Posted by Peter Maydell 1 week ago
In commit 88ce6c6ee85d we switched from directly fishing the number
of breakpoints and watchpoints out of the ID register fields to
abstracting out functions to do this job, but we forgot to delete the
now-obsolete comment in define_debug_regs() about the relation
between the ID field value and the actual number of breakpoints and
watchpoints.  Delete the obsolete comment.

Reported-by: CHRIS HOWARD <cvz185@web.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 432bd819195..3184fcb7797 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -6529,7 +6529,6 @@ static void define_debug_regs(ARMCPU *cpu)
         define_one_arm_cp_reg(cpu, &dbgdidr);
     }
 
-    /* Note that all these register fields hold "number of Xs minus 1". */
     brps = arm_num_brps(cpu);
     wrps = arm_num_wrps(cpu);
     ctx_cmps = arm_num_ctx_cmps(cpu);
-- 
2.25.1
Re: [PATCH] target/arm/helper.c: Delete stray obsolete comment
Posted by Richard Henderson 1 week ago
On 5/13/22 06:18, Peter Maydell wrote:
> In commit 88ce6c6ee85d we switched from directly fishing the number
> of breakpoints and watchpoints out of the ID register fields to
> abstracting out functions to do this job, but we forgot to delete the
> now-obsolete comment in define_debug_regs() about the relation
> between the ID field value and the actual number of breakpoints and
> watchpoints.  Delete the obsolete comment.
> 
> Reported-by: CHRIS HOWARD<cvz185@web.de>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   target/arm/helper.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Re: [PATCH] target/arm/helper.c: Delete stray obsolete comment
Posted by Alex Bennée 1 week ago
Peter Maydell <peter.maydell@linaro.org> writes:

> In commit 88ce6c6ee85d we switched from directly fishing the number
> of breakpoints and watchpoints out of the ID register fields to
> abstracting out functions to do this job, but we forgot to delete the
> now-obsolete comment in define_debug_regs() about the relation
> between the ID field value and the actual number of breakpoints and
> watchpoints.  Delete the obsolete comment.
>
> Reported-by: CHRIS HOWARD <cvz185@web.de>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée