From nobody Thu Jul 3 18:44:31 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652457252; cv=none; d=zohomail.com; s=zohoarc; b=A6nWGe9YJIM29MSzgdMMDEdRe0Hnqx2NrSzjYW1gGLylXzF6XSQKGZ76aoVlQ/641GXxhEppcy7DO95HLh/GlW0ZYQ5nccK/wLUg9RUpbndXDeyf9WGW377l7YioQz682yEbBMaR45kYrlCsGFRP/ilutd35nxmnK3lzTzNDLOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652457252; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EXoZzIrUFSIgWUGknGtxTRFqHJIoaDs0nio3CNHmeZw=; b=PhMu84MOl2VrsM0UzEvUUBKpwBSXoFk8cWwClX96ARoqNTHZlHgKJyaWWp2pYoROVrUqipttwMtRGtj1e1iHGlPQwD1UiJIGvSNKOysRwS6WxGc7M0SN7UQLm3UH/l2qZzpU5OVsLfVxOxpDmhnZl0xFghbz5vuVHpGn6CXD5eA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652457252870128.63708527397625; Fri, 13 May 2022 08:54:12 -0700 (PDT) Received: from localhost ([::1]:37928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npXcJ-0003EB-Qt for importer2@patchew.org; Fri, 13 May 2022 11:54:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXXW-0005sS-FR for qemu-devel@nongnu.org; Fri, 13 May 2022 11:49:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXXU-0000fN-7i for qemu-devel@nongnu.org; Fri, 13 May 2022 11:49:13 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-16-mP-hq8PtMsmvjFpEqPRSnA-1; Fri, 13 May 2022 11:49:10 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4A38811E75 for ; Fri, 13 May 2022 15:49:09 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id EBB681468961; Fri, 13 May 2022 15:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652456951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EXoZzIrUFSIgWUGknGtxTRFqHJIoaDs0nio3CNHmeZw=; b=AcvB4T1D0SvosZUcHbWrpY1DhOch4ako29Gbg4vfqnfLfZYAaGBos0rJK2PG/HGXLMk/ZC KOyUZcJNd8K74739QjzvlTq3j4fPy7+LosQzWp13mCMdEl1X2MOQvfr9MHF93RSr2BmdUq k05aUDBoaCpk1KoZl7axuNgLb4TCFJM= X-MC-Unique: mP-hq8PtMsmvjFpEqPRSnA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 1/2] tests/qtest: fix registration of ABRT handler for QEMU cleanup Date: Fri, 13 May 2022 16:49:05 +0100 Message-Id: <20220513154906.206715-2-berrange@redhat.com> In-Reply-To: <20220513154906.206715-1-berrange@redhat.com> References: <20220513154906.206715-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652457254403100001 qtest_init registers a hook to cleanup the running QEMU process should g_assert() fire before qtest_quit is called. When the first hook is registered, it is supposed to triggere registration of the SIGABRT handler. Unfortunately the logic in hook_list_is_empty is inverted, so the SIGABRT handler never gets registered, unless 2 or more QEMU processes are run concurrently. This caused qtest to leak QEMU processes anytime g_assert triggers. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Thomas Huth --- tests/qtest/libqtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 228357f1ea..4a4697c0d1 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -197,11 +197,11 @@ static bool hook_list_is_empty(GHookList *hook_list) GHook *hook =3D g_hook_first_valid(hook_list, TRUE); =20 if (!hook) { - return false; + return true; } =20 g_hook_unref(hook_list, hook); - return true; + return false; } =20 void qtest_add_abrt_handler(GHookFunc fn, const void *data) --=20 2.36.1