From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652688014; cv=none; d=zohomail.com; s=zohoarc; b=I8nOn0KL6uQ9m8O7/RVnydEVxQNf4vNpRkk/GYZPhqq8efNEnRyIDxyCgc3/UoThESMRAdFchvCO25uGvx4Rrb8FJ0sqw1LaxZstym4qzucl1e/q6MbXVFxQloeSb1LSLpHxCVY3ZADhPOr9+2f/YaQtEJDYyG5iA9YLTEezMu0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652688014; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nVs0tTWztHs6ZlUgnvC6/5Q8RdDUtZcXV4Z0DzV0zqg=; b=jz9Cz3ZkMwylipctb5a7Vl1RByrz/Ix8yMl/h7pgVD1NZXhFsX1sZoUR/pZBQiK0GgsKoEkGDmsnve27/CYnNmsgbZlP2sBg0oEVaBiNDVRmx8o17aNzo9M5AQlZ4WhhsDy/RCdHv2eTA2LZ/fPUuqdQqu1F8szRxLxxfLPN6q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652688014470737.1926875896797; Mon, 16 May 2022 01:00:14 -0700 (PDT) Received: from localhost ([::1]:44724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVeH-0002v9-AB for importer2@patchew.org; Mon, 16 May 2022 04:00:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGM-0000pE-RG for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGK-0001tK-Ba for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:29 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-9aO4TQ4-OHCLsLTuOOfuCg-1; Mon, 16 May 2022 03:35:24 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2093C85A5BE; Mon, 16 May 2022 07:35:24 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F173357038A; Mon, 16 May 2022 07:35:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D299D21E690F; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nVs0tTWztHs6ZlUgnvC6/5Q8RdDUtZcXV4Z0DzV0zqg=; b=CTFYIFg8QeGY3yYVxDAC/jXPTiB0quYYqkohRsIZaFigKHY60ehkFr+UWI6iDsoNvzSJus 4TQMCn+56XT+rHK7XnGRFYr6uyCHp6B3GoS9HefEJP1UVpC93QJFkOtzJj1MlNPW9JRrjB gYJEDIN3NP8IyrY5FcoTNUfaPdzlmgI= X-MC-Unique: 9aO4TQ4-OHCLsLTuOOfuCg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani Subject: [PULL 01/11] qapi: Fix malformed "Since:" section tags Date: Mon, 16 May 2022 09:35:12 +0200 Message-Id: <20220516073522.3880774-2-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652688016759100001 Content-Type: text/plain; charset="utf-8" "Since X.Y" is not recognized as a tagged section, and therefore not formatted as such in generated documentation. Fix by adding the required colon. Signed-off-by: Markus Armbruster Message-Id: <20220422132807.1704411-1-armbru@redhat.com> Reviewed-by: Andrea Bolognani --- qapi/crypto.json | 3 +-- qapi/machine.json | 2 +- qapi/misc.json | 2 +- qga/qapi-schema.json | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/qapi/crypto.json b/qapi/crypto.json index 1ec54c15ca..8e0b4764e5 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -357,8 +357,7 @@ # password to use to retrieve current master key. # Defaults to the same secret that was used to open the im= age # -# -# Since 5.1 +# Since: 5.1 ## { 'struct': 'QCryptoBlockAmendOptionsLUKS', 'data': { 'state': 'QCryptoBlockLUKSKeyslotState', diff --git a/qapi/machine.json b/qapi/machine.json index 92480d4044..c9bdae40eb 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -972,7 +972,7 @@ # preconfigure stage to configure numa mapping before initializing # machine. # -# Since 3.0 +# Since: 3.0 ## { 'command': 'set-numa-node', 'boxed': true, 'data': 'NumaOptions', diff --git a/qapi/misc.json b/qapi/misc.json index b83cc39029..f8a9feda30 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -188,7 +188,7 @@ # Features: # @unstable: This command is experimental. # -# Since 3.0 +# Since: 3.0 # # Returns: nothing # diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 4d8e506c9e..f989597b0c 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -950,7 +950,7 @@ # by device mapper # @smart: disk smart information (Since 7.1) # -# Since 5.2 +# Since: 5.2 ## { 'struct': 'GuestDiskInfo', 'data': {'name': 'str', 'partition': 'bool', '*dependencies': ['str'], --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652688486; cv=none; d=zohomail.com; s=zohoarc; b=R6FaQNlryxvpS8ljDo9Y4Bx3nb9NrkOl7OWed1oYQIAJ5eToCdHgf4p44WHA7B2QvJ1RyVYss48sLxREy+fEgyqij+kUoMaWGZBkBIixm+wsDvdfc7bOCSapq/NjzY5x9eOc6p7N0BrhQBiHvAhzBVIrnPFqu1JE5Nm/E/glJGM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652688486; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eB37xzaj5t3hlyAMC3PdsWUdgi/jS8WofcSb+WdbxdU=; b=f+oBGJtEXCzjc8XUUJyLpomFaBL39rN/XcvOWZv90D2ZDLzMpmr6vthigWyIfmPZxx/hpo0jrqdH4Goq/t7fgAq7m8/wDCQTkHwyq4R3MzCPjULMen2L9IHOtPF+Qya9VxQ8tOZQi+qsX6kIeZRS1HDdz+hnfdMt7gq/VUHGxfg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652688486128869.8423674966116; Mon, 16 May 2022 01:08:06 -0700 (PDT) Received: from localhost ([::1]:50158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVls-00073e-Ka for importer2@patchew.org; Mon, 16 May 2022 04:08:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGO-0000qY-0b for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGK-0001tG-HS for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:31 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-HpJE0cWcMgKrVbFXMAzbcQ-1; Mon, 16 May 2022 03:35:26 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 11E063C1023B; Mon, 16 May 2022 07:35:26 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1B9D1121315; Mon, 16 May 2022 07:35:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D4B4621E6921; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eB37xzaj5t3hlyAMC3PdsWUdgi/jS8WofcSb+WdbxdU=; b=HV+RqUIS3Xi4yjccujLBEOSPSBwVqQMynd0fO+tGRHuzctZCK3tFiCNAVz8+oso6sqy7R4 sh1mq6lOn1DXYMd0NB2RW4W7i3wwPyTyYIi7oUNSlrswIeYIwGOC4+3zjIrWS1ddSaeinB QC6/YgXXJQ4YKLREwacZjH1k09BvN/w= X-MC-Unique: HpJE0cWcMgKrVbFXMAzbcQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani Subject: [PULL 02/11] qapi: Drop stray trailing symbol Date: Mon, 16 May 2022 09:35:13 +0200 Message-Id: <20220516073522.3880774-3-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652688486621100001 Content-Type: text/plain; charset="utf-8" From: Andrea Bolognani Signed-off-by: Andrea Bolognani Reviewed-by: Markus Armbruster Message-Id: <20220503073737.84223-2-abologna@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/run-state.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 8124220bd9..15d6c9a2ed 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -348,7 +348,7 @@ # # @poweroff: Shutdown the VM and exit # -# @pause: pause the VM# +# @pause: pause the VM # # Since: 6.0 ## --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652686797; cv=none; d=zohomail.com; s=zohoarc; b=Jbswe5V/8quXFk+GVXNAW/M+VUodZRSrrVkfnkqnNvw1GpBuJZczGrfoM3f8505VJnUQldF9b97/vD7Dg3AqBxLhtfnUu7BxYque4LpB8jaiJ4rvTKgYpC421eOEETDuqC2g950MYhuE0Oy9Ly7vcud/4J6+BWsc2YdI9BZDxzM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652686797; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dT4CDD+s8wLTAwyNQfrSeU31Dq3MJShXXZUgqOK4k7k=; b=V/8wdGuHILD0WmyKX7a3wK6Km6F3Ea5JBonLp2ijwbF++u+/yi9JlIlilrWeMdH/mmp60uyicpc2BwXCz0aDZ3deJ9jRJkg+m195YVjBzjfsR5JjxR1shur+NeUM6dQrkWRl/BusfLdfLpLnRc3KZGhrjXz0UP1JBqKvz9cwd7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652686797361275.76426088910557; Mon, 16 May 2022 00:39:57 -0700 (PDT) Received: from localhost ([::1]:50464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVKd-0003k1-VR for importer2@patchew.org; Mon, 16 May 2022 03:39:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGL-0000p1-QJ for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGJ-0001qy-0t for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:28 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610-kHrj4v3yNteA3s2774nG-g-1; Mon, 16 May 2022 03:35:24 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20504811E78; Mon, 16 May 2022 07:35:24 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F167456F8D4; Mon, 16 May 2022 07:35:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D6C8021E6926; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dT4CDD+s8wLTAwyNQfrSeU31Dq3MJShXXZUgqOK4k7k=; b=eHUANBDVuMwJzoPXXFv3GWVsJuTe48kHcwx3ratQ1tgmqK7ZmovMYg0glxKjWA/5wB0WhU y2Z7uwfp1GfGAA1UTcemr7SdDvCc5nl4IfICdq+xmJ9wCZKs/5NiNjQgBr4q4BbLFL2cye ek5x5rmj1rLBWFtq19kI40HFEoN6dO8= X-MC-Unique: kHrj4v3yNteA3s2774nG-g-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani Subject: [PULL 03/11] qapi: Fix comment indentation Date: Mon, 16 May 2022 09:35:14 +0200 Message-Id: <20220516073522.3880774-4-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652686799195100003 Content-Type: text/plain; charset="utf-8" From: Andrea Bolognani It should start on the very first column. Signed-off-by: Andrea Bolognani Reviewed-by: Markus Armbruster Message-Id: <20220503073737.84223-3-abologna@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/ui.json | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 059302a5ef..43e62efd76 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1250,21 +1250,21 @@ '*p2p': 'bool', '*audiodev': 'str' } } =20 - ## - # @DisplayGLMode: - # - # Display OpenGL mode. - # - # @off: Disable OpenGL (default). - # @on: Use OpenGL, pick context type automatically. - # Would better be named 'auto' but is called 'on' for backward - # compatibility with bool type. - # @core: Use OpenGL with Core (desktop) Context. - # @es: Use OpenGL with ES (embedded systems) Context. - # - # Since: 3.0 - # - ## +## +# @DisplayGLMode: +# +# Display OpenGL mode. +# +# @off: Disable OpenGL (default). +# @on: Use OpenGL, pick context type automatically. +# Would better be named 'auto' but is called 'on' for backward +# compatibility with bool type. +# @core: Use OpenGL with Core (desktop) Context. +# @es: Use OpenGL with ES (embedded systems) Context. +# +# Since: 3.0 +# +## { 'enum' : 'DisplayGLMode', 'data' : [ 'off', 'on', 'core', 'es' ] } =20 --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652688050; cv=none; d=zohomail.com; s=zohoarc; b=ht3W9sQoBKTO32Tc+iQ2ebuIu4wWYV8mV4GsR6vdjt8T5v59+MTZ355wHHbobWWjUeOExEEXHN+t6nSI8s2TNmC0/qiUI08rfCORbGmcMFbmyqvms3IhEsF6Yw2/xjFzQdfhtG0EZB885L8Boy5j5Tf3aoTkem18MJ1d3jykrBU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652688050; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sTgRsj8NlcLuxb0bTfm5LyIXjnSaPod2WbGMp9zC9sI=; b=ZwEzipcd7DEqtcNU0W5dbt1U9lC2LzxL0O+ZjFUAx03DSmy5Jm07uM9b53DSjytUN9dVcudl6D76TCYF4wvA1Pi27pQyDYtcBCplkt0K+o6yPQ3DwN+pPqL7qMQpHVY18a6GAXdc4o7yugmkqq9jQahxuLK9yESJleEzMNOqDAQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652688050878828.5167711546914; Mon, 16 May 2022 01:00:50 -0700 (PDT) Received: from localhost ([::1]:45282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVer-0003KF-Sc for importer2@patchew.org; Mon, 16 May 2022 04:00:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGO-0000qc-Gv for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGL-0001tl-Cs for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:32 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-hcQ6M61-Mhy5r-vE3d2ckA-1; Mon, 16 May 2022 03:35:24 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B8281D9F883; Mon, 16 May 2022 07:35:24 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F156940CF8E2; Mon, 16 May 2022 07:35:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D8E3E21E692B; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sTgRsj8NlcLuxb0bTfm5LyIXjnSaPod2WbGMp9zC9sI=; b=ajt2+gVUsC4dCcstf8+yBwspt+s/okugcfZZrtxm/qSQwFvrg2iad2R7qXBBkPPkmJ7XIJ dz2W0B/lsr/EEyvzQKqRHMbxVD0fckTX5jfux/pEoNUc7Xhqfz2LhCkekiPCMzUixURSAr X7k969RO5IqHwfa+NrKt4kTZ7cDGAl4= X-MC-Unique: hcQ6M61-Mhy5r-vE3d2ckA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani Subject: [PULL 04/11] qapi: Add missing separators between sections Date: Mon, 16 May 2022 09:35:15 +0200 Message-Id: <20220516073522.3880774-5-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652688052826100001 Content-Type: text/plain; charset="utf-8" From: Andrea Bolognani This only affects readability. The generated documentation doesn't change. Signed-off-by: Andrea Bolognani Reviewed-by: Markus Armbruster Message-Id: <20220503073737.84223-4-abologna@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/block-core.json | 5 +++++ qapi/block.json | 1 + qapi/crypto.json | 7 +++++++ qapi/machine.json | 1 + qapi/migration.json | 4 ++++ 5 files changed, 18 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index b66494e8c5..34dae298ee 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1744,6 +1744,7 @@ # Since: 2.3 # # Example: +# # -> { "execute": "blockdev-backup", # "arguments": { "device": "src-id", # "sync": "full", @@ -2008,6 +2009,7 @@ # @on-target-error: the action to take on an error on the target, # default 'report' (no limitations, since this applies to # a different block device than @device). +# # @unmap: Whether to try to unmap target sectors where source has # only zero. If true, and target unallocated sectors will read as = zero, # target image sectors will be unmapped; otherwise, zeroes will be @@ -2029,6 +2031,7 @@ # When true, this job will automatically disappear from the= query # list without user intervention. # Defaults to true. (Since 3.1) +# # Since: 1.3 ## { 'struct': 'DriveMirror', @@ -2342,6 +2345,7 @@ # When true, this job will automatically disappear from the= query # list without user intervention. # Defaults to true. (Since 3.1) +# # Returns: nothing on success. # # Since: 2.6 @@ -4139,6 +4143,7 @@ # @throttle-group: the name of the throttle-group object to use. It # must already exist. # @file: reference to or definition of the data source block device +# # Since: 2.11 ## { 'struct': 'BlockdevOptionsThrottle', diff --git a/qapi/block.json b/qapi/block.json index 3f100d4887..e0f7898ed1 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -105,6 +105,7 @@ # # Returns: - Nothing on success # - If @device is not a valid block device, DeviceNotFound +# # Notes: Ejecting a device with no media results in success # # Since: 0.14 diff --git a/qapi/crypto.json b/qapi/crypto.json index 8e0b4764e5..21c670eefa 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -32,6 +32,7 @@ # # @raw: raw bytes. When encoded in JSON only valid UTF-8 sequences can be = used # @base64: arbitrary base64 encoded binary data +# # Since: 2.6 ## { 'enum': 'QCryptoSecretFormat', @@ -51,6 +52,7 @@ # @sha384: SHA-384. (since 2.7) # @sha512: SHA-512. (since 2.7) # @ripemd160: RIPEMD-160. (since 2.7) +# # Since: 2.6 ## { 'enum': 'QCryptoHashAlgorithm', @@ -75,6 +77,7 @@ # @twofish-128: Twofish with 128 bit / 16 byte keys # @twofish-192: Twofish with 192 bit / 24 byte keys # @twofish-256: Twofish with 256 bit / 32 byte keys +# # Since: 2.6 ## { 'enum': 'QCryptoCipherAlgorithm', @@ -95,6 +98,7 @@ # @cbc: Cipher Block Chaining # @xts: XEX with tweaked code book and ciphertext stealing # @ctr: Counter (Since 2.8) +# # Since: 2.6 ## { 'enum': 'QCryptoCipherMode', @@ -114,6 +118,7 @@ # @plain: 64-bit sector number truncated to 32-bits # @plain64: 64-bit sector number # @essiv: 64-bit sector number encrypted with a hash of the encryption key +# # Since: 2.6 ## { 'enum': 'QCryptoIVGenAlgorithm', @@ -170,6 +175,7 @@ # @key-secret: the ID of a QCryptoSecret object providing the # decryption key. Mandatory except when probing image for # metadata only. +# # Since: 2.6 ## { 'struct': 'QCryptoBlockOptionsLUKS', @@ -194,6 +200,7 @@ # @iter-time: number of milliseconds to spend in # PBKDF passphrase processing. Currently defaults # to 2000. (since 2.8) +# # Since: 2.6 ## { 'struct': 'QCryptoBlockCreateOptionsLUKS', diff --git a/qapi/machine.json b/qapi/machine.json index c9bdae40eb..79901e1c09 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -299,6 +299,7 @@ # returning does not indicate that a guest has accepted the request= or # that it has shut down. Many guests will respond to this command = by # prompting the user in some way. +# # Example: # # -> { "execute": "system_powerdown" } diff --git a/qapi/migration.json b/qapi/migration.json index 409eb086a2..fc1c157d3f 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1422,7 +1422,9 @@ # @state: The state the migration is currently expected to be in # # Returns: nothing on success +# # Since: 2.11 +# # Example: # # -> { "execute": "migrate-continue" , "arguments": @@ -1736,6 +1738,7 @@ # Since: 4.2 # # Example: +# # <- { "event": "UNPLUG_PRIMARY", # "data": { "device-id": "hostdev0" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } @@ -1845,6 +1848,7 @@ # Since: 5.2 # # Example: +# # {"execute": "calc-dirty-rate", "arguments": {"calc-time": 1, # 'sample-pages': 512} } # --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652689327; cv=none; d=zohomail.com; s=zohoarc; b=TJ8sPVytGDC98cud40bj4AMlH0QmKj3mIt0lNEGUgaV/pkCi2muBikpPrnFNRIU9RHt+x/9cVdFVdTQtZb2lXh8IWpZho1UlAhObJh6A/mFcR1pjf95/GGaEcejH/wh44fHhS7bEKk49ciUGVB/PKDIs09tGM75Jj6iHqHMhBY4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652689327; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v4QDV8+kl8agCrvtD/a8BVz0fMtXcbmVVTkr3G8xIAo=; b=PuevnGZBAjIs1xiy2c1h16lfAR/hnEAKOO3cQFO621iTBW+mwV3V/qVBSXt/0H2aWgys/DPNs+DpPPCQMwJZyLDys3j9paCyRuPA5GEvwmT5fmlaolb0298SEcKiVwNPxeHZSBFeIbAZ6jkJNVXEz+HjFJjpojiGzKqvUZ89ERQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16526893279541017.6049614611409; Mon, 16 May 2022 01:22:07 -0700 (PDT) Received: from localhost ([::1]:33280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVzS-0006pz-2A for importer2@patchew.org; Mon, 16 May 2022 04:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGN-0000qT-V5 for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGJ-0001s3-OA for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:30 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-336-S3aYnmwsPCS4KCMEgc8BvQ-1; Mon, 16 May 2022 03:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4CC61803D47; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0DD92492C14; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DB29521E6930; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v4QDV8+kl8agCrvtD/a8BVz0fMtXcbmVVTkr3G8xIAo=; b=TeNtVhnPWi1bw/JCt2rXNHrVu9YZWhH1S2ozOwvx3RZAEe1oM0RLjaWt67Nt58cyqj3pxY ClppD3AN4CYxWDQf4Q68CxaZHiKnuHFQGK1grCV2XDXwLrHGUM34INKTnzmdjEXbDIY+/a mMuBOT0MQjdNBfshaKCJetBll4SFUP8= X-MC-Unique: S3aYnmwsPCS4KCMEgc8BvQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani Subject: [PULL 05/11] qapi: Drop unnecessary empty lines in comments Date: Mon, 16 May 2022 09:35:16 +0200 Message-Id: <20220516073522.3880774-6-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652689328820100001 Content-Type: text/plain; charset="utf-8" From: Andrea Bolognani Signed-off-by: Andrea Bolognani Reviewed-by: Markus Armbruster Message-Id: <20220503073737.84223-5-abologna@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/block-core.json | 4 ---- qapi/block.json | 1 - qapi/char.json | 1 - qapi/common.json | 2 -- qapi/control.json | 2 -- qapi/machine.json | 2 -- qapi/migration.json | 7 ------- qapi/misc-target.json | 3 --- qapi/replay.json | 1 - qapi/run-state.json | 3 --- qapi/ui.json | 22 ---------------------- 11 files changed, 48 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 34dae298ee..27832a1244 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -237,7 +237,6 @@ # information (since 1.7) # # Since: 1.3 -# ## { 'struct': 'ImageInfo', 'data': {'filename': 'str', 'format': 'str', '*dirty-flag': 'bool', @@ -288,7 +287,6 @@ # supports it # # Since: 1.4 -# ## { 'struct': 'ImageCheck', 'data': {'filename': 'str', 'format': 'str', 'check-errors': 'int', @@ -328,7 +326,6 @@ # @filename: filename that is referred to by @offset # # Since: 2.6 -# ## { 'struct': 'MapEntry', 'data': {'start': 'int', 'length': 'int', 'data': 'bool', @@ -445,7 +442,6 @@ # has one or more dirty bitmaps) (Since 4.2) # # Since: 0.14 -# ## { 'struct': 'BlockDeviceInfo', 'data': { 'file': 'str', '*node-name': 'str', 'ro': 'bool', 'drv': 'str', diff --git a/qapi/block.json b/qapi/block.json index e0f7898ed1..5de15c6070 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -300,7 +300,6 @@ # @read-write: Makes the device writable # # Since: 2.3 -# ## { 'enum': 'BlockdevChangeReadOnlyMode', 'data': ['retain', 'read-only', 'read-write'] } diff --git a/qapi/char.json b/qapi/char.json index 7b42151575..f0fd0d1c9f 100644 --- a/qapi/char.json +++ b/qapi/char.json @@ -413,7 +413,6 @@ # @clipboard: enable/disable clipboard, default is disabled. # # Since: 6.1 -# ## { 'struct': 'ChardevQemuVDAgent', 'data': { '*mouse': 'bool', diff --git a/qapi/common.json b/qapi/common.json index 412cc4f5ae..356db3f670 100644 --- a/qapi/common.json +++ b/qapi/common.json @@ -192,7 +192,6 @@ # Keys to toggle input-linux between host and guest. # # Since: 4.0 -# ## { 'enum': 'GrabToggleKeys', 'data': [ 'ctrl-ctrl', 'alt-alt', 'shift-shift','meta-meta', 'scrolllock= ', @@ -204,7 +203,6 @@ # @human-readable-text: Formatted output intended for humans. # # Since: 6.2 -# ## { 'struct': 'HumanReadableText', 'data': { 'human-readable-text': 'str' } } diff --git a/qapi/control.json b/qapi/control.json index 71a838d49e..8c9122ef7a 100644 --- a/qapi/control.json +++ b/qapi/control.json @@ -33,7 +33,6 @@ # all the QMP capabilities will be turned off by default. # # Since: 0.13 -# ## { 'command': 'qmp_capabilities', 'data': { '*enable': [ 'QMPCapability' ] }, @@ -49,7 +48,6 @@ # (Please refer to qmp-spec.txt for more information on OOB) # # Since: 2.12 -# ## { 'enum': 'QMPCapability', 'data': [ 'oob' ] } diff --git a/qapi/machine.json b/qapi/machine.json index 79901e1c09..c8f07c43cd 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -77,7 +77,6 @@ # additional fields will be listed (since 3.0) # # Since: 2.12 -# ## { 'union' : 'CpuInfoFast', 'base' : { 'cpu-index' : 'int', @@ -1022,7 +1021,6 @@ # Formula used: logical_vm_size =3D vm_ram_size - balloon_size # # Since: 0.14 -# ## { 'struct': 'BalloonInfo', 'data': {'actual': 'int' } } =20 diff --git a/qapi/migration.json b/qapi/migration.json index fc1c157d3f..dd4dde6361 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -151,7 +151,6 @@ # (since 4.2) # # Since: 2.3 -# ## { 'enum': 'MigrationStatus', 'data': [ 'none', 'setup', 'cancelling', 'cancelled', @@ -166,7 +165,6 @@ # @transferred: amount of bytes transferred to the target VM by VFIO devic= es # # Since: 5.2 -# ## { 'struct': 'VfioStats', 'data': {'transferred': 'int' } } @@ -546,7 +544,6 @@ # @zstd: use zstd compression method. # # Since: 5.0 -# ## { 'enum': 'MultiFDCompression', 'data': [ 'none', 'zlib', @@ -1757,7 +1754,6 @@ # @dirty-rate: dirty rate. # # Since: 6.2 -# ## { 'struct': 'DirtyRateVcpu', 'data': { 'id': 'int', 'dirty-rate': 'int64' } } @@ -1774,7 +1770,6 @@ # @measured: the dirtyrate thread has measured and results are available. # # Since: 5.2 -# ## { 'enum': 'DirtyRateStatus', 'data': [ 'unstarted', 'measuring', 'measured'] } @@ -1791,7 +1786,6 @@ # @dirty-bitmap: calculate dirtyrate by dirty bitmap. # # Since: 6.2 -# ## { 'enum': 'DirtyRateMeasureMode', 'data': ['page-sampling', 'dirty-ring', 'dirty-bitmap'] } @@ -1821,7 +1815,6 @@ # mode specified (Since 6.2) # # Since: 5.2 -# ## { 'struct': 'DirtyRateInfo', 'data': {'*dirty-rate': 'int64', diff --git a/qapi/misc-target.json b/qapi/misc-target.json index ed4a468aab..ae2c483a68 100644 --- a/qapi/misc-target.json +++ b/qapi/misc-target.json @@ -110,7 +110,6 @@ # @data: the measurement value encoded in base64 # # Since: 2.12 -# ## { 'struct': 'SevLaunchMeasureInfo', 'data': {'data': 'str'}, 'if': 'TARGET_I386' } @@ -194,7 +193,6 @@ # @gpa: the guest physical address where secret will be injected. # # Since: 6.0 -# ## { 'command': 'sev-inject-launch-secret', 'data': { 'packet-header': 'str', 'secret': 'str', '*gpa': 'uint64' }, @@ -208,7 +206,6 @@ # # @data: guest attestation report (base64 encoded) # -# # Since: 6.1 ## { 'struct': 'SevAttestationReport', diff --git a/qapi/replay.json b/qapi/replay.json index 351898f60d..729470300d 100644 --- a/qapi/replay.json +++ b/qapi/replay.json @@ -40,7 +40,6 @@ # @icount: current number of executed instructions. # # Since: 5.2 -# ## { 'struct': 'ReplayInfo', 'data': { 'mode': 'ReplayMode', '*filename': 'str', 'icount': 'int' } } diff --git a/qapi/run-state.json b/qapi/run-state.json index 15d6c9a2ed..a5d2db3b91 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -592,7 +592,6 @@ # @guest: memory failure at guest memory, # # Since: 5.2 -# ## { 'enum': 'MemoryFailureRecipient', 'data': [ 'hypervisor', @@ -619,7 +618,6 @@ # to handle memory failures. # # Since: 5.2 -# ## { 'enum': 'MemoryFailureAction', 'data': [ 'ignore', @@ -639,7 +637,6 @@ # failure was still in progress. # # Since: 5.2 -# ## { 'struct': 'MemoryFailureFlags', 'data': { 'action-required': 'bool', diff --git a/qapi/ui.json b/qapi/ui.json index 43e62efd76..0e903340fc 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -15,7 +15,6 @@ # Display protocols which support changing password options. # # Since: 7.0 -# ## { 'enum': 'DisplayProtocol', 'data': [ 'vnc', 'spice' ] } @@ -32,7 +31,6 @@ # @disconnect: disconnect existing clients # # Since: 7.0 -# ## { 'enum': 'SetPasswordAction', 'data': [ 'keep', 'fail', 'disconnect' ] } @@ -52,7 +50,6 @@ # For VNC, only 'keep' is currently implemented. # # Since: 7.0 -# ## { 'union': 'SetPasswordOptions', 'base': { 'protocol': 'DisplayProtocol', @@ -70,7 +67,6 @@ # Defaults to the first. # # Since: 7.0 -# ## { 'struct': 'SetPasswordOptionsVnc', 'data': { '*display': 'str' } } @@ -115,7 +111,6 @@ # sure you are on the same machine as the QEMU instance. # # Since: 7.0 -# ## { 'union': 'ExpirePasswordOptions', 'base': { 'protocol': 'DisplayProtocol', @@ -132,7 +127,6 @@ # Defaults to the first. # # Since: 7.0 -# ## =20 { 'struct': 'ExpirePasswordOptionsVnc', @@ -167,7 +161,6 @@ # @ppm: PPM format # # Since: 7.1 -# ## { 'enum': 'ImageFormat', 'data': ['ppm', 'png'] } @@ -902,7 +895,6 @@ # are effectively synonyms. # # Since: 1.3 -# ## { 'enum': 'QKeyCode', 'data': [ 'unmapped', @@ -1206,7 +1198,6 @@ # Since 3.1 # # Since: 2.12 -# ## { 'struct' : 'DisplayGTK', 'data' : { '*grab-on-hover' : 'bool', @@ -1221,7 +1212,6 @@ # available node on the host. # # Since: 3.1 -# ## { 'struct' : 'DisplayEGLHeadless', 'data' : { '*rendernode' : 'str' } } @@ -1242,7 +1232,6 @@ # @audiodev: Use the specified DBus audiodev to export audio. # # Since: 7.0 -# ## { 'struct' : 'DisplayDBus', 'data' : { '*rendernode' : 'str', @@ -1263,7 +1252,6 @@ # @es: Use OpenGL with ES (embedded systems) Context. # # Since: 3.0 -# ## { 'enum' : 'DisplayGLMode', 'data' : [ 'off', 'on', 'core', 'es' ] } @@ -1276,7 +1264,6 @@ # @charset: Font charset used by guest (default: CP437). # # Since: 4.0 -# ## { 'struct' : 'DisplayCurses', 'data' : { '*charset' : 'str' } } @@ -1346,7 +1333,6 @@ # @dbus: Start a D-Bus service for the display. (Since 7.0) # # Since: 2.12 -# ## { 'enum' : 'DisplayType', 'data' : [ @@ -1376,7 +1362,6 @@ # @gl: Enable OpenGL support (default: off). # # Since: 2.12 -# ## { 'union' : 'DisplayOptions', 'base' : { 'type' : 'DisplayType', @@ -1403,7 +1388,6 @@ # Returns: @DisplayOptions # # Since: 3.1 -# ## { 'command': 'query-display-options', 'returns': 'DisplayOptions' } @@ -1416,7 +1400,6 @@ # @vnc: VNC display # # Since: 6.0 -# ## { 'enum': 'DisplayReloadType', 'data': ['vnc'] } @@ -1429,7 +1412,6 @@ # @tls-certs: reload tls certs or not. # # Since: 6.0 -# ## { 'struct': 'DisplayReloadOptionsVNC', 'data': { '*tls-certs': 'bool' } } @@ -1442,7 +1424,6 @@ # @type: Specify the display type. # # Since: 6.0 -# ## { 'union': 'DisplayReloadOptions', 'base': {'type': 'DisplayReloadType'}, @@ -1477,7 +1458,6 @@ # @vnc: VNC display # # Since: 7.1 -# ## { 'enum': 'DisplayUpdateType', 'data': ['vnc'] } @@ -1492,7 +1472,6 @@ # for websockets are not touched. # # Since: 7.1 -# ## { 'struct': 'DisplayUpdateOptionsVNC', 'data': { '*addresses': ['SocketAddress'] } } @@ -1505,7 +1484,6 @@ # @type: Specify the display type. # # Since: 7.1 -# ## { 'union': 'DisplayUpdateOptions', 'base': {'type': 'DisplayUpdateType'}, --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652686831; cv=none; d=zohomail.com; s=zohoarc; b=k7aVTm0iXfozfKjHm5naV4GFmUJnOdjQJA2VyuQJhf8M0PSEclgiYD4v0z+idx7U4yRKl7fCcJLZx6i/tDmm5we76QVhnM8WcaXCLXYJoRmfJ8ENo+LyXE233Z0quwQJiWNS4T+MgdjrF7kMkYQNpWTxV0l6FbgqhBrYxsm8B8g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652686831; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oliCzspkR/M43O0GQj0v+HXNbRiwgEyCOxmCGc9wGp0=; b=XIbLZgdd08cmhqyk7yDmGrRvynTKNBN0WoFuvv5LZfoHqCLvdQRyY9wu/9TlKuIzenKvkrZbKrRJtX0nJuoE3elGFvFNdASkgBNClU7NnIdFw9XzYqUFr+STJpAEsIQFWloEqjBwXgn6/+BNTj48YRAG6OppYQUhuYJ9MNzB6Kc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652686831880382.51823250384916; Mon, 16 May 2022 00:40:31 -0700 (PDT) Received: from localhost ([::1]:51164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVLC-0004F1-TP for importer2@patchew.org; Mon, 16 May 2022 03:40:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGN-0000qU-V1 for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:30017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGK-0001sz-27 for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:30 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-369-unjL7LUPMG6T7pkUv8Ky5A-1; Mon, 16 May 2022 03:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D3FB85A5BC; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E2F45703AC; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DD67B21E6935; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oliCzspkR/M43O0GQj0v+HXNbRiwgEyCOxmCGc9wGp0=; b=YGSGlNu8r16sOd8z8bvgbARfyMutuzmRrhJa5Of8ToxiDPKYfUpz3Uro2M1ZCUkA0GFiqG lkt+2DFVV5bhJAsHPl+aoS3C2cOS9hArlMNqmFEu0D5nYm99pKjvgqJwsYUq154i+i5DYz kellrjdtZQSgGs7clUjI8ngVwmW1m34= X-MC-Unique: unjL7LUPMG6T7pkUv8Ky5A-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani Subject: [PULL 06/11] qapi: Drop unnecessary empty lines outside of comments Date: Mon, 16 May 2022 09:35:17 +0200 Message-Id: <20220516073522.3880774-7-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652686833336100001 Content-Type: text/plain; charset="utf-8" From: Andrea Bolognani Signed-off-by: Andrea Bolognani Reviewed-by: Markus Armbruster Message-Id: <20220503073737.84223-6-abologna@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/audio.json | 1 - qapi/block-core.json | 11 ----------- qapi/block.json | 3 --- qapi/char.json | 1 - qapi/control.json | 1 - qapi/crypto.json | 12 ------------ qapi/job.json | 1 - qapi/machine-target.json | 1 - qapi/machine.json | 1 - qapi/misc-target.json | 4 ---- qapi/run-state.json | 1 - qapi/ui.json | 1 - 12 files changed, 38 deletions(-) diff --git a/qapi/audio.json b/qapi/audio.json index 0785e70a50..8099e3d7f1 100644 --- a/qapi/audio.json +++ b/qapi/audio.json @@ -352,7 +352,6 @@ '*out': 'AudiodevPerDirectionOptions', '*path': 'str' } } =20 - ## # @AudioFormat: # diff --git a/qapi/block-core.json b/qapi/block-core.json index 27832a1244..2bce5bb0ae 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -739,7 +739,6 @@ ## { 'command': 'query-block', 'returns': ['BlockInfo'] } =20 - ## # @BlockDeviceTimedStats: # @@ -1512,7 +1511,6 @@ { 'command': 'blockdev-snapshot-sync', 'data': 'BlockdevSnapshotSync' } =20 - ## # @blockdev-snapshot: # @@ -1751,7 +1749,6 @@ { 'command': 'blockdev-backup', 'boxed': true, 'data': 'BlockdevBackup' } =20 - ## # @query-named-block-nodes: # @@ -3067,7 +3064,6 @@ 'base': 'BlockdevOptionsGenericFormat', 'data': { '*key-secret': 'str' } } =20 - ## # @BlockdevOptionsGenericCOWFormat: # @@ -3182,8 +3178,6 @@ 'base': 'BlockdevOptionsGenericCOWFormat', 'data': { '*encrypt': 'BlockdevQcowEncryption' } } =20 - - ## # @BlockdevQcow2EncryptionFormat: # @@ -3357,7 +3351,6 @@ '*user': 'str', '*host-key-check': 'SshHostKeyCheck' } } =20 - ## # @BlkdebugEvent: # @@ -3721,7 +3714,6 @@ '*header-digest': 'IscsiHeaderDigest', '*timeout': 'int' } } =20 - ## # @RbdAuthMode: # @@ -4564,7 +4556,6 @@ { 'enum': 'BlockdevQcow2Version', 'data': [ 'v2', 'v3' ] } =20 - ## # @Qcow2CompressionType: # @@ -4738,7 +4729,6 @@ '*toolsversion': 'str', '*zeroed-grain': 'bool' } } =20 - ## # @BlockdevCreateOptionsSsh: # @@ -4973,7 +4963,6 @@ { 'enum': 'BlockErrorAction', 'data': [ 'ignore', 'report', 'stop' ] } =20 - ## # @BLOCK_IMAGE_CORRUPTED: # diff --git a/qapi/block.json b/qapi/block.json index 5de15c6070..41b73c9934 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -286,7 +286,6 @@ 'data': { 'id': 'str', 'node-name': 'str'} } =20 - ## # @BlockdevChangeReadOnlyMode: # @@ -304,7 +303,6 @@ { 'enum': 'BlockdevChangeReadOnlyMode', 'data': ['retain', 'read-only', 'read-write'] } =20 - ## # @blockdev-change-medium: # @@ -375,7 +373,6 @@ '*force': 'bool', '*read-only-mode': 'BlockdevChangeReadOnlyMode' } } =20 - ## # @DEVICE_TRAY_MOVED: # diff --git a/qapi/char.json b/qapi/char.json index f0fd0d1c9f..8414ef2bc2 100644 --- a/qapi/char.json +++ b/qapi/char.json @@ -329,7 +329,6 @@ 'data': { '*signal': 'bool' }, 'base': 'ChardevCommon' } =20 - ## # @ChardevSpiceChannel: # diff --git a/qapi/control.json b/qapi/control.json index 8c9122ef7a..53461cec05 100644 --- a/qapi/control.json +++ b/qapi/control.json @@ -68,7 +68,6 @@ { 'struct': 'VersionTriple', 'data': {'major': 'int', 'minor': 'int', 'micro': 'int'} } =20 - ## # @VersionInfo: # diff --git a/qapi/crypto.json b/qapi/crypto.json index 21c670eefa..9ec0aca1c6 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -24,7 +24,6 @@ 'prefix': 'QCRYPTO_TLS_CREDS_ENDPOINT', 'data': ['client', 'server']} =20 - ## # @QCryptoSecretFormat: # @@ -39,7 +38,6 @@ 'prefix': 'QCRYPTO_SECRET_FORMAT', 'data': ['raw', 'base64']} =20 - ## # @QCryptoHashAlgorithm: # @@ -59,7 +57,6 @@ 'prefix': 'QCRYPTO_HASH_ALG', 'data': ['md5', 'sha1', 'sha224', 'sha256', 'sha384', 'sha512', 'ripemd1= 60']} =20 - ## # @QCryptoCipherAlgorithm: # @@ -88,7 +85,6 @@ 'serpent-128', 'serpent-192', 'serpent-256', 'twofish-128', 'twofish-192', 'twofish-256']} =20 - ## # @QCryptoCipherMode: # @@ -105,7 +101,6 @@ 'prefix': 'QCRYPTO_CIPHER_MODE', 'data': ['ecb', 'cbc', 'xts', 'ctr']} =20 - ## # @QCryptoIVGenAlgorithm: # @@ -181,7 +176,6 @@ { 'struct': 'QCryptoBlockOptionsLUKS', 'data': { '*key-secret': 'str' }} =20 - ## # @QCryptoBlockCreateOptionsLUKS: # @@ -212,7 +206,6 @@ '*hash-alg': 'QCryptoHashAlgorithm', '*iter-time': 'int'}} =20 - ## # @QCryptoBlockOpenOptions: # @@ -227,7 +220,6 @@ 'data': { 'qcow': 'QCryptoBlockOptionsQCow', 'luks': 'QCryptoBlockOptionsLUKS' } } =20 - ## # @QCryptoBlockCreateOptions: # @@ -242,7 +234,6 @@ 'data': { 'qcow': 'QCryptoBlockOptionsQCow', 'luks': 'QCryptoBlockCreateOptionsLUKS' } } =20 - ## # @QCryptoBlockInfoBase: # @@ -256,7 +247,6 @@ { 'struct': 'QCryptoBlockInfoBase', 'data': { 'format': 'QCryptoBlockFormat' }} =20 - ## # @QCryptoBlockInfoLUKSSlot: # @@ -276,7 +266,6 @@ '*stripes': 'int', 'key-offset': 'int' } } =20 - ## # @QCryptoBlockInfoLUKS: # @@ -330,7 +319,6 @@ { 'enum': 'QCryptoBlockLUKSKeyslotState', 'data': [ 'active', 'inactive' ] } =20 - ## # @QCryptoBlockAmendOptionsLUKS: # diff --git a/qapi/job.json b/qapi/job.json index 1a6ef03451..d5f84e9615 100644 --- a/qapi/job.json +++ b/qapi/job.json @@ -173,7 +173,6 @@ ## { 'command': 'job-cancel', 'data': { 'id': 'str' } } =20 - ## # @job-complete: # diff --git a/qapi/machine-target.json b/qapi/machine-target.json index f5ec4bc172..06b0d2ca61 100644 --- a/qapi/machine-target.json +++ b/qapi/machine-target.json @@ -54,7 +54,6 @@ { 'enum': 'CpuModelExpansionType', 'data': [ 'static', 'full' ] } =20 - ## # @CpuModelCompareResult: # diff --git a/qapi/machine.json b/qapi/machine.json index c8f07c43cd..3fe977e903 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -1365,7 +1365,6 @@ { 'event': 'MEMORY_DEVICE_SIZE_CHANGE', 'data': { '*id': 'str', 'size': 'size', 'qom-path' : 'str'} } =20 - ## # @MEM_UNPLUG_ERROR: # diff --git a/qapi/misc-target.json b/qapi/misc-target.json index ae2c483a68..2fa68a6796 100644 --- a/qapi/misc-target.json +++ b/qapi/misc-target.json @@ -21,7 +21,6 @@ { 'command': 'rtc-reset-reinjection', 'if': 'TARGET_I386' } =20 - ## # @SevState: # @@ -101,7 +100,6 @@ { 'command': 'query-sev', 'returns': 'SevInfo', 'if': 'TARGET_I386' } =20 - ## # @SevLaunchMeasureInfo: # @@ -132,7 +130,6 @@ { 'command': 'query-sev-launch-measure', 'returns': 'SevLaunchMeasureInfo', 'if': 'TARGET_I386' } =20 - ## # @SevCapability: # @@ -304,7 +301,6 @@ { 'command': 'query-gic-capabilities', 'returns': ['GICCapability'], 'if': 'TARGET_ARM' } =20 - ## # @SGXEPCSection: # diff --git a/qapi/run-state.json b/qapi/run-state.json index a5d2db3b91..30a2f5231d 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -597,7 +597,6 @@ 'data': [ 'hypervisor', 'guest' ] } =20 - ## # @MemoryFailureAction: # diff --git a/qapi/ui.json b/qapi/ui.json index 0e903340fc..9f19beea6d 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -128,7 +128,6 @@ # # Since: 7.0 ## - { 'struct': 'ExpirePasswordOptionsVnc', 'data': { '*display': 'str' } } =20 --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652688963; cv=none; d=zohomail.com; s=zohoarc; b=CbUyzhYvmk6udlEBbAxFWxiWNFIPuffUhm0XxHWy64zi7AIaGGtjyzZ7B+TiW1IEXiIU0uN5AuG33hpCXg4qRJn+Ej2Ky18CIjXcf/zxqGim5ENYdaLxp4wtHdhBCWMrCI1y+NdHOMEmx/ew+tX6Vg+VxZz5tI/Z3d7aD51+yrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652688963; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sQMVK8xSVw4Vl1+cgkX/pKVGRlPqHg2Ed7L3UrmKsRk=; b=i50MgQBxSiENM4aFWKVJ1hyZN486lxI/oXpEIkkDbzuaQQFE6OWHvRq8T2tuLzNSGxsedv6YFNrNOhr1a6D/th/pIGiiRPzy+wsKABPIFc5U4j+0ObzdiRhtZhtst5mj3kaPEWTZfrt/u0fJLVcOFLUo5/tDy0JTavqhk7Q7DC4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652688963875219.02488211255456; Mon, 16 May 2022 01:16:03 -0700 (PDT) Received: from localhost ([::1]:55536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVta-0002Yw-43 for importer2@patchew.org; Mon, 16 May 2022 04:16:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGP-0000qu-75 for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:34883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGL-0001tq-L0 for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:32 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-ild496AsNuye_sOLZufg2A-1; Mon, 16 May 2022 03:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5020029AB44E; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0ECED40D1B98; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DF8AB21E6939; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQMVK8xSVw4Vl1+cgkX/pKVGRlPqHg2Ed7L3UrmKsRk=; b=MddHZnIzBJc2+eiOrXrkhRDVcQpZPVB8cfZeQqhYswuorjnkr21+xoOVp0gqvTp3BOP3jd ouZWBSXcw0t+5Nku4ImXMf+5djgtValD9wg/ggmBx6SSFZLo1tAc7+v/XPr+rXSbVw7u2n kFJZFlh72D17MdCZlvKyoai3uRRdzfE= X-MC-Unique: ild496AsNuye_sOLZufg2A-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani Subject: [PULL 07/11] qapi: Drop unnecessary whitespace in comments Date: Mon, 16 May 2022 09:35:18 +0200 Message-Id: <20220516073522.3880774-8-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652688964743100001 Content-Type: text/plain; charset="utf-8" From: Andrea Bolognani The only instances that get changed are those in which the additional whitespace was not (or couldn't possibly be) used for alignment purposes. Signed-off-by: Andrea Bolognani Message-Id: <20220503073737.84223-7-abologna@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/block-core.json | 24 ++++++++++++------------ qapi/block-export.json | 2 +- qapi/block.json | 2 +- qapi/char.json | 2 +- qapi/dump.json | 4 ++-- qapi/machine.json | 8 ++++---- qapi/misc-target.json | 6 +++--- qapi/misc.json | 6 +++--- qapi/run-state.json | 4 ++-- qapi/sockets.json | 2 +- qapi/ui.json | 2 +- 11 files changed, 31 insertions(+), 31 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 2bce5bb0ae..e110af2f1d 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -604,7 +604,7 @@ # @inserted: @BlockDeviceInfo describing the device if media is # present # -# Since: 0.14 +# Since: 0.14 ## { 'struct': 'BlockInfo', 'data': {'device': 'str', '*qdev': 'str', 'type': 'str', 'removable': 'b= ool', @@ -795,9 +795,9 @@ # # Statistics of a virtual block device or a block backing device. # -# @rd_bytes: The number of bytes read by the device. +# @rd_bytes: The number of bytes read by the device. # -# @wr_bytes: The number of bytes written by the device. +# @wr_bytes: The number of bytes written by the device. # # @unmap_bytes: The number of bytes unmapped by the device (Since 4.2) # @@ -970,7 +970,7 @@ # @qdev: The qdev ID, or if no ID is assigned, the QOM path of the block # device. (since 3.0) # -# @stats: A @BlockDeviceStats for the device. +# @stats: A @BlockDeviceStats for the device. # # @driver-specific: Optional driver-specific stats. (Since 4.2) # @@ -1275,7 +1275,7 @@ # # @node-name: graph node name to get the image resized (Since 2.0) # -# @size: new image size in bytes +# @size: new image size in bytes # # Returns: - nothing on success # - If @device is not a valid block device, DeviceNotFound @@ -1960,8 +1960,8 @@ # @job-id: identifier for the newly-created block job. If # omitted, the device name will be used. (Since 2.7) # -# @device: the device name or node-name of a root node whose writes shoul= d be -# mirrored. +# @device: the device name or node-name of a root node whose writes should= be +# mirrored. # # @target: the target of the new image. If the file exists, or if it # is a device, the existing file/device will be used as the new @@ -1981,7 +1981,7 @@ # @mode: whether and how QEMU should create a new image, default is # 'absolute-paths'. # -# @speed: the maximum speed, in bytes per second +# @speed: the maximum speed, in bytes per second # # @sync: what parts of the disk image should be copied to the destination # (all the disk, only the sectors allocated in the topmost image, or @@ -2296,7 +2296,7 @@ # broken Quorum files. By default, @device is replaced, althou= gh # implicitly created filters on it are kept. # -# @speed: the maximum speed, in bytes per second +# @speed: the maximum speed, in bytes per second # # @sync: what parts of the disk image should be copied to the destination # (all the disk, only the sectors allocated in the topmost image, or @@ -4548,8 +4548,8 @@ ## # @BlockdevQcow2Version: # -# @v2: The original QCOW2 format as introduced in qemu 0.10 (version 2) -# @v3: The extended QCOW2 format as introduced in qemu 1.1 (version 3) +# @v2: The original QCOW2 format as introduced in qemu 0.10 (version 2) +# @v3: The extended QCOW2 format as introduced in qemu 1.1 (version 3) # # Since: 2.12 ## @@ -4905,7 +4905,7 @@ # # Options for amending an image format # -# @driver: Block driver of the node to amend. +# @driver: Block driver of the node to amend. # # Since: 5.1 ## diff --git a/qapi/block-export.json b/qapi/block-export.json index 7776248435..0685cb8b9a 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -391,7 +391,7 @@ # block-export-del command, but before the shutdown has # completed) # -# Since: 5.2 +# Since: 5.2 ## { 'struct': 'BlockExportInfo', 'data': { 'id': 'str', diff --git a/qapi/block.json b/qapi/block.json index 41b73c9934..96f557b3bb 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -106,7 +106,7 @@ # Returns: - Nothing on success # - If @device is not a valid block device, DeviceNotFound # -# Notes: Ejecting a device with no media results in success +# Notes: Ejecting a device with no media results in success # # Since: 0.14 # diff --git a/qapi/char.json b/qapi/char.json index 8414ef2bc2..a40fe4b7bd 100644 --- a/qapi/char.json +++ b/qapi/char.json @@ -216,7 +216,7 @@ # # Configuration info for file chardevs. # -# @in: The name of the input file +# @in: The name of the input file # @out: The name of the output file # @append: Open the file in append mode (default false to # truncate) (Since 2.6) diff --git a/qapi/dump.json b/qapi/dump.json index 29441af9d8..90859c5483 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -186,8 +186,8 @@ # # Returns the available formats for dump-guest-memory # -# Returns: A @DumpGuestMemoryCapability object listing available formats = for -# dump-guest-memory +# Returns: A @DumpGuestMemoryCapability object listing available formats f= or +# dump-guest-memory # # Since: 2.0 # diff --git a/qapi/machine.json b/qapi/machine.json index 3fe977e903..1e5bf02480 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -315,9 +315,9 @@ # query-current-machine), wake-up guest from suspend if the guest is # in SUSPENDED state. Return an error otherwise. # -# Since: 1.1 +# Since: 1.1 # -# Returns: nothing. +# Returns: nothing. # # Note: prior to 4.0, this command does nothing in case the guest # isn't suspended. @@ -368,9 +368,9 @@ # Injects a Non-Maskable Interrupt into the default CPU (x86/s390) or all = CPUs (ppc64). # The command fails when the guest doesn't support injecting. # -# Returns: If successful, nothing +# Returns: If successful, nothing # -# Since: 0.14 +# Since: 0.14 # # Note: prior to 2.1, this command was only supported for x86 and s390 VMs # diff --git a/qapi/misc-target.json b/qapi/misc-target.json index 2fa68a6796..4944c0528f 100644 --- a/qapi/misc-target.json +++ b/qapi/misc-target.json @@ -136,9 +136,9 @@ # The struct describes capability for a Secure Encrypted Virtualization # feature. # -# @pdh: Platform Diffie-Hellman key (base64 encoded) +# @pdh: Platform Diffie-Hellman key (base64 encoded) # -# @cert-chain: PDH certificate chain (base64 encoded) +# @cert-chain: PDH certificate chain (base64 encoded) # # @cpu0-id: Unique ID of CPU0 (base64 encoded) (since 7.1) # @@ -201,7 +201,7 @@ # The struct describes attestation report for a Secure Encrypted # Virtualization feature. # -# @data: guest attestation report (base64 encoded) +# @data: guest attestation report (base64 encoded) # # Since: 6.1 ## diff --git a/qapi/misc.json b/qapi/misc.json index f8a9feda30..45344483cd 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -136,7 +136,7 @@ # # Stop all guest VCPU execution. # -# Since: 0.14 +# Since: 0.14 # # Notes: This function will succeed even if the guest is already in the st= opped # state. In "inmigrate" state, it will ensure that the guest @@ -156,9 +156,9 @@ # # Resume guest VCPU execution. # -# Since: 0.14 +# Since: 0.14 # -# Returns: If successful, nothing +# Returns: If successful, nothing # # Notes: This command will succeed if the guest is currently running. It # will also succeed if the guest is in the "inmigrate" state; in diff --git a/qapi/run-state.json b/qapi/run-state.json index 30a2f5231d..6e2162d7b3 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -104,7 +104,7 @@ # # @status: the virtual machine @RunState # -# Since: 0.14 +# Since: 0.14 # # Notes: @singlestep is enabled through the GDB stub ## @@ -118,7 +118,7 @@ # # Returns: @StatusInfo reflecting all VCPUs # -# Since: 0.14 +# Since: 0.14 # # Example: # diff --git a/qapi/sockets.json b/qapi/sockets.json index fccc38584b..b4f84d3334 100644 --- a/qapi/sockets.json +++ b/qapi/sockets.json @@ -189,7 +189,7 @@ # Captures the address of a socket, which could also be a named file # descriptor # -# @type: Transport type +# @type: Transport type # # Since: 2.9 ## diff --git a/qapi/ui.json b/qapi/ui.json index 9f19beea6d..c844237434 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1260,7 +1260,7 @@ # # Curses display options. # -# @charset: Font charset used by guest (default: CP437). +# @charset: Font charset used by guest (default: CP437). # # Since: 4.0 ## --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652688519; cv=none; d=zohomail.com; s=zohoarc; b=hKNCwnIaCfOh1C+6LgY5kD13v6UQNnfQcL0Q5KUlcrzJEce9M9mlTGfepQThuheFPe0kl28sUBvRA9QnnPZARUhwL6/heMbHE5JfH05it6zVTc9nWxQhOFsbYwlb3Cg1XEQVyZSj1e1h5GZmRYsCt2QlB0Tgkjh5C9D40kFo1iE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652688519; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=88WZoYleZt78cyWHcWlBnun10sJcL+SURQ+YQ+Uh1cw=; b=XJ9Ou368YWoi5oy1helVbmrt7EqdfoXqIG6UqdTS3TKvUmNHG6R/XwqsdZYCrehfceVaU2Jk7YzoqWlXQy4KRJW7JCb91RZ0C/eR6pC55WY0w4kh2lQFH0Y3Us1wcPHOZkfIFE+j4L0Xare0JuwXuu46c+JKIdlW+KJbTargrcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652688519819608.4985598507637; Mon, 16 May 2022 01:08:39 -0700 (PDT) Received: from localhost ([::1]:50510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVmQ-0007IT-9H for importer2@patchew.org; Mon, 16 May 2022 04:08:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGN-0000qS-Ue for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGJ-0001s2-QO for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:30 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-f95bxNEJP3WrQNm_WqibNg-1; Mon, 16 May 2022 03:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A6651815CF7; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E3DB155F6B2; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E1B3421E693E; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=88WZoYleZt78cyWHcWlBnun10sJcL+SURQ+YQ+Uh1cw=; b=CBypNZN6moaFETUwJkuYgtYMsz9TUDTm87PF+6CXD4uq68EPRoCl8TzxJpR8uq4FEOFRVB ixI3YWuGjuyQijV9fO6qCofvzKrSy4gjAikzADKa3++YN07GSVYEmggA8RE3k59KueYtQO USSs41l/BRCvQ3g6sZU4jAlf6hL4R60= X-MC-Unique: f95bxNEJP3WrQNm_WqibNg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Andrea Bolognani , Eric Blake Subject: [PULL 08/11] qapi: Stop using whitespace for alignment in comments Date: Mon, 16 May 2022 09:35:19 +0200 Message-Id: <20220516073522.3880774-9-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652688520773100001 Content-Type: text/plain; charset="utf-8" From: Andrea Bolognani Perfectly aligned things look pretty, but keeping them that way as the schema evolves requires churn, and in some cases newly-added lines are not aligned properly. Overall, trying to align things is just not worth the trouble. Signed-off-by: Andrea Bolognani Message-Id: <20220503073737.84223-8-abologna@redhat.com> Message-Id: <20220503073737.84223-9-abologna@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster [Two patches squashed together] Signed-off-by: Markus Armbruster --- qapi/block-core.json | 53 ++++++++++++++++++++++---------------------- qapi/block.json | 6 ++--- qapi/char.json | 6 ++--- qapi/control.json | 10 ++++----- qapi/crypto.json | 42 +++++++++++++++++------------------ qapi/migration.json | 8 +++---- qapi/sockets.json | 4 ++-- qapi/ui.json | 17 +++++++------- 8 files changed, 72 insertions(+), 74 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e110af2f1d..f0383c7925 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -337,9 +337,9 @@ # # Cache mode information for a block device # -# @writeback: true if writeback mode is enabled -# @direct: true if the host page cache is bypassed (O_DIRECT) -# @no-flush: true if flush requests are ignored for the device +# @writeback: true if writeback mode is enabled +# @direct: true if the host page cache is bypassed (O_DIRECT) +# @no-flush: true if flush requests are ignored for the device # # Since: 2.3 ## @@ -3333,15 +3333,14 @@ ## # @BlockdevOptionsSsh: # -# @server: host address +# @server: host address # -# @path: path to the image on the host +# @path: path to the image on the host # -# @user: user as which to connect, defaults to current -# local user name +# @user: user as which to connect, defaults to current local user name # -# @host-key-check: Defines how and what to check the host key against -# (default: known_hosts) +# @host-key-check: Defines how and what to check the host key against +# (default: known_hosts) # # Since: 2.9 ## @@ -4662,18 +4661,18 @@ # # Subformat options for VMDK images # -# @monolithicSparse: Single file image with sparse cluster allocation +# @monolithicSparse: Single file image with sparse cluster allocation # -# @monolithicFlat: Single flat data image and a descriptor file +# @monolithicFlat: Single flat data image and a descriptor file # # @twoGbMaxExtentSparse: Data is split into 2GB (per virtual LBA) sparse e= xtent # files, in addition to a descriptor file # -# @twoGbMaxExtentFlat: Data is split into 2GB (per virtual LBA) flat ext= ent -# files, in addition to a descriptor file +# @twoGbMaxExtentFlat: Data is split into 2GB (per virtual LBA) flat extent +# files, in addition to a descriptor file # -# @streamOptimized: Single file image sparse cluster allocation, opti= mized -# for streaming over network. +# @streamOptimized: Single file image sparse cluster allocation, optimized +# for streaming over network. # # Since: 4.0 ## @@ -4764,7 +4763,7 @@ # @BlockdevVhdxSubformat: # # @dynamic: Growing image file -# @fixed: Preallocated fixed-size image file +# @fixed: Preallocated fixed-size image file # # Since: 2.12 ## @@ -4802,7 +4801,7 @@ # @BlockdevVpcSubformat: # # @dynamic: Growing image file -# @fixed: Preallocated fixed-size image file +# @fixed: Preallocated fixed-size image file # # Since: 2.12 ## @@ -4865,9 +4864,9 @@ # Starts a job to create an image format on a given node. The job is # automatically finalized, but a manual job-dismiss is required. # -# @job-id: Identifier for the newly created job. +# @job-id: Identifier for the newly created job. # -# @options: Options for the image creation. +# @options: Options for the image creation. # # Since: 3.0 ## @@ -4923,17 +4922,17 @@ # Starts a job to amend format specific options of an existing open block = device # The job is automatically finalized, but a manual job-dismiss is required. # -# @job-id: Identifier for the newly created job. +# @job-id: Identifier for the newly created job. # -# @node-name: Name of the block node to work on +# @node-name: Name of the block node to work on # -# @options: Options (driver specific) +# @options: Options (driver specific) # -# @force: Allow unsafe operations, format specific -# For luks that allows erase of the last active keyslot -# (permanent loss of data), -# and replacement of an active keyslot -# (possible loss of data if IO error happens) +# @force: Allow unsafe operations, format specific +# For luks that allows erase of the last active keyslot +# (permanent loss of data), +# and replacement of an active keyslot +# (possible loss of data if IO error happens) # # Features: # @unstable: This command is experimental. diff --git a/qapi/block.json b/qapi/block.json index 96f557b3bb..19326641ac 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -50,9 +50,9 @@ # # Type of Floppy drive to be emulated by the Floppy Disk Controller. # -# @144: 1.44MB 3.5" drive -# @288: 2.88MB 3.5" drive -# @120: 1.2MB 5.25" drive +# @144: 1.44MB 3.5" drive +# @288: 2.88MB 3.5" drive +# @120: 1.2MB 5.25" drive # @none: No drive connected # @auto: Automatically determined by inserted media at boot # diff --git a/qapi/char.json b/qapi/char.json index a40fe4b7bd..923dc5056d 100644 --- a/qapi/char.json +++ b/qapi/char.json @@ -376,10 +376,10 @@ # # Configuration info for virtual console chardevs. # -# @width: console width, in pixels +# @width: console width, in pixels # @height: console height, in pixels -# @cols: console width, in chars -# @rows: console height, in chars +# @cols: console width, in chars +# @rows: console height, in chars # # Since: 1.5 ## diff --git a/qapi/control.json b/qapi/control.json index 53461cec05..afca2043af 100644 --- a/qapi/control.json +++ b/qapi/control.json @@ -192,14 +192,14 @@ # # Options to be used for adding a new monitor. # -# @id: Name of the monitor +# @id: Name of the monitor # -# @mode: Selects the monitor mode (default: readline in the system -# emulator, control in qemu-storage-daemon) +# @mode: Selects the monitor mode (default: readline in the system +# emulator, control in qemu-storage-daemon) # -# @pretty: Enables pretty printing (QMP only) +# @pretty: Enables pretty printing (QMP only) # -# @chardev: Name of a character device to expose the monitor on +# @chardev: Name of a character device to expose the monitor on # # Since: 5.0 ## diff --git a/qapi/crypto.json b/qapi/crypto.json index 9ec0aca1c6..15c24f0078 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -311,8 +311,8 @@ # # Defines state of keyslots that are affected by the update # -# @active: The slots contain the given password and marked as active -# @inactive: The slots are erased (contain garbage) and marked as inactive +# @active: The slots contain the given password and marked as active +# @inactive: The slots are erased (contain garbage) and marked as inactive # # Since: 5.1 ## @@ -327,30 +327,30 @@ # # @state: the desired state of the keyslots # -# @new-secret: The ID of a QCryptoSecret object providing the password = to be -# written into added active keyslots +# @new-secret: The ID of a QCryptoSecret object providing the password to = be +# written into added active keyslots # -# @old-secret: Optional (for deactivation only) -# If given will deactivate all keyslots that -# match password located in QCryptoSecret with this ID +# @old-secret: Optional (for deactivation only) +# If given will deactivate all keyslots that +# match password located in QCryptoSecret with this ID # -# @iter-time: Optional (for activation only) -# Number of milliseconds to spend in -# PBKDF passphrase processing for the newly activated keys= lot. -# Currently defaults to 2000. +# @iter-time: Optional (for activation only) +# Number of milliseconds to spend in +# PBKDF passphrase processing for the newly activated keyslot. +# Currently defaults to 2000. # -# @keyslot: Optional. ID of the keyslot to activate/deactivate. -# For keyslot activation, keyslot should not be active alr= eady -# (this is unsafe to update an active keyslot), -# but possible if 'force' parameter is given. -# If keyslot is not given, first free keyslot will be writ= ten. +# @keyslot: Optional. ID of the keyslot to activate/deactivate. +# For keyslot activation, keyslot should not be active already +# (this is unsafe to update an active keyslot), +# but possible if 'force' parameter is given. +# If keyslot is not given, first free keyslot will be written. # -# For keyslot deactivation, this parameter specifies the e= xact -# keyslot to deactivate +# For keyslot deactivation, this parameter specifies the exact +# keyslot to deactivate # -# @secret: Optional. The ID of a QCryptoSecret object providing the -# password to use to retrieve current master key. -# Defaults to the same secret that was used to open the im= age +# @secret: Optional. The ID of a QCryptoSecret object providing the +# password to use to retrieve current master key. +# Defaults to the same secret that was used to open the image # # Since: 5.1 ## diff --git a/qapi/migration.json b/qapi/migration.json index dd4dde6361..1ff4d7eaff 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1191,10 +1191,10 @@ # ask the client to automatically reconnect using the new parameters # once migration finished successfully. Only implemented for SPICE. # -# @protocol: must be "spice" -# @hostname: migration target hostname -# @port: spice tcp port for plaintext channels -# @tls-port: spice tcp port for tls-secured channels +# @protocol: must be "spice" +# @hostname: migration target hostname +# @port: spice tcp port for plaintext channels +# @tls-port: spice tcp port for tls-secured channels # @cert-subject: server certificate subject # # Since: 0.14 diff --git a/qapi/sockets.json b/qapi/sockets.json index b4f84d3334..bad74e34d3 100644 --- a/qapi/sockets.json +++ b/qapi/sockets.json @@ -167,9 +167,9 @@ # # Available SocketAddress types # -# @inet: Internet address +# @inet: Internet address # -# @unix: Unix domain socket +# @unix: Unix domain socket # # @vsock: VMCI address # diff --git a/qapi/ui.json b/qapi/ui.json index c844237434..11a827d10f 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1018,8 +1018,8 @@ # # Keyboard input event. # -# @key: Which key this event is for. -# @down: True for key-down and false for key-up events. +# @key: Which key this event is for. +# @down: True for key-down and false for key-up events. # # Since: 2.0 ## @@ -1033,7 +1033,7 @@ # Pointer button input event. # # @button: Which button this event is for. -# @down: True for key-down and false for key-up events. +# @down: True for key-down and false for key-up events. # # Since: 2.0 ## @@ -1353,12 +1353,11 @@ # # Display (user interface) options. # -# @type: Which DisplayType qemu should use. -# @full-screen: Start user interface in fullscreen mode (default: off). -# @window-close: Allow to quit qemu with window close button (default: on= ). -# @show-cursor: Force showing the mouse cursor (default: off). -# (since: 5.0) -# @gl: Enable OpenGL support (default: off). +# @type: Which DisplayType qemu should use. +# @full-screen: Start user interface in fullscreen mode (default: off). +# @window-close: Allow to quit qemu with window close button (default: on). +# @show-cursor: Force showing the mouse cursor (default: off). (since: 5.0) +# @gl: Enable OpenGL support (default: off). # # Since: 2.12 ## --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652687518; cv=none; d=zohomail.com; s=zohoarc; b=Jiqsk1DdYuRb3O+pxoJhBefhkH4H2JsnFLKb0+EThutAntim/2h7olx8KEEkwF7tCEdyfifgRLF0T1BgcCVZhX/WACnbeRdmgvl1bQX7ENk0paIpaZJz09GUbfdN1H+KE4BvksQXXyDUQJJ9PUer/6e69KxpUZYbuhBEjcM1+14= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652687518; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=V6odkDmNEPMpTBi89+VhNwNVeI9JFESO8XSYrY3k9i4=; b=A8pyqcG38nMe5m5lbvQfd+kFtbsPhqptHEk/U494e9VHOhJ/kyoOnQGVO+i5kgZQkJd4+/Vjq0BfRnK/HJO8k6Crn/EKpjXyNEhjsUsyoOD1gMgYvCFSxJSrDxy9VG16fuHpBLh/xxaX/D5UtGjqjWLOhItazCuSruk0KixVWt8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652687518696734.4089397967484; Mon, 16 May 2022 00:51:58 -0700 (PDT) Received: from localhost ([::1]:37742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVWG-0006F4-9p for importer2@patchew.org; Mon, 16 May 2022 03:51:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGN-0000qV-VO for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:41682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGJ-0001rv-Qw for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:29 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-EjNiLowPPWWudo7nz5xfLA-1; Mon, 16 May 2022 03:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32C0F1D9F882; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10CC57AE4; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E3AE521E68BF; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V6odkDmNEPMpTBi89+VhNwNVeI9JFESO8XSYrY3k9i4=; b=SjjAZ71kekvclaEHS4OWIWFwUcfKX2MinO2yoOAmb3yhfC03SV2PBpj49JCQr1o7dRZNIf IecRDvm8hIsBQoP8DGNM1jmWIyYCDQEUU8L7Y8FSN1NjOZ8ijxhdbkWoHupJrc3jhMpQU/ QmRv/z8jG9PVjoIktHCylSi9oZ851Z0= X-MC-Unique: EjNiLowPPWWudo7nz5xfLA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PULL 09/11] qapi/expr: Enforce feature naming rules again Date: Mon, 16 May 2022 09:35:20 +0200 Message-Id: <20220516073522.3880774-10-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652687519493100001 Content-Type: text/plain; charset="utf-8" Commit e42648dccd "qapi/expr.py: Remove single-letter variable" accidentally removed the check for "only lower case letters and hyphens". Restore it. Fixes: e42648dccdd1defe8f35f247966cd7283f865cd6 Signed-off-by: Markus Armbruster Message-Id: <20220510061645.3209195-2-armbru@redhat.com> --- scripts/qapi/expr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 48578e1698..5a1782b57e 100644 --- a/scripts/qapi/expr.py +++ b/scripts/qapi/expr.py @@ -443,7 +443,7 @@ def check_features(features: Optional[object], check_keys(feat, info, source, ['name'], ['if']) check_name_is_str(feat['name'], info, source) source =3D "%s '%s'" % (source, feat['name']) - check_name_str(feat['name'], info, source) + check_name_lower(feat['name'], info, source) check_if(feat, info, source) =20 =20 --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652687392; cv=none; d=zohomail.com; s=zohoarc; b=Z6CjDm1A7oduCjBWL9ZxXZOj2EuiS53YyTXyoz+4zeDgLzZGDzULq7XtnagYT67d2FSoVha3u8DLE1ff/e1Y29cFcYG+JPCUKyW798NyAbuil/OJdt9inx/9902rncYerWpiNz9dzwRJG84jW19r+WgpCnZcZz3P4zT6oPOBIYo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652687392; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3vaLvwMs0vBVK47xxIxNAhXjADJ0IamkqSblZaGt3cE=; b=CteMOaa1HyCN6plXMRE+MR0uNaabCHY9SYjkHHkuv6lThErrU6PDXqaF6lP3+TdHt+zoEJFdcGZuo633yBX255cNHcJim+RB/PvSTQBRWOFTG118O/kUB7gTURSikf4HBh5qpxFMZvlDb9EE+xgnvnTYAPthlfjeCYWt2UEF8XY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652687392462948.659971340354; Mon, 16 May 2022 00:49:52 -0700 (PDT) Received: from localhost ([::1]:34946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVUF-0004Jo-8Z for importer2@patchew.org; Mon, 16 May 2022 03:49:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGO-0000qb-Be for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGL-0001tn-Hp for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:32 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-EsfvTJQKPRCllfe3Qw-2yQ-1; Mon, 16 May 2022 03:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 33904805B25; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12EEF401474; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E571721E6837; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3vaLvwMs0vBVK47xxIxNAhXjADJ0IamkqSblZaGt3cE=; b=YvwdXhk8SO1PKjsLkhz8HXAb3nQVKliJnvPX3yBhxrIlu5cudQZyUc0q+P8J+yWkh4ZxjM XRamPZQToOLtiRKpVz4giLF/iRGgVDGYmSlwQgyaCvu9hOyzbIXoEeLZrtEsJqqa7VTYcg BkDMjGmuaZQ7tmZmpkeIOyjQfRLOeu8= X-MC-Unique: EsfvTJQKPRCllfe3Qw-2yQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PULL 10/11] docs/devel/qapi-code-gen: Belatedly document feature naming rules Date: Mon, 16 May 2022 09:35:21 +0200 Message-Id: <20220516073522.3880774-11-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652687394918100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Message-Id: <20220510061645.3209195-3-armbru@redhat.com> --- docs/devel/qapi-code-gen.rst | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index 7b968433a6..cd9b544376 100644 --- a/docs/devel/qapi-code-gen.rst +++ b/docs/devel/qapi-code-gen.rst @@ -739,10 +739,11 @@ Type names ending with ``Kind`` or ``List`` are reser= ved for the generator, which uses them for implicit union enums and array types, respectively. =20 -Command names, and member names within a type, should be all lower -case with words separated by a hyphen. However, some existing older -commands and complex types use underscore; when extending them, -consistency is preferred over blindly avoiding underscore. +Command names, member names within a type, and feature names should be +all lower case with words separated by a hyphen. However, some +existing older commands and complex types use underscore; when +extending them, consistency is preferred over blindly avoiding +underscore. =20 Event names should be ALL_CAPS with words separated by underscore. =20 --=20 2.35.3 From nobody Fri May 3 14:04:48 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652687190; cv=none; d=zohomail.com; s=zohoarc; b=DOE4FMOmigwP5uvImTO/k15oVHxLa5qhiV7tw9jTBiAQiG0Po+pLJeyJygfk8ixBWiL2VC6mPmTAQVmaSW7PCG9yI3yQvi7LbX9UJXc6DxSnAIVamIkKi8GHIn6/tyCPj2ZbZU0Pf2407RwxqAfjIDPygJwOoYNh6x2zM1UuIO4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652687190; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nMwDOPmK3qbaJL6p+jiSQ0tInHhkbJ3pqtC3JF/qCXI=; b=RWUuEVYS6PpWZ4gFtDwHCCO6qDTj0wys4dY9ioVCeGbHvZ+fbkU2z24/4lTABmkj7pwfu6lIwXWAua8c08D/V1YfdyOyX43HOqrdqtQFoVA2WmtF+r0ONmC1eMjqZQjLeE+c8twJXKgHar32dFE/SpUzgaPfinuZxZfY/iHJluY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1652687190257137.53605851889756; Mon, 16 May 2022 00:46:30 -0700 (PDT) Received: from localhost ([::1]:58916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqVQy-0001C4-Fm for importer2@patchew.org; Mon, 16 May 2022 03:46:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGO-0000qW-09 for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqVGK-0001tO-FQ for qemu-devel@nongnu.org; Mon, 16 May 2022 03:35:31 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-336-DV7EFvXoOaaha73z2e_sng-1; Mon, 16 May 2022 03:35:25 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A6A5811E75; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2992E5703BE; Mon, 16 May 2022 07:35:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E752121E6761; Mon, 16 May 2022 09:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652686527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nMwDOPmK3qbaJL6p+jiSQ0tInHhkbJ3pqtC3JF/qCXI=; b=H9eTCRETNEHRnYI5qKfgzzy4upU/oE1g/2/c5fhxKUkNWZqMZb80B9od0PW5ugxoISpd4w /ds0DlSSqQQuLRRCn/PUq/gU16NJCdUwzr7b4TpdruzUyMu99iEGFDC9GvX0L2aVWwI/Ig 5JwaAxSK+zWrhXq8MCDZ9//AgTytxnE= X-MC-Unique: DV7EFvXoOaaha73z2e_sng-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PULL 11/11] qapi/pragma: Tidy up comments Date: Mon, 16 May 2022 09:35:22 +0200 Message-Id: <20220516073522.3880774-12-armbru@redhat.com> In-Reply-To: <20220516073522.3880774-1-armbru@redhat.com> References: <20220516073522.3880774-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652687191815100001 Content-Type: text/plain; charset="utf-8" Commit 05ebf841ef "qapi: Enforce command naming rules" inserted new code between a comment and the code it applies to. Move the comment back to its code, and add one for the new code. Signed-off-by: Markus Armbruster Message-Id: <20220510081433.3289762-1-armbru@redhat.com> --- qapi/pragma.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/pragma.json b/qapi/pragma.json index e6a021c19c..7f810b0e97 100644 --- a/qapi/pragma.json +++ b/qapi/pragma.json @@ -6,7 +6,7 @@ # Whitelists to permit QAPI rule violations; think twice before you # add to them! { 'pragma': { - # Commands allowed to return a non-dictionary: + # Command names containing '_' 'command-name-exceptions': [ 'add_client', 'block_resize', @@ -24,6 +24,7 @@ 'system_powerdown', 'system_reset', 'system_wakeup' ], + # Commands allowed to return a non-dictionary 'command-returns-exceptions': [ 'human-monitor-command', 'qom-get', --=20 2.35.3