[PATCH v2 00/10] Random cleanup patches

Bernhard Beschow posted 10 patches 1 month ago
accel/tcg/cpu-exec.c              |  4 ++--
accel/tcg/translate-all.c         |  5 -----
docs/devel/submitting-a-patch.rst |  6 +++---
hw/audio/cs4231a.c                |  8 ++++----
hw/i386/pc.c                      | 17 +++++++++++++----
hw/net/fsl_etsec/etsec.c          | 23 -----------------------
hw/net/fsl_etsec/etsec.h          |  7 -------
hw/ppc/e500.c                     |  1 -
hw/sparc64/sun4u.c                |  2 +-
include/exec/cpu-all.h            |  3 ---
include/hw/i386/pc.h              | 14 --------------
11 files changed, 23 insertions(+), 67 deletions(-)
[PATCH v2 00/10] Random cleanup patches
Posted by Bernhard Beschow 1 month ago
v2:
* Omit removal of isa_connect_gpio_out() (Mark)

v1:
This patch series contains random cleanups that I made while studying the code.

Bernhard Beschow (10):
  hw: Reuse TYPE_I8042 define
  hw/audio/cs4231a: Const'ify global tables
  hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro
  hw/i386/pc: Unexport functions used only internally
  hw/i386/pc: Remove orphan declarations
  hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE
  hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()
  accel/tcg/cpu-exec: Unexport dump_drift_info()
  accel/tcg: Inline dump_opcount_info() and remove it
  docs/devel: Fix link to developer mailing lists

 accel/tcg/cpu-exec.c              |  4 ++--
 accel/tcg/translate-all.c         |  5 -----
 docs/devel/submitting-a-patch.rst |  6 +++---
 hw/audio/cs4231a.c                |  8 ++++----
 hw/i386/pc.c                      | 17 +++++++++++++----
 hw/net/fsl_etsec/etsec.c          | 23 -----------------------
 hw/net/fsl_etsec/etsec.h          |  7 -------
 hw/ppc/e500.c                     |  1 -
 hw/sparc64/sun4u.c                |  2 +-
 include/exec/cpu-all.h            |  3 ---
 include/hw/i386/pc.h              | 14 --------------
 11 files changed, 23 insertions(+), 67 deletions(-)

-- 
2.36.1
Re: [PATCH v2 00/10] Random cleanup patches
Posted by Mark Cave-Ayland 1 month ago
On 20/05/2022 19:00, Bernhard Beschow wrote:

> v2:
> * Omit removal of isa_connect_gpio_out() (Mark)
> 
> v1:
> This patch series contains random cleanups that I made while studying the code.
> 
> Bernhard Beschow (10):
>    hw: Reuse TYPE_I8042 define
>    hw/audio/cs4231a: Const'ify global tables
>    hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro
>    hw/i386/pc: Unexport functions used only internally
>    hw/i386/pc: Remove orphan declarations
>    hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE
>    hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()
>    accel/tcg/cpu-exec: Unexport dump_drift_info()
>    accel/tcg: Inline dump_opcount_info() and remove it
>    docs/devel: Fix link to developer mailing lists
> 
>   accel/tcg/cpu-exec.c              |  4 ++--
>   accel/tcg/translate-all.c         |  5 -----
>   docs/devel/submitting-a-patch.rst |  6 +++---
>   hw/audio/cs4231a.c                |  8 ++++----
>   hw/i386/pc.c                      | 17 +++++++++++++----
>   hw/net/fsl_etsec/etsec.c          | 23 -----------------------
>   hw/net/fsl_etsec/etsec.h          |  7 -------
>   hw/ppc/e500.c                     |  1 -
>   hw/sparc64/sun4u.c                |  2 +-
>   include/exec/cpu-all.h            |  3 ---
>   include/hw/i386/pc.h              | 14 --------------
>   11 files changed, 23 insertions(+), 67 deletions(-)

In general these changes look okay, so I'd be fine to give an:

Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

for those I haven't already given a Reviewed-by tag for.

Laurent, are you happy to take these patches with their current tags via 
qemu-trivial? Or would you prefer an extra set of eyes on the two accel/tcg ones first?


ATB,

Mark.
Re: [PATCH v2 00/10] Random cleanup patches
Posted by Bernhard Beschow 3 weeks, 1 day ago
On Sat, May 21, 2022 at 11:55 AM Mark Cave-Ayland <
mark.cave-ayland@ilande.co.uk> wrote:

> On 20/05/2022 19:00, Bernhard Beschow wrote:
>
> > v2:
> > * Omit removal of isa_connect_gpio_out() (Mark)
> >
> > v1:
> > This patch series contains random cleanups that I made while studying
> the code.
> >
> > Bernhard Beschow (10):
> >    hw: Reuse TYPE_I8042 define
> >    hw/audio/cs4231a: Const'ify global tables
> >    hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro
> >    hw/i386/pc: Unexport functions used only internally
> >    hw/i386/pc: Remove orphan declarations
> >    hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE
> >    hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()
> >    accel/tcg/cpu-exec: Unexport dump_drift_info()
> >    accel/tcg: Inline dump_opcount_info() and remove it
> >    docs/devel: Fix link to developer mailing lists
> >
> >   accel/tcg/cpu-exec.c              |  4 ++--
> >   accel/tcg/translate-all.c         |  5 -----
> >   docs/devel/submitting-a-patch.rst |  6 +++---
> >   hw/audio/cs4231a.c                |  8 ++++----
> >   hw/i386/pc.c                      | 17 +++++++++++++----
> >   hw/net/fsl_etsec/etsec.c          | 23 -----------------------
> >   hw/net/fsl_etsec/etsec.h          |  7 -------
> >   hw/ppc/e500.c                     |  1 -
> >   hw/sparc64/sun4u.c                |  2 +-
> >   include/exec/cpu-all.h            |  3 ---
> >   include/hw/i386/pc.h              | 14 --------------
> >   11 files changed, 23 insertions(+), 67 deletions(-)
>
> In general these changes look okay, so I'd be fine to give an:
>
> Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>
> for those I haven't already given a Reviewed-by tag for.
>
> Laurent, are you happy to take these patches with their current tags via
> qemu-trivial? Or would you prefer an extra set of eyes on the two
> accel/tcg ones first?
>

Ping


> ATB,
>
> Mark.
>
Re: [PATCH v2 00/10] Random cleanup patches
Posted by Daniel Henrique Barboza 1 month ago

On 5/21/22 06:55, Mark Cave-Ayland wrote:
> On 20/05/2022 19:00, Bernhard Beschow wrote:
> 
>> v2:
>> * Omit removal of isa_connect_gpio_out() (Mark)
>>
>> v1:
>> This patch series contains random cleanups that I made while studying the code.
>>
>> Bernhard Beschow (10):
>>    hw: Reuse TYPE_I8042 define
>>    hw/audio/cs4231a: Const'ify global tables
>>    hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro
>>    hw/i386/pc: Unexport functions used only internally
>>    hw/i386/pc: Remove orphan declarations
>>    hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE
>>    hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()
>>    accel/tcg/cpu-exec: Unexport dump_drift_info()
>>    accel/tcg: Inline dump_opcount_info() and remove it
>>    docs/devel: Fix link to developer mailing lists
>>
>>   accel/tcg/cpu-exec.c              |  4 ++--
>>   accel/tcg/translate-all.c         |  5 -----
>>   docs/devel/submitting-a-patch.rst |  6 +++---
>>   hw/audio/cs4231a.c                |  8 ++++----
>>   hw/i386/pc.c                      | 17 +++++++++++++----
>>   hw/net/fsl_etsec/etsec.c          | 23 -----------------------
>>   hw/net/fsl_etsec/etsec.h          |  7 -------
>>   hw/ppc/e500.c                     |  1 -
>>   hw/sparc64/sun4u.c                |  2 +-
>>   include/exec/cpu-all.h            |  3 ---
>>   include/hw/i386/pc.h              | 14 --------------
>>   11 files changed, 23 insertions(+), 67 deletions(-)
> 
> In general these changes look okay, so I'd be fine to give an:
> 
> Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> for those I haven't already given a Reviewed-by tag for.
> 
> Laurent, are you happy to take these patches with their current tags via qemu-trivial? Or would you prefer an extra set of eyes on the two accel/tcg ones first?


BTW I'll send a PR later this week and I was about to queue patch 06
(hw/ppc/e500 change) via the ppc tree. Let me know if you want to queue
the whole series via qemu-trivial instead.


Thanks,


Daniel



> 
> 
> ATB,
> 
> Mark.
>