[PATCH v3 00/49] semihosting cleanup

Richard Henderson posted 49 patches 1 month ago
configs/targets/aarch64-linux-user.mak        |    1 +
configs/targets/aarch64_be-linux-user.mak     |    1 +
configs/targets/arm-linux-user.mak            |    1 +
configs/targets/armeb-linux-user.mak          |    1 +
configs/targets/riscv32-linux-user.mak        |    1 +
configs/targets/riscv64-linux-user.mak        |    1 +
include/exec/gdbstub.h                        |   67 +-
include/exec/softmmu-semi.h                   |  101 --
.../semihosting}/common-semi.h                |    2 +-
include/semihosting/console.h                 |   71 +-
include/semihosting/guestfd.h                 |   91 ++
include/semihosting/semihost.h                |   14 +-
include/semihosting/softmmu-uaccess.h         |   59 +
include/semihosting/syscalls.h                |   75 ++
target/arm/common-semi-target.h               |   62 +
target/riscv/common-semi-target.h             |   50 +
gdbstub.c                                     |    7 +-
linux-user/aarch64/cpu_loop.c                 |    2 +-
linux-user/arm/cpu_loop.c                     |    2 +-
linux-user/main.c                             |    9 +
linux-user/riscv/cpu_loop.c                   |    2 +-
linux-user/semihost.c                         |   48 +-
semihosting/arm-compat-semi.c                 |  984 ++++------------
semihosting/config.c                          |   17 +-
semihosting/console.c                         |  153 +--
semihosting/guestfd.c                         |  160 +++
semihosting/syscalls.c                        | 1008 +++++++++++++++++
semihosting/uaccess.c                         |   91 ++
softmmu/vl.c                                  |    3 +-
stubs/semihost.c                              |    6 +-
target/arm/helper.c                           |    4 +-
target/arm/m_helper.c                         |    2 +-
target/m68k/m68k-semi.c                       |   50 +-
target/mips/tcg/sysemu/mips-semi.c            |    2 +-
target/nios2/nios2-semi.c                     |   48 +-
target/riscv/cpu_helper.c                     |    2 +-
semihosting/meson.build                       |    6 +
37 files changed, 2055 insertions(+), 1149 deletions(-)
delete mode 100644 include/exec/softmmu-semi.h
rename {semihosting => include/semihosting}/common-semi.h (96%)
create mode 100644 include/semihosting/guestfd.h
create mode 100644 include/semihosting/softmmu-uaccess.h
create mode 100644 include/semihosting/syscalls.h
create mode 100644 target/arm/common-semi-target.h
create mode 100644 target/riscv/common-semi-target.h
create mode 100644 semihosting/guestfd.c
create mode 100644 semihosting/syscalls.c
create mode 100644 semihosting/uaccess.c
[PATCH v3 00/49] semihosting cleanup
Posted by Richard Henderson 1 month ago
Changes for v3:
  * Split the patch set -- only include arm-compat-semi.c changes here.
  * Fix softmmu_target_strlen vs mmio (pmm).
  * Add kerneldoc comments for guestfd.h.


r~


Richard Henderson (49):
  semihosting: Move exec/softmmu-semi.h to semihosting/softmmu-uaccess.h
  semihosting: Return failure from softmmu-uaccess.h functions
  semihosting: Improve condition for config.c and console.c
  semihosting: Move softmmu-uaccess.h functions out of line
  semihosting: Add target_strlen for softmmu-uaccess.h
  semihosting: Simplify softmmu_lock_user_string
  semihosting: Split out guestfd.c
  semihosting: Inline set_swi_errno into common_semi_cb
  semihosting: Adjust error checking in common_semi_cb
  semihosting: Clean up common_semi_flen_cb
  semihosting: Clean up common_semi_open_cb
  semihosting: Return void from do_common_semihosting
  semihosting: Move common-semi.h to include/semihosting/
  include/exec: Move gdb open flags to gdbstub.h
  include/exec: Move gdb_stat and gdb_timeval to gdbstub.h
  include/exec: Define errno values in gdbstub.h
  semihosting: Use struct gdb_stat in common_semi_flen_cb
  semihosting: Split is_64bit_semihosting per target
  semihosting: Split common_semi_flen_buf per target
  semihosting: Split out common_semi_has_synccache
  semihosting: Use env more often in do_common_semihosting
  semihosting: Move GET_ARG/SET_ARG earlier in the file
  semihosting: Split out semihost_sys_open
  semihosting: Split out semihost_sys_close
  semihosting: Split out semihost_sys_read
  semihosting: Split out semihost_sys_write
  semihosting: Bound length for semihost_sys_{read,write}
  semihosting: Split out semihost_sys_lseek
  semihosting: Split out semihost_sys_isatty
  semihosting: Split out semihost_sys_flen
  semihosting: Split out semihost_sys_remove
  semihosting: Split out semihost_sys_rename
  semihosting: Split out semihost_sys_system
  semihosting: Create semihost_sys_{stat,fstat}
  semihosting: Create semihost_sys_gettimeofday
  gdbstub: Widen gdb_syscall_complete_cb return value
  semihosting: Fix docs comment for qemu_semihosting_console_inc
  semihosting: Pass CPUState to qemu_semihosting_console_inc
  semihosting: Expand qemu_semihosting_console_inc to read
  semihosting: Cleanup chardev init
  semihosting: Create qemu_semihosting_console_write
  semihosting: Add GuestFDConsole
  semihosting: Create qemu_semihosting_guestfd_init
  semihosting: Use console_in_gf for SYS_READC
  semihosting: Use console_out_gf for SYS_WRITEC
  semihosting: Remove qemu_semihosting_console_outc
  semihosting: Use console_out_gf for SYS_WRITE0
  semihosting: Remove qemu_semihosting_console_outs
  semihosting: Create semihost_sys_poll_one

 configs/targets/aarch64-linux-user.mak        |    1 +
 configs/targets/aarch64_be-linux-user.mak     |    1 +
 configs/targets/arm-linux-user.mak            |    1 +
 configs/targets/armeb-linux-user.mak          |    1 +
 configs/targets/riscv32-linux-user.mak        |    1 +
 configs/targets/riscv64-linux-user.mak        |    1 +
 include/exec/gdbstub.h                        |   67 +-
 include/exec/softmmu-semi.h                   |  101 --
 .../semihosting}/common-semi.h                |    2 +-
 include/semihosting/console.h                 |   71 +-
 include/semihosting/guestfd.h                 |   91 ++
 include/semihosting/semihost.h                |   14 +-
 include/semihosting/softmmu-uaccess.h         |   59 +
 include/semihosting/syscalls.h                |   75 ++
 target/arm/common-semi-target.h               |   62 +
 target/riscv/common-semi-target.h             |   50 +
 gdbstub.c                                     |    7 +-
 linux-user/aarch64/cpu_loop.c                 |    2 +-
 linux-user/arm/cpu_loop.c                     |    2 +-
 linux-user/main.c                             |    9 +
 linux-user/riscv/cpu_loop.c                   |    2 +-
 linux-user/semihost.c                         |   48 +-
 semihosting/arm-compat-semi.c                 |  984 ++++------------
 semihosting/config.c                          |   17 +-
 semihosting/console.c                         |  153 +--
 semihosting/guestfd.c                         |  160 +++
 semihosting/syscalls.c                        | 1008 +++++++++++++++++
 semihosting/uaccess.c                         |   91 ++
 softmmu/vl.c                                  |    3 +-
 stubs/semihost.c                              |    6 +-
 target/arm/helper.c                           |    4 +-
 target/arm/m_helper.c                         |    2 +-
 target/m68k/m68k-semi.c                       |   50 +-
 target/mips/tcg/sysemu/mips-semi.c            |    2 +-
 target/nios2/nios2-semi.c                     |   48 +-
 target/riscv/cpu_helper.c                     |    2 +-
 semihosting/meson.build                       |    6 +
 37 files changed, 2055 insertions(+), 1149 deletions(-)
 delete mode 100644 include/exec/softmmu-semi.h
 rename {semihosting => include/semihosting}/common-semi.h (96%)
 create mode 100644 include/semihosting/guestfd.h
 create mode 100644 include/semihosting/softmmu-uaccess.h
 create mode 100644 include/semihosting/syscalls.h
 create mode 100644 target/arm/common-semi-target.h
 create mode 100644 target/riscv/common-semi-target.h
 create mode 100644 semihosting/guestfd.c
 create mode 100644 semihosting/syscalls.c
 create mode 100644 semihosting/uaccess.c

-- 
2.34.1