From nobody Thu Jan 9 23:22:03 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653490271; cv=none; d=zohomail.com; s=zohoarc; b=iVMsh1i8ME9sROCc+sKtNwnAd8+LlJNsYGpKwzahA9PVtuMy+KlwgVDMnUS59HFfOHZjDWRPB7979n3uW/bAGGlIz0zWPFRxddEaVAGAAnmUmWTWdrC1Exfdpef2xrj2DJT5I4BP/Q9MGLXNpaS75nPIInj/aOxlQt1noHFjNic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653490271; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2uBEOyQEPIiObuqR7RI/+MglbL2+EMq4kneJ+0UPmX4=; b=bWHW8XU/iiVbBZj22nILfKqtCYfcnkVGgQbyueetOL4mmyYEQJhQUg7QYVAoVFjLUAgAdjM5hTI4E9g9V9aiYV+F9YgDZcKQC9nFJYnH2YK8DHuGaHoErrKZ1fYXrI2XO69nB7QDvvoByH6pPoBPI1fa78Lf0qUMkeC20fx30pM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1653490271267471.01112304811795; Wed, 25 May 2022 07:51:11 -0700 (PDT) Received: from localhost ([::1]:42076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntsLu-0006xi-5w for importer2@patchew.org; Wed, 25 May 2022 10:51:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntsGo-00039a-86 for qemu-devel@nongnu.org; Wed, 25 May 2022 10:45:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:40097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntsCy-00065S-St for qemu-devel@nongnu.org; Wed, 25 May 2022 10:41:58 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-V4UQG6GHOgSUgDzzaNojKw-1; Wed, 25 May 2022 10:41:53 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFC35185A794 for ; Wed, 25 May 2022 14:41:52 +0000 (UTC) Received: from localhost (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31D191121315; Wed, 25 May 2022 14:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653489716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2uBEOyQEPIiObuqR7RI/+MglbL2+EMq4kneJ+0UPmX4=; b=ZL0l0NQ2Ds6Wsx2qcRGUWAvXomNJTVPs5hLd2XyHt4hTlKIu1aFcfv0gqhdTK6ufYgNQMr 1uBh76EBylDEj8OwRMdEmUSJJ6yQWda0s3XBO8JbH/LfxMq+8ydkrNI1Cy+DJP+LP/y68Q PMwY7/9aBZCbGUiYS4d60n8Irjrs/uE= X-MC-Unique: V4UQG6GHOgSUgDzzaNojKw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Konstantin Kostiuk , Markus Armbruster , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v5 06/15] qga: use qga_open_cloexec() for safe_open_or_create() Date: Wed, 25 May 2022 16:41:31 +0200 Message-Id: <20220525144140.591926-7-marcandre.lureau@redhat.com> In-Reply-To: <20220525144140.591926-1-marcandre.lureau@redhat.com> References: <20220525144140.591926-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653490272878100001 From: Marc-Andr=C3=A9 Lureau The function takes care of setting CLOEXEC. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Markus Armbruster --- qga/commands-posix.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 8ee149e550..88ccbf2fdf 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -27,6 +27,7 @@ #include "qemu/cutils.h" #include "commands-common.h" #include "block/nvme.h" +#include "cutils.h" =20 #ifdef HAVE_UTMPX #include @@ -370,10 +371,10 @@ safe_open_or_create(const char *path, const char *mod= e, Error **errp) * open() is decisive and its third argument is ignored, and the second * open() and the fchmod() are never called. */ - fd =3D open(path, oflag | ((oflag & O_CREAT) ? O_EXCL : 0), 0); + fd =3D qga_open_cloexec(path, oflag | ((oflag & O_CREAT) ? O_EXCL : 0)= , 0); if (fd =3D=3D -1 && errno =3D=3D EEXIST) { oflag &=3D ~(unsigned)O_CREAT; - fd =3D open(path, oflag); + fd =3D qga_open_cloexec(path, oflag, 0); } if (fd =3D=3D -1) { error_setg_errno(errp, errno, @@ -382,8 +383,6 @@ safe_open_or_create(const char *path, const char *mode,= Error **errp) goto end; } =20 - qemu_set_cloexec(fd); - if ((oflag & O_CREAT) && fchmod(fd, DEFAULT_NEW_FILE_MODE) =3D=3D -1) { error_setg_errno(errp, errno, "failed to set permission " "0%03o on new file '%s' (mode: '%s')", --=20 2.36.1