hw/arm/xlnx-zynqmp.c | 4 +-- hw/display/xlnx_dp.c | 47 +++++++++++++++++++++++++++--------- include/hw/display/xlnx_dp.h | 12 +++++++-- 3 files changed, 48 insertions(+), 15 deletions(-)
From: Frederic Konrad <fkonrad@amd.com> Hi, This patch set fixes some issues with the DisplayPort for the ZCU102: The first patch fixes the wrong register size and thus the risk of register overflow. The three other one add a vblank interrupt required by the linux driver: - When using the VNC graphic backend and leaving it unconnected, in the best case the gfx_update callback is called once every 3000ms which is insufficient for the driver. This is fixed by providing a VBLANK interrupt from a ptimer. - This requirement revealed two issues with the IRQ numbers and the interrupt disable logic fixed by the two last patches. Tested by: - booting Petalinux with the framebuffer enabled. - migrating the running guest and ensure that the vblank timer still fire correctly. Best Regards, Fred v2 -> v3: * Added a VMSTATE in order to migrate the vblank timer as suggested by Peter Maydell (Patch 2). * Rebased on 0cac736e. v1 -> v2: * Better use of the ptimer API by using a correct POLICY as suggested by Peter Maydell (Patch 2). * Rebased on 78ac2eeb. Frederic Konrad (2): xlnx_dp: fix the wrong register size xlnx-zynqmp: fix the irq mapping for the display port and its dma Sai Pavan Boddu (2): xlnx_dp: Introduce a vblank signal xlnx_dp: Fix the interrupt disable logic hw/arm/xlnx-zynqmp.c | 4 +-- hw/display/xlnx_dp.c | 47 +++++++++++++++++++++++++++--------- include/hw/display/xlnx_dp.h | 12 +++++++-- 3 files changed, 48 insertions(+), 15 deletions(-) -- 2.25.1
On Wed, 1 Jun 2022 at 18:24, <frederic.konrad@xilinx.com> wrote: > > From: Frederic Konrad <fkonrad@amd.com> > > Hi, > > This patch set fixes some issues with the DisplayPort for the ZCU102: > > The first patch fixes the wrong register size and thus the risk of register > overflow. > > The three other one add a vblank interrupt required by the linux driver: > - When using the VNC graphic backend and leaving it unconnected, in the best > case the gfx_update callback is called once every 3000ms which is > insufficient for the driver. This is fixed by providing a VBLANK interrupt > from a ptimer. > - This requirement revealed two issues with the IRQ numbers and the > interrupt disable logic fixed by the two last patches. > > Tested by: > - booting Petalinux with the framebuffer enabled. > - migrating the running guest and ensure that the vblank timer still fire correctly. Hi; you forgot to bump the version_id in the vmstate struct when you added the new field. Since that was the only problem, I've taken the series into target-arm.next and made that change there. I also added a note to the commit message that this is a migration break for the xlnx-zcu102 board. thanks -- PMM
> -----Original Message----- > From: Peter Maydell <peter.maydell@linaro.org> > Sent: 06 June 2022 11:20 > To: Frederic Konrad <fkonrad@xilinx.com> > Cc: qemu-devel@nongnu.org; qemu-arm@nongnu.org; > edgar.iglesias@gmail.com; alistair@alistair23.me; Sai Pavan Boddu > <saipava@xilinx.com>; Edgar Iglesias <edgari@xilinx.com>; > fkonrad@amd.com > Subject: Re: [PATCH v3 0/4] xlnx-zcu102: fix the display port. > > On Wed, 1 Jun 2022 at 18:24, <frederic.konrad@xilinx.com> wrote: > > > > From: Frederic Konrad <fkonrad@amd.com> > > > > Hi, > > > > This patch set fixes some issues with the DisplayPort for the ZCU102: > > > > The first patch fixes the wrong register size and thus the risk of register > > overflow. > > > > The three other one add a vblank interrupt required by the linux driver: > > - When using the VNC graphic backend and leaving it unconnected, in the > best > > case the gfx_update callback is called once every 3000ms which is > > insufficient for the driver. This is fixed by providing a VBLANK interrupt > > from a ptimer. > > - This requirement revealed two issues with the IRQ numbers and the > > interrupt disable logic fixed by the two last patches. > > > > Tested by: > > - booting Petalinux with the framebuffer enabled. > > - migrating the running guest and ensure that the vblank timer still fire > correctly. > > Hi; you forgot to bump the version_id in the vmstate struct when you > added the new field. Since that was the only problem, I've taken the > series into target-arm.next and made that change there. I also added > a note to the commit message that this is a migration break for the > xlnx-zcu102 board. Oops, thanks for the fix Peter. Fred > > thanks > -- PMM
© 2016 - 2024 Red Hat, Inc.