From nobody Tue Feb 10 18:39:47 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660682506; cv=none; d=zohomail.com; s=zohoarc; b=O8NbQIyUVtXwmzD/EH+AxpVwRNCqSAME6wSW3JQYK+us+lxkyqNRJKfglTtclN1HYrt74y+bgvQYvzcErMe/vK/QwvvO/EQjWojA/07n5Jt5o4nphCFlmB4elMjEdXlOTtma85kZde7iSStZt5gypCweQb5guppPz44SWacNZ0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660682506; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GX62IFzgxiLc3YqrfYpimUBcYuQPnU8/+Qkb9r74BEo=; b=VUeg4UyDU97OmbDxzz15cFPGCD3gP2tjBDSAXh2UH/kCB5MTi/shqEJP7FOQMPlGVof7mS8QjuUXqBDPZ+2XfBUy2KVahJnhwZVJp47V17FjA0dbdeaPfMWWazqJTbX7V6MmXHDNriTN1gzp+zux59UryZenOBTgbrc/ildSBLQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660682506431746.3439119594105; Tue, 16 Aug 2022 13:41:46 -0700 (PDT) Received: from localhost ([::1]:44360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oO3Nh-0006sJ-BK for importer2@patchew.org; Tue, 16 Aug 2022 16:41:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oO3Gm-0004oX-Kw for qemu-devel@nongnu.org; Tue, 16 Aug 2022 16:34:36 -0400 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]:39917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oO3Gk-0004Vz-VP for qemu-devel@nongnu.org; Tue, 16 Aug 2022 16:34:36 -0400 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-11be650aaccso5531590fac.6 for ; Tue, 16 Aug 2022 13:34:23 -0700 (PDT) Received: from stoup.. ([2605:ef80:80f6:61fa:9bc2:5095:d612:5e22]) by smtp.gmail.com with ESMTPSA id y23-20020a056870b01700b0010ef8ccde67sm2285220oae.13.2022.08.16.13.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 13:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=GX62IFzgxiLc3YqrfYpimUBcYuQPnU8/+Qkb9r74BEo=; b=Qhwl/nzZib4gYpu3K7s4UGLiwy/W1ffbovnMmf38xL0AKNyDPF6F9Pw13jRKrZtMM+ sdwwhoRpFft74CLbkgsu8fu2GqGn3ykvrOZf8DzZn9OTqEwY6SuqVbBogZAHXiDGJ5nK jzphjqIOu95lJWybZTp1LNCkiAD5R/CLrIzVrwt/c3HwhTzSMIRcijJKfhQ4mSm2laEh L7jM4JBhp5gH7jq2gJmU/EjNALhYI/1zi9XRcEaCC9ToqbV+LPSSrEpobYs3kFlzkwbD GutM6EnvpPkGhJkbAotSNv4xRe+OghDRNxtZBL8oD0Pd3K4cgLcpg0zcB82FviOsx+1u LWsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=GX62IFzgxiLc3YqrfYpimUBcYuQPnU8/+Qkb9r74BEo=; b=68StIuM3mZ3b7TqCC+NfvHdowZzrdc/jOryEtf2qOAKKNDj3AIB1NV04z9JEM2vwPb wJj8nQ8frkjWALRbWsOSiCrsPT9IjvMCSa05TeKvIdHLrfoHBpJ0DOD2ldJ4l8L87iRC XKWObd9tha5AIL1hJ9I9RbNgAfb0svAPR41XYbH8L4eURgCSa8jmwuSw5//al3Bw7PE4 Ls141kx4u6sV9gtt5zRntIsWqVocpWpJSeZvYiO5ocbE9zbbjgZseU+WdXIgPltIsmaD H8d+GFpeqtdsOQpa2TgKh7ktkLKrHszjI25JHjKipcGmNhVsPgHjqHRY+/6nLpWJKm8t pDRg== X-Gm-Message-State: ACgBeo0s4UEn5UBOYXE+80bmmIHSasBGchvbz4xaPybXnU2rZyBumokc 9lbeL/+JZZn0AlWqSOgAKbVxuyBdsGZ8Mg== X-Google-Smtp-Source: AA6agR6ibQzDXEqwKBDBrohPkPd5ixQ4nVnm8ylyS/+b+wCOjny0cwZi2Z4lGkytmtl7nX76yYP51Q== X-Received: by 2002:a05:6870:b148:b0:112:cfe1:5062 with SMTP id a8-20020a056870b14800b00112cfe15062mr137113oal.297.1660682062731; Tue, 16 Aug 2022 13:34:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, alex.bennee@linaro.org, iii@linux.ibm.com Subject: [PATCH v2 07/33] accel/tcg: Use bool for page_find_alloc Date: Tue, 16 Aug 2022 15:33:34 -0500 Message-Id: <20220816203400.161187-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816203400.161187-1-richard.henderson@linaro.org> References: <20220816203400.161187-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::31; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660682508466100001 Content-Type: text/plain; charset="utf-8" Bool is more appropriate type for the alloc parameter. Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 298277a590..596029b26d 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -464,7 +464,7 @@ void page_init(void) #endif } =20 -static PageDesc *page_find_alloc(tb_page_addr_t index, int alloc) +static PageDesc *page_find_alloc(tb_page_addr_t index, bool alloc) { PageDesc *pd; void **lp; @@ -532,11 +532,11 @@ static PageDesc *page_find_alloc(tb_page_addr_t index= , int alloc) =20 static inline PageDesc *page_find(tb_page_addr_t index) { - return page_find_alloc(index, 0); + return page_find_alloc(index, false); } =20 static void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1, - PageDesc **ret_p2, tb_page_addr_t phys2, int al= loc); + PageDesc **ret_p2, tb_page_addr_t phys2, bool a= lloc); =20 /* In user-mode page locks aren't used; mmap_lock is enough */ #ifdef CONFIG_USER_ONLY @@ -650,7 +650,7 @@ static inline void page_unlock(PageDesc *pd) /* lock the page(s) of a TB in the correct acquisition order */ static inline void page_lock_tb(const TranslationBlock *tb) { - page_lock_pair(NULL, tb->page_addr[0], NULL, tb->page_addr[1], 0); + page_lock_pair(NULL, tb->page_addr[0], NULL, tb->page_addr[1], false); } =20 static inline void page_unlock_tb(const TranslationBlock *tb) @@ -839,7 +839,7 @@ void page_collection_unlock(struct page_collection *set) #endif /* !CONFIG_USER_ONLY */ =20 static void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1, - PageDesc **ret_p2, tb_page_addr_t phys2, int al= loc) + PageDesc **ret_p2, tb_page_addr_t phys2, bool a= lloc) { PageDesc *p1, *p2; tb_page_addr_t page1; @@ -1289,7 +1289,7 @@ tb_link_page(TranslationBlock *tb, tb_page_addr_t phy= s_pc, * Note that inserting into the hash table first isn't an option, since * we can only insert TBs that are fully initialized. */ - page_lock_pair(&p, phys_pc, &p2, phys_page2, 1); + page_lock_pair(&p, phys_pc, &p2, phys_page2, true); tb_page_add(p, tb, 0, phys_pc & TARGET_PAGE_MASK); if (p2) { tb_page_add(p2, tb, 1, phys_page2); @@ -2224,7 +2224,7 @@ void page_set_flags(target_ulong start, target_ulong = end, int flags) for (addr =3D start, len =3D end - start; len !=3D 0; len -=3D TARGET_PAGE_SIZE, addr +=3D TARGET_PAGE_SIZE) { - PageDesc *p =3D page_find_alloc(addr >> TARGET_PAGE_BITS, 1); + PageDesc *p =3D page_find_alloc(addr >> TARGET_PAGE_BITS, true); =20 /* If the write protection bit is set, then we invalidate the code inside. */ --=20 2.34.1