From nobody Wed Feb 11 01:45:19 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661292893; cv=none; d=zohomail.com; s=zohoarc; b=CM72WPEuCldxO9s0ofsyRgmPTpGBzGTl07bZAHbgdJz/4Ryjfle8VkP5bmUwAf9cmnVfXljGazYDwIr/+zor69CRjePCvSSlIAmVrkAnESesi0rvJNziBBwOOK3TllBElP6pAvwsZzITvG+myugVeW1R/2uIxLeCC5JkX25WYDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661292893; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x4zWBtw9jvwUVwVAd9mRUcqQWThPixmn/z1menAiivA=; b=A6qAfafFlBfDhO+9hkm12Pk+a/UUTlaV3/WTmdISGFsehzYrZzyGMANHwywGtAduTpmoNjuPKDGF8L2mOzGYrm+zqSyW3Fbdp7N8JR1CW9y7Ws9iS2wTJe7C6gaQZOOF/y1eki8/SxtVAMbjiI1LGZDFy80oHsoX7vO/2tv7BJM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166129289349490.09861796277369; Tue, 23 Aug 2022 15:14:53 -0700 (PDT) Received: from localhost ([::1]:52466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQcAe-0007T1-Gw for importer2@patchew.org; Tue, 23 Aug 2022 18:14:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQc27-0000Ce-Fn for qemu-devel@nongnu.org; Tue, 23 Aug 2022 18:06:03 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:37612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQc25-0001PW-S4 for qemu-devel@nongnu.org; Tue, 23 Aug 2022 18:06:03 -0400 Received: by mail-pl1-x633.google.com with SMTP id m2so14038964pls.4 for ; Tue, 23 Aug 2022 15:06:00 -0700 (PDT) Received: from stoup.. ([2602:47:d49d:ec01:46f9:77b4:ec0a:c2d9]) by smtp.gmail.com with ESMTPSA id n12-20020a170902f60c00b0017292073839sm11020974plg.178.2022.08.23.15.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 15:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=x4zWBtw9jvwUVwVAd9mRUcqQWThPixmn/z1menAiivA=; b=cswY3eoR7PQAzVE0RptNqm7H79rXehegzgfY6qFMg4aww3V1+JN5/scSkn1XHAY5k/ v1jfoTbvcPX56hqBT7NgmhySELbQSH41yXfyeLvo0NyASO7VpdkJIv38zfUZKhZ/l5nL Fbso4amudkY0/UTAKNcxl6X3dpHSxKugXGfSmcW3WVlmP9pyAViOvEox4gpngqGFjMwb QolEYnE+0FN5fdWYR4HlOUApKcFASD4z+FoK3DKzaLOig7fUaB8B4Ve1LvDm0milCQYK 1G4k1+sG6s4NotCTHUH4hEfeFlaFL3N+b5mK3DFmOl+JbX6J8+go6s4o4QI4JTZ7Ffxj nqGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=x4zWBtw9jvwUVwVAd9mRUcqQWThPixmn/z1menAiivA=; b=jXEA0ws5NnynMyUvmVDFhubOCc/NsFbngoVKeCjEhNA6Yd1g4mFB15fQM9HWA3XdMV 9Ulk2mt4br45miysWqeloM5FQtydS4yubtZzUplKD+YlVZWuA4SpwhKA+rDQMzsVSbgF HnaKEG0JkjB2MfsmwpO1Pn05MTG0Ie+DrfOr/8AsHqYI2XR6DHKVYo8CZxMC6m2NSOHy wzb49Y+CddPtld0K/lPYuZgFVzbaf4S0JFBTSuDQJ/2AuYwRlLxRjvL/qqZa3F3r6Pk0 /IH/WBbu6t8+XBNf92QQXWujh4VbB1laz//VKX+54ALJqjOvvzowJUcf2xSxWZsOVNP6 IYEw== X-Gm-Message-State: ACgBeo3vZ0OqjcDB+8QVAQ0VdDB95BJEqjqpZPyL1CyjEzw8YPcMsZEO Ixt1qQi3yKwU4UwgHqT+JHy17VhFvsIjtA== X-Google-Smtp-Source: AA6agR6wR379KthsZOTPCRDSQnwDZHGVJRImq26JLlhybx238TdeWd/hskfo9n/xU0s/u5JOLujCtg== X-Received: by 2002:a17:902:c949:b0:172:e3c3:bdeb with SMTP id i9-20020a170902c94900b00172e3c3bdebmr12461478pla.80.1661292360122; Tue, 23 Aug 2022 15:06:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: iii@linux.ibm.com, laurent@vivier.eu, alex.bennee@linaro.org Subject: [PATCH v7 13/20] accel/tcg: Document the faulting lookup in tb_lookup_cmp Date: Tue, 23 Aug 2022 15:05:35 -0700 Message-Id: <20220823220542.1993395-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220823220542.1993395-1-richard.henderson@linaro.org> References: <20220823220542.1993395-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661292894874100001 Content-Type: text/plain; charset="utf-8" It was non-obvious to me why we can raise an exception in the middle of a comparison function, but it works. While nearby, use TARGET_PAGE_ALIGN instead of open-coding. Signed-off-by: Richard Henderson Acked-by: Ilya Leoshkevich --- accel/tcg/cpu-exec.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 7887af6f45..5f43b9769a 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -198,7 +198,16 @@ static bool tb_lookup_cmp(const void *p, const void *d) tb_page_addr_t phys_page2; target_ulong virt_page2; =20 - virt_page2 =3D (desc->pc & TARGET_PAGE_MASK) + TARGET_PAGE_SIZ= E; + /* + * We know that the first page matched, and an otherwise valid= TB + * encountered an incomplete instruction at the end of that pa= ge, + * therefore we know that generating a new TB from the current= PC + * must also require reading from the next page -- even if the + * second pages do not match, and therefore the resulting insn + * is different for the new TB. Therefore any exception raised + * here by the faulting lookup is not premature. + */ + virt_page2 =3D TARGET_PAGE_ALIGN(desc->pc); phys_page2 =3D get_page_addr_code(desc->env, virt_page2); if (tb->page_addr[1] =3D=3D phys_page2) { return true; --=20 2.34.1