[PATCH 2/8] hw/pci-bridge/cxl_downstream: Fix type naming mismatch

Jonathan Cameron via posted 8 patches 1 year, 9 months ago
There is a newer version of this series
[PATCH 2/8] hw/pci-bridge/cxl_downstream: Fix type naming mismatch
Posted by Jonathan Cameron via 1 year, 9 months ago
Fix capitalization difference between struct name and typedef.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 hw/pci-bridge/cxl_downstream.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci-bridge/cxl_downstream.c b/hw/pci-bridge/cxl_downstream.c
index 3d4e6b59cd..54f507318f 100644
--- a/hw/pci-bridge/cxl_downstream.c
+++ b/hw/pci-bridge/cxl_downstream.c
@@ -15,7 +15,7 @@
 #include "hw/pci/pcie_port.h"
 #include "qapi/error.h"
 
-typedef struct CXLDownStreamPort {
+typedef struct CXLDownstreamPort {
     /*< private >*/
     PCIESlot parent_obj;
 
-- 
2.37.2
Re: [PATCH 2/8] hw/pci-bridge/cxl_downstream: Fix type naming mismatch
Posted by Ira Weiny 1 year, 9 months ago
On Wed, Jan 11, 2023 at 02:24:34PM +0000, Jonathan Cameron wrote:
> Fix capitalization difference between struct name and typedef.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  hw/pci-bridge/cxl_downstream.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-bridge/cxl_downstream.c b/hw/pci-bridge/cxl_downstream.c
> index 3d4e6b59cd..54f507318f 100644
> --- a/hw/pci-bridge/cxl_downstream.c
> +++ b/hw/pci-bridge/cxl_downstream.c
> @@ -15,7 +15,7 @@
>  #include "hw/pci/pcie_port.h"
>  #include "qapi/error.h"
>  
> -typedef struct CXLDownStreamPort {
> +typedef struct CXLDownstreamPort {
>      /*< private >*/
>      PCIESlot parent_obj;
>  
> -- 
> 2.37.2
>
Re: [PATCH 2/8] hw/pci-bridge/cxl_downstream: Fix type naming mismatch
Posted by Philippe Mathieu-Daudé 1 year, 9 months ago
On 11/1/23 15:24, Jonathan Cameron via wrote:
> Fix capitalization difference between struct name and typedef.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>   hw/pci-bridge/cxl_downstream.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-bridge/cxl_downstream.c b/hw/pci-bridge/cxl_downstream.c
> index 3d4e6b59cd..54f507318f 100644
> --- a/hw/pci-bridge/cxl_downstream.c
> +++ b/hw/pci-bridge/cxl_downstream.c
> @@ -15,7 +15,7 @@
>   #include "hw/pci/pcie_port.h"
>   #include "qapi/error.h"
>   
> -typedef struct CXLDownStreamPort {
> +typedef struct CXLDownstreamPort {
>       /*< private >*/
>       PCIESlot parent_obj;
>   

I was going to post the same patch because when reworking some QOM
definitions I'm getting:

     ../../hw/pci-bridge/cxl_downstream.c:27:26: error: typedef 
redefinition with different types ('struct CXLDownstreamPort' vs 'struct 
CXLDownStreamPort')
     DECLARE_INSTANCE_CHECKER(CXLDownstreamPort, CXL_DSP, TYPE_CXL_DSP)
                              ^
     ../../hw/pci-bridge/cxl_downstream.c:24:3: note: previous 
definition is here
     } CXLDownstreamPort;
       ^

So thanks!

Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>