[RFC PATCH v3 24/28] tests/avocado: Skip tests that require a missing accelerator

Fabiano Rosas posted 28 patches 2 years, 3 months ago
There is a newer version of this series
[RFC PATCH v3 24/28] tests/avocado: Skip tests that require a missing accelerator
Posted by Fabiano Rosas 2 years, 3 months ago
If a test was tagged with the "accel" tag and the specified
accelerator it not present in the qemu binary, cancel the test.

We can now write tests without explicit calls to require_accelerator,
just the tag is enough.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 tests/avocado/avocado_qemu/__init__.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py
index 910f3ba1ea..ed2809210b 100644
--- a/tests/avocado/avocado_qemu/__init__.py
+++ b/tests/avocado/avocado_qemu/__init__.py
@@ -274,6 +274,10 @@ def setUp(self):
 
         super().setUp('qemu-system-')
 
+        accel_required = self._get_unique_tag_val('accel')
+        if accel_required:
+            self.require_accelerator(accel_required)
+
         self.machine = self.params.get('machine',
                                        default=self._get_unique_tag_val('machine'))
 
-- 
2.35.3
Re: [RFC PATCH v3 24/28] tests/avocado: Skip tests that require a missing accelerator
Posted by Richard Henderson 2 years, 3 months ago
On 1/13/23 06:04, Fabiano Rosas wrote:
> If a test was tagged with the "accel" tag and the specified
> accelerator it not present in the qemu binary, cancel the test.
> 
> We can now write tests without explicit calls to require_accelerator,
> just the tag is enough.
> 
> Signed-off-by: Fabiano Rosas<farosas@suse.de>
> ---
>   tests/avocado/avocado_qemu/__init__.py | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~