From nobody Tue May 13 11:41:33 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673642669; cv=none; d=zohomail.com; s=zohoarc; b=ZFHdX0ONP6T/7/Td93tc1AmOT5Rh3Ef8HhlVrcpMbXH1IaISW+OjUSIrCwmTw+zpKffwj1NUJoOqi/bKt455INvXdEzUz7GCr55Fj4Ui4lAq95F5KyQgQpW09M3RiWzJY8Qdup0ghfE1e9owaoc5QV3QnXwN7jMw2Qdy6czTF44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673642669; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Dh+y4/C7RIJtnMBasw9aix/sWKPREPMgdAW5/aFDiKk=; b=JUy4XByRxqDHu4OsngcZNTcGr7UKQ4vKXifuStid23GsnjR7VYFSNdb+uU711/Uz4Ez3Up49H5I5o0ivNgoFAhXM3kRkvTG9Hs/yoeEczFJw+ZuWOBaqrxH6mTCeYtlbXcQXCV39/TmHaLzP4K2nYjBIRmU8OXP3hb+cpfad4Z4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1673642669762982.3830889452156; Fri, 13 Jan 2023 12:44:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGQt2-000070-LJ; Fri, 13 Jan 2023 15:42:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGQt0-00005t-JP for qemu-devel@nongnu.org; Fri, 13 Jan 2023 15:42:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGQsy-0006CS-B9 for qemu-devel@nongnu.org; Fri, 13 Jan 2023 15:42:50 -0500 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-cC8IKU7fMFSnMoZueYBplQ-1; Fri, 13 Jan 2023 15:42:44 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 57C731C01B21; Fri, 13 Jan 2023 20:42:44 +0000 (UTC) Received: from merkur.redhat.com (unknown [10.39.195.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 260392026D68; Fri, 13 Jan 2023 20:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673642567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dh+y4/C7RIJtnMBasw9aix/sWKPREPMgdAW5/aFDiKk=; b=hPrm8hamdwGJ/FdYcubloQszwRoc+w74gY0XmDQ15UPskVa4ZjQ3mEeJSS6C5j3S9yuosI 18mgDcHwGeuq2pNH9+iavGFrpIFkIwgdC92mO7vyXDsOF0C8vP2S5jeb5kC+nqvlSFy0s1 tSYc0L7EYt8qORm27vfiEAOGXQioyew= X-MC-Unique: cC8IKU7fMFSnMoZueYBplQ-1 From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, hreitz@redhat.com, eesposit@redhat.com, pbonzini@redhat.com, vsementsov@yandex-team.ru, qemu-devel@nongnu.org Subject: [PATCH v2 09/14] block: Convert bdrv_get_allocated_file_size() to co_wrapper Date: Fri, 13 Jan 2023 21:42:07 +0100 Message-Id: <20230113204212.359076-10-kwolf@redhat.com> In-Reply-To: <20230113204212.359076-1-kwolf@redhat.com> References: <20230113204212.359076-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1673642670856100003 Content-Type: text/plain; charset="utf-8" From: Emanuele Giuseppe Esposito bdrv_get_allocated_file_size() is categorized as an I/O function, and it currently doesn't run in a coroutine. We should let it take a graph rdlock since it traverses the block nodes graph, which however is only possible in a coroutine. Therefore turn it into a co_wrapper to move the actual function into a coroutine where the lock can be taken. Signed-off-by: Emanuele Giuseppe Esposito Signed-off-by: Kevin Wolf --- include/block/block-io.h | 4 +++- include/block/block_int-common.h | 4 +++- block.c | 12 ++++++------ block/file-posix.c | 14 +++++--------- block/file-win32.c | 10 ++++------ block/gluster.c | 11 ++++++----- block/nfs.c | 4 ++-- block/null.c | 7 ++++--- block/qcow2-refcount.c | 2 +- block/vmdk.c | 9 +++++---- 10 files changed, 39 insertions(+), 38 deletions(-) diff --git a/include/block/block-io.h b/include/block/block-io.h index 4dcb5f73fa..0718554590 100644 --- a/include/block/block-io.h +++ b/include/block/block-io.h @@ -79,7 +79,9 @@ int64_t co_wrapper_mixed bdrv_nb_sectors(BlockDriverState= *bs); int64_t coroutine_fn bdrv_co_getlength(BlockDriverState *bs); int64_t co_wrapper_mixed bdrv_getlength(BlockDriverState *bs); =20 -int64_t bdrv_get_allocated_file_size(BlockDriverState *bs); +int64_t coroutine_fn bdrv_co_get_allocated_file_size(BlockDriverState *bs); +int64_t co_wrapper bdrv_get_allocated_file_size(BlockDriverState *bs); + BlockMeasureInfo *bdrv_measure(BlockDriver *drv, QemuOpts *opts, BlockDriverState *in_bs, Error **errp); void bdrv_get_geometry(BlockDriverState *bs, uint64_t *nb_sectors_ptr); diff --git a/include/block/block_int-common.h b/include/block/block_int-com= mon.h index 6336c7239a..cc03c599e7 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -685,7 +685,9 @@ struct BlockDriver { bool exact, PreallocMode prealloc, BdrvRequestFlags flags, Error **e= rrp); int64_t coroutine_fn (*bdrv_co_getlength)(BlockDriverState *bs); - int64_t (*bdrv_get_allocated_file_size)(BlockDriverState *bs); + int64_t coroutine_fn (*bdrv_co_get_allocated_file_size)( + BlockDriverState *bs); + BlockMeasureInfo *(*bdrv_measure)(QemuOpts *opts, BlockDriverState *in= _bs, Error **errp); =20 diff --git a/block.c b/block.c index dd22a206f9..82c6cb6dcd 100644 --- a/block.c +++ b/block.c @@ -5719,7 +5719,7 @@ exit: } =20 /** - * Implementation of BlockDriver.bdrv_get_allocated_file_size() that + * Implementation of BlockDriver.bdrv_co_get_allocated_file_size() that * sums the size of all data-bearing children. (This excludes backing * children.) */ @@ -5732,7 +5732,7 @@ static int64_t bdrv_sum_allocated_file_size(BlockDriv= erState *bs) if (child->role & (BDRV_CHILD_DATA | BDRV_CHILD_METADATA | BDRV_CHILD_FILTERED)) { - child_size =3D bdrv_get_allocated_file_size(child->bs); + child_size =3D bdrv_co_get_allocated_file_size(child->bs); if (child_size < 0) { return child_size; } @@ -5747,7 +5747,7 @@ static int64_t bdrv_sum_allocated_file_size(BlockDriv= erState *bs) * Length of a allocated file in bytes. Sparse files are counted by actual * allocated space. Return < 0 if error or unknown. */ -int64_t bdrv_get_allocated_file_size(BlockDriverState *bs) +int64_t coroutine_fn bdrv_co_get_allocated_file_size(BlockDriverState *bs) { BlockDriver *drv =3D bs->drv; IO_CODE(); @@ -5755,8 +5755,8 @@ int64_t bdrv_get_allocated_file_size(BlockDriverState= *bs) if (!drv) { return -ENOMEDIUM; } - if (drv->bdrv_get_allocated_file_size) { - return drv->bdrv_get_allocated_file_size(bs); + if (drv->bdrv_co_get_allocated_file_size) { + return drv->bdrv_co_get_allocated_file_size(bs); } =20 if (drv->bdrv_file_open) { @@ -5768,7 +5768,7 @@ int64_t bdrv_get_allocated_file_size(BlockDriverState= *bs) return -ENOTSUP; } else if (drv->is_filter) { /* Filter drivers default to the size of their filtered child */ - return bdrv_get_allocated_file_size(bdrv_filter_bs(bs)); + return bdrv_co_get_allocated_file_size(bdrv_filter_bs(bs)); } else { /* Other drivers default to summing their children's sizes */ return bdrv_sum_allocated_file_size(bs); diff --git a/block/file-posix.c b/block/file-posix.c index d70e4ec95a..a22f93e4b2 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2468,7 +2468,7 @@ static int64_t coroutine_fn raw_co_getlength(BlockDri= verState *bs) } #endif =20 -static int64_t raw_get_allocated_file_size(BlockDriverState *bs) +static int64_t coroutine_fn raw_co_get_allocated_file_size(BlockDriverStat= e *bs) { struct stat st; BDRVRawState *s =3D bs->opaque; @@ -3328,8 +3328,7 @@ BlockDriver bdrv_file =3D { .bdrv_co_truncate =3D raw_co_truncate, .bdrv_co_getlength =3D raw_co_getlength, .bdrv_get_info =3D raw_get_info, - .bdrv_get_allocated_file_size - =3D raw_get_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D raw_co_get_allocated_file_size, .bdrv_get_specific_stats =3D raw_get_specific_stats, .bdrv_check_perm =3D raw_check_perm, .bdrv_set_perm =3D raw_set_perm, @@ -3700,8 +3699,7 @@ static BlockDriver bdrv_host_device =3D { .bdrv_co_truncate =3D raw_co_truncate, .bdrv_co_getlength =3D raw_co_getlength, .bdrv_get_info =3D raw_get_info, - .bdrv_get_allocated_file_size - =3D raw_get_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D raw_co_get_allocated_file_size, .bdrv_get_specific_stats =3D hdev_get_specific_stats, .bdrv_check_perm =3D raw_check_perm, .bdrv_set_perm =3D raw_set_perm, @@ -3824,8 +3822,7 @@ static BlockDriver bdrv_host_cdrom =3D { .bdrv_co_truncate =3D raw_co_truncate, .bdrv_co_getlength =3D raw_co_getlength, .has_variable_length =3D true, - .bdrv_get_allocated_file_size - =3D raw_get_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D raw_co_get_allocated_file_size, =20 /* removable device support */ .bdrv_co_is_inserted =3D cdrom_co_is_inserted, @@ -3954,8 +3951,7 @@ static BlockDriver bdrv_host_cdrom =3D { .bdrv_co_truncate =3D raw_co_truncate, .bdrv_co_getlength =3D raw_co_getlength, .has_variable_length =3D true, - .bdrv_get_allocated_file_size - =3D raw_get_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D raw_co_get_allocated_file_size, =20 /* removable device support */ .bdrv_co_is_inserted =3D cdrom_co_is_inserted, diff --git a/block/file-win32.c b/block/file-win32.c index aedee695dd..6ff576b20d 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -558,7 +558,7 @@ static int64_t coroutine_fn raw_co_getlength(BlockDrive= rState *bs) return l.QuadPart; } =20 -static int64_t raw_get_allocated_file_size(BlockDriverState *bs) +static int64_t coroutine_fn raw_co_get_allocated_file_size(BlockDriverStat= e *bs) { typedef DWORD (WINAPI * get_compressed_t)(const char *filename, DWORD * high); @@ -764,8 +764,8 @@ BlockDriver bdrv_file =3D { =20 .bdrv_co_truncate =3D raw_co_truncate, .bdrv_co_getlength =3D raw_co_getlength, - .bdrv_get_allocated_file_size - =3D raw_get_allocated_file_size, + .bdrv_co_get_allocated_file_size + =3D raw_co_get_allocated_file_size, =20 .create_opts =3D &raw_create_opts, }; @@ -934,9 +934,7 @@ static BlockDriver bdrv_host_device =3D { =20 .bdrv_co_getlength =3D raw_co_getlength, .has_variable_length =3D true, - - .bdrv_get_allocated_file_size - =3D raw_get_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D raw_co_get_allocated_file_size, }; =20 static void bdrv_file_init(void) diff --git a/block/gluster.c b/block/gluster.c index 469cdf01d4..7b4e1dd795 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -1330,7 +1330,8 @@ static int64_t coroutine_fn qemu_gluster_co_getlength= (BlockDriverState *bs) } } =20 -static int64_t qemu_gluster_allocated_file_size(BlockDriverState *bs) +static int64_t coroutine_fn +qemu_gluster_co_get_allocated_file_size(BlockDriverState *bs) { BDRVGlusterState *s =3D bs->opaque; struct stat st; @@ -1559,7 +1560,7 @@ static BlockDriver bdrv_gluster =3D { .bdrv_co_create =3D qemu_gluster_co_create, .bdrv_co_create_opts =3D qemu_gluster_co_create_opts, .bdrv_co_getlength =3D qemu_gluster_co_getlength, - .bdrv_get_allocated_file_size =3D qemu_gluster_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D qemu_gluster_co_get_allocated_fil= e_size, .bdrv_co_truncate =3D qemu_gluster_co_truncate, .bdrv_co_readv =3D qemu_gluster_co_readv, .bdrv_co_writev =3D qemu_gluster_co_writev, @@ -1588,7 +1589,7 @@ static BlockDriver bdrv_gluster_tcp =3D { .bdrv_co_create =3D qemu_gluster_co_create, .bdrv_co_create_opts =3D qemu_gluster_co_create_opts, .bdrv_co_getlength =3D qemu_gluster_co_getlength, - .bdrv_get_allocated_file_size =3D qemu_gluster_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D qemu_gluster_co_get_allocated_fil= e_size, .bdrv_co_truncate =3D qemu_gluster_co_truncate, .bdrv_co_readv =3D qemu_gluster_co_readv, .bdrv_co_writev =3D qemu_gluster_co_writev, @@ -1617,7 +1618,7 @@ static BlockDriver bdrv_gluster_unix =3D { .bdrv_co_create =3D qemu_gluster_co_create, .bdrv_co_create_opts =3D qemu_gluster_co_create_opts, .bdrv_co_getlength =3D qemu_gluster_co_getlength, - .bdrv_get_allocated_file_size =3D qemu_gluster_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D qemu_gluster_co_get_allocated_fil= e_size, .bdrv_co_truncate =3D qemu_gluster_co_truncate, .bdrv_co_readv =3D qemu_gluster_co_readv, .bdrv_co_writev =3D qemu_gluster_co_writev, @@ -1652,7 +1653,7 @@ static BlockDriver bdrv_gluster_rdma =3D { .bdrv_co_create =3D qemu_gluster_co_create, .bdrv_co_create_opts =3D qemu_gluster_co_create_opts, .bdrv_co_getlength =3D qemu_gluster_co_getlength, - .bdrv_get_allocated_file_size =3D qemu_gluster_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D qemu_gluster_co_get_allocated_fil= e_size, .bdrv_co_truncate =3D qemu_gluster_co_truncate, .bdrv_co_readv =3D qemu_gluster_co_readv, .bdrv_co_writev =3D qemu_gluster_co_writev, diff --git a/block/nfs.c b/block/nfs.c index ece22353ac..cbf742661e 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -731,7 +731,7 @@ nfs_get_allocated_file_size_cb(int ret, struct nfs_cont= ext *nfs, void *data, bdrv_wakeup(task->bs); } =20 -static int64_t nfs_get_allocated_file_size(BlockDriverState *bs) +static int64_t coroutine_fn nfs_co_get_allocated_file_size(BlockDriverStat= e *bs) { NFSClient *client =3D bs->opaque; NFSRPC task =3D {0}; @@ -884,7 +884,7 @@ static BlockDriver bdrv_nfs =3D { .bdrv_has_zero_init =3D nfs_has_zero_init, /* libnfs does not provide the allocated filesize of a file on win32. */ #if !defined(_WIN32) - .bdrv_get_allocated_file_size =3D nfs_get_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D nfs_co_get_allocated_file_size, #endif .bdrv_co_truncate =3D nfs_file_co_truncate, =20 diff --git a/block/null.c b/block/null.c index 05dde6d9ab..aa5931effa 100644 --- a/block/null.c +++ b/block/null.c @@ -264,7 +264,8 @@ static void null_refresh_filename(BlockDriverState *bs) bs->drv->format_name); } =20 -static int64_t null_allocated_file_size(BlockDriverState *bs) +static int64_t coroutine_fn +null_co_get_allocated_file_size(BlockDriverState *bs) { return 0; } @@ -284,7 +285,7 @@ static BlockDriver bdrv_null_co =3D { .bdrv_file_open =3D null_file_open, .bdrv_parse_filename =3D null_co_parse_filename, .bdrv_co_getlength =3D null_co_getlength, - .bdrv_get_allocated_file_size =3D null_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D null_co_get_allocated_file_size, =20 .bdrv_co_preadv =3D null_co_preadv, .bdrv_co_pwritev =3D null_co_pwritev, @@ -305,7 +306,7 @@ static BlockDriver bdrv_null_aio =3D { .bdrv_file_open =3D null_file_open, .bdrv_parse_filename =3D null_aio_parse_filename, .bdrv_co_getlength =3D null_co_getlength, - .bdrv_get_allocated_file_size =3D null_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D null_co_get_allocated_file_size, =20 .bdrv_aio_preadv =3D null_aio_preadv, .bdrv_aio_pwritev =3D null_aio_pwritev, diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 81264740f0..487681d85e 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -3719,7 +3719,7 @@ int coroutine_fn qcow2_detect_metadata_preallocation(= BlockDriverState *bs) return file_length; } =20 - real_allocation =3D bdrv_get_allocated_file_size(bs->file->bs); + real_allocation =3D bdrv_co_get_allocated_file_size(bs->file->bs); if (real_allocation < 0) { return real_allocation; } diff --git a/block/vmdk.c b/block/vmdk.c index 8894dac2d4..04f50d2e49 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -2856,14 +2856,15 @@ static void vmdk_close(BlockDriverState *bs) error_free(s->migration_blocker); } =20 -static int64_t vmdk_get_allocated_file_size(BlockDriverState *bs) +static int64_t coroutine_fn +vmdk_co_get_allocated_file_size(BlockDriverState *bs) { int i; int64_t ret =3D 0; int64_t r; BDRVVmdkState *s =3D bs->opaque; =20 - ret =3D bdrv_get_allocated_file_size(bs->file->bs); + ret =3D bdrv_co_get_allocated_file_size(bs->file->bs); if (ret < 0) { return ret; } @@ -2871,7 +2872,7 @@ static int64_t vmdk_get_allocated_file_size(BlockDriv= erState *bs) if (s->extents[i].file =3D=3D bs->file) { continue; } - r =3D bdrv_get_allocated_file_size(s->extents[i].file->bs); + r =3D bdrv_co_get_allocated_file_size(s->extents[i].file->bs); if (r < 0) { return r; } @@ -3124,7 +3125,7 @@ static BlockDriver bdrv_vmdk =3D { .bdrv_co_create_opts =3D vmdk_co_create_opts, .bdrv_co_create =3D vmdk_co_create, .bdrv_co_block_status =3D vmdk_co_block_status, - .bdrv_get_allocated_file_size =3D vmdk_get_allocated_file_size, + .bdrv_co_get_allocated_file_size =3D vmdk_co_get_allocated_file_size, .bdrv_has_zero_init =3D vmdk_has_zero_init, .bdrv_get_specific_info =3D vmdk_get_specific_info, .bdrv_refresh_limits =3D vmdk_refresh_limits, --=20 2.38.1