linux-user: Improve strace output of getgroups() and setgroups()

[PATCH] linux-user: Improve strace output of getgroups() and setgroups()

Posted by Helge Deller 1 year, 3 months ago

Make the strace look nicer for those syscalls.

Signed-off-by: Helge Deller <deller@gmx.de>
---
 linux-user/strace.list | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/linux-user/strace.list b/linux-user/strace.list
index 3924046426..7c1124a718 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -321,10 +321,10 @@
 { TARGET_NR_getgid32, "getgid32" , NULL, NULL, NULL },
 #endif
 #ifdef TARGET_NR_getgroups
-{ TARGET_NR_getgroups, "getgroups" , NULL, NULL, NULL },
+{ TARGET_NR_getgroups, "getgroups" , "%s(%d,%p)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_getgroups32
-{ TARGET_NR_getgroups32, "getgroups32" , NULL, NULL, NULL },
+{ TARGET_NR_getgroups32, "getgroups32" , "%s(%d,%p)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_gethostname
 { TARGET_NR_gethostname, "gethostname" , NULL, NULL, NULL },
@@ -1308,10 +1308,10 @@
 { TARGET_NR_setgid32, "setgid32" , "%s(%u)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_setgroups
-{ TARGET_NR_setgroups, "setgroups" , NULL, NULL, NULL },
+{ TARGET_NR_setgroups, "setgroups" , "%s(%d,%p)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_setgroups32
-{ TARGET_NR_setgroups32, "setgroups32" , NULL, NULL, NULL },
+{ TARGET_NR_setgroups32, "setgroups32" , "%s(%d,%p)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_sethae
 { TARGET_NR_sethae, "sethae" , NULL, NULL, NULL },
--
2.38.1

Re: [PATCH] linux-user: Improve strace output of getgroups() and setgroups()

Posted by Laurent Vivier 1 year, 2 months ago

Le 15/01/2023 à 22:00, Helge Deller a écrit :
> Make the strace look nicer for those syscalls.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>   linux-user/strace.list | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index 3924046426..7c1124a718 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -321,10 +321,10 @@
>   { TARGET_NR_getgid32, "getgid32" , NULL, NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_getgroups
> -{ TARGET_NR_getgroups, "getgroups" , NULL, NULL, NULL },
> +{ TARGET_NR_getgroups, "getgroups" , "%s(%d,%p)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_getgroups32
> -{ TARGET_NR_getgroups32, "getgroups32" , NULL, NULL, NULL },
> +{ TARGET_NR_getgroups32, "getgroups32" , "%s(%d,%p)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_gethostname
>   { TARGET_NR_gethostname, "gethostname" , NULL, NULL, NULL },
> @@ -1308,10 +1308,10 @@
>   { TARGET_NR_setgid32, "setgid32" , "%s(%u)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_setgroups
> -{ TARGET_NR_setgroups, "setgroups" , NULL, NULL, NULL },
> +{ TARGET_NR_setgroups, "setgroups" , "%s(%d,%p)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_setgroups32
> -{ TARGET_NR_setgroups32, "setgroups32" , NULL, NULL, NULL },
> +{ TARGET_NR_setgroups32, "setgroups32" , "%s(%d,%p)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_sethae
>   { TARGET_NR_sethae, "sethae" , NULL, NULL, NULL },
> --
> 2.38.1
> 
> 
Applied to my linux-user-for-8.0 branch.

Thanks,
Laurent

Re: [PATCH] linux-user: Improve strace output of getgroups() and setgroups()

Posted by Laurent Vivier 1 year, 2 months ago

Le 15/01/2023 à 22:00, Helge Deller a écrit :
> Make the strace look nicer for those syscalls.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>   linux-user/strace.list | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 


Reviewed-by: Laurent Vivier <laurent@vivier.eu>