[PATCH v2 0/2] audio: make audiodev introspectable by management apps

Thomas Huth posted 2 patches 2 weeks, 2 days ago
qapi/audio.json        | 57 +++++++++++++++++++++++++++++++++---------
audio/audio_template.h | 20 +++++++++++++++
audio/audio.c          | 32 ++++++++++++++++++++++++
audio/audio_legacy.c   | 41 +++++++++++++++++++++++++++++-
4 files changed, 137 insertions(+), 13 deletions(-)
[PATCH v2 0/2] audio: make audiodev introspectable by management apps
Posted by Thomas Huth 2 weeks, 2 days ago
Here's a respin from Daniel's audiodev introspection patches from
2021. I've rebased them to the current master branch and addressed
the review comments from v1.

The Audiodev QAPI type is not introspectable via query-qmp-schema as
nothing in QMP uses it. "-audiodev" is not introspectable via
query-command-line-options because it avoided legacy QemuOpts.

To fix it, introduce a tiny "query-audiodev" QMP command that uses
the "Audiodev" QAPI structure, so that it shows up in the schema.
Then mark the various backend types with conditionals so that only
the ones that were available at compile time show up in the schema.

Daniel P. Berrangé (2):
  qapi, audio: add query-audiodev command
  qapi, audio: Make introspection reflect build configuration more
    closely

 qapi/audio.json        | 57 +++++++++++++++++++++++++++++++++---------
 audio/audio_template.h | 20 +++++++++++++++
 audio/audio.c          | 32 ++++++++++++++++++++++++
 audio/audio_legacy.c   | 41 +++++++++++++++++++++++++++++-
 4 files changed, 137 insertions(+), 13 deletions(-)

-- 
2.31.1


Re: [PATCH v2 0/2] audio: make audiodev introspectable by management apps
Posted by Thomas Huth 1 week, 1 day ago
On 23/01/2023 09.39, Thomas Huth wrote:
> Here's a respin from Daniel's audiodev introspection patches from
> 2021. I've rebased them to the current master branch and addressed
> the review comments from v1.
> 
> The Audiodev QAPI type is not introspectable via query-qmp-schema as
> nothing in QMP uses it. "-audiodev" is not introspectable via
> query-command-line-options because it avoided legacy QemuOpts.
> 
> To fix it, introduce a tiny "query-audiodev" QMP command that uses
> the "Audiodev" QAPI structure, so that it shows up in the schema.
> Then mark the various backend types with conditionals so that only
> the ones that were available at compile time show up in the schema.
> 
> Daniel P. Berrangé (2):
>    qapi, audio: add query-audiodev command
>    qapi, audio: Make introspection reflect build configuration more
>      closely

Since there were no objections and since Gerd seems to be pretty busy with 
other stuff recently, I'll dare to pick these up for my next pull request.

  Thomas