[v2] qga/linux: add usb support to guest-get-fsinfo

[PATCH v2] qga/linux: add usb support to guest-get-fsinfo

Posted by Kfir Manor 1 year, 3 months ago

Signed-off-by: Kfir Manor <kfir@daynix.com>
---
 qga/commands-posix.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ebd33a643c..aab9d3bd50 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
                        g_str_equal(driver, "sym53c8xx") ||
                        g_str_equal(driver, "virtio-pci") ||
                        g_str_equal(driver, "ahci") ||
-                       g_str_equal(driver, "nvme"))) {
+                       g_str_equal(driver, "nvme") ||
+                       g_str_equal(driver, "xhci_hcd") ||
+                       g_str_equal(driver, "ehci-pci"))) {
             break;
         }
 
@@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
         }
     } else if (strcmp(driver, "nvme") == 0) {
         disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
+    } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, "xhci_hcd") == 0) {
+        disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
     } else {
         g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
         goto cleanup;
-- 
2.38.1

Re: [PATCH v2] qga/linux: add usb support to guest-get-fsinfo

Posted by Konstantin Kostiuk 1 year, 3 months ago

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Mon, Jan 23, 2023 at 3:31 PM Kfir Manor <kfir@daynix.com> wrote:

> Signed-off-by: Kfir Manor <kfir@daynix.com>
> ---
>  qga/commands-posix.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index ebd33a643c..aab9d3bd50 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
>                         g_str_equal(driver, "sym53c8xx") ||
>                         g_str_equal(driver, "virtio-pci") ||
>                         g_str_equal(driver, "ahci") ||
> -                       g_str_equal(driver, "nvme"))) {
> +                       g_str_equal(driver, "nvme") ||
> +                       g_str_equal(driver, "xhci_hcd") ||
> +                       g_str_equal(driver, "ehci-pci"))) {
>              break;
>          }
>
> @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
>          }
>      } else if (strcmp(driver, "nvme") == 0) {
>          disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> +    } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> "xhci_hcd") == 0) {
> +        disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
>      } else {
>          g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
>          goto cleanup;
> --
> 2.38.1
>
>

Re: [PATCH v2] qga/linux: add usb support to guest-get-fsinfo

Posted by Daniel P. Berrangé 1 year ago

What's the status of this patch ?  It was acked 2 months ago but
AFAICT it was never merged.

On Mon, Jan 23, 2023 at 10:42:06PM +0200, Konstantin Kostiuk wrote:
> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> 
> On Mon, Jan 23, 2023 at 3:31 PM Kfir Manor <kfir@daynix.com> wrote:
> 
> > Signed-off-by: Kfir Manor <kfir@daynix.com>
> > ---
> >  qga/commands-posix.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> > index ebd33a643c..aab9d3bd50 100644
> > --- a/qga/commands-posix.c
> > +++ b/qga/commands-posix.c
> > @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> > *syspath,
> >                         g_str_equal(driver, "sym53c8xx") ||
> >                         g_str_equal(driver, "virtio-pci") ||
> >                         g_str_equal(driver, "ahci") ||
> > -                       g_str_equal(driver, "nvme"))) {
> > +                       g_str_equal(driver, "nvme") ||
> > +                       g_str_equal(driver, "xhci_hcd") ||
> > +                       g_str_equal(driver, "ehci-pci"))) {
> >              break;
> >          }
> >
> > @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> > *syspath,
> >          }
> >      } else if (strcmp(driver, "nvme") == 0) {
> >          disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> > +    } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> > "xhci_hcd") == 0) {
> > +        disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
> >      } else {
> >          g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
> >          goto cleanup;
> > --
> > 2.38.1
> >
> >

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|