From nobody Thu Jul 10 07:45:35 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1674491060; cv=none; d=zohomail.com; s=zohoarc; b=PeybA/BIUOJFwGgEUaxV81i2tTUv6LZCImOHV2hrjcHBwfBburTMCW8//j0McCocQCsS/bs1kGkaPov/EbDD3+w5VWYT/3VE8pvk4QcfVmU5u2dd15ZShvAsjMAq9UnetlLrCvnBNwtqaiD5YvsorZlykxL9C+IUfyI4VzqOKHE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674491060; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fO/Se+Lf7pUJu/M6NJtHFI4xXBw3PP1KVuf4/UZcH3E=; b=AdQAjU8vcEJjrR6d2e+6yEhOKvgsCcntG86dK9xCbXt4FJePqaeZIOMW1fwGipmfVSAuqc1z9gUNeVwgdb8a5Vv86VMtslMdexDao7yPZkcQEhRZ5y8PSuFYJcHXNmVJZwv99QCsXvDLXv5LpuLY2t0QSZPtWZtZvsuI9EJHdak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1674491059902110.91834264294937; Mon, 23 Jan 2023 08:24:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJzbN-0007fV-U7; Mon, 23 Jan 2023 11:23:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJzbK-0007d3-2M; Mon, 23 Jan 2023 11:23:18 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJzbI-0003b2-Bf; Mon, 23 Jan 2023 11:23:17 -0500 Received: from localhost.localdomain (unknown [77.64.253.114]) by linux.microsoft.com (Postfix) with ESMTPSA id 1C01D20E1ABC; Mon, 23 Jan 2023 08:23:13 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1C01D20E1ABC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674490995; bh=fO/Se+Lf7pUJu/M6NJtHFI4xXBw3PP1KVuf4/UZcH3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dIr1mwx0+pn4cdWNMIshwd9gryYjHX4y21CrB154SH/Id8wZHrVsmjA1FhTTdx7eI Eu9/jg2szAL66c3iC0rfoLivRj+lC7Rj4COHNTUHTRUShccjYlr6hDX81v3bepisRM DkXSR857vcbGzNg0mDXBZ/TJL8CH1C8sLE+ME6HA= From: Evgeny Iakovlev To: qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, philmd@linaro.org Subject: [PATCH v4 3/5] hw/char/pl011: implement a reset method Date: Mon, 23 Jan 2023 17:23:02 +0100 Message-Id: <20230123162304.26254-4-eiakovlev@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230123162304.26254-1-eiakovlev@linux.microsoft.com> References: <20230123162304.26254-1-eiakovlev@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=13.77.154.182; envelope-from=eiakovlev@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -197 X-Spam_score: -19.8 X-Spam_bar: ------------------- X-Spam_report: (-19.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.microsoft.com) X-ZM-MESSAGEID: 1674491061570100001 PL011 currently lacks a reset method. Implement it. Signed-off-by: Evgeny Iakovlev Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/pl011.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 05e8bdc050..ca7537d8ed 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -427,11 +427,6 @@ static void pl011_init(Object *obj) s->clk =3D qdev_init_clock_in(DEVICE(obj), "clk", pl011_clock_update, = s, ClockUpdate); =20 - s->read_trigger =3D 1; - s->ifl =3D 0x12; - s->cr =3D 0x300; - s->flags =3D 0x90; - s->id =3D pl011_id_arm; } =20 @@ -443,11 +438,32 @@ static void pl011_realize(DeviceState *dev, Error **e= rrp) pl011_event, NULL, s, NULL, true); } =20 +static void pl011_reset(DeviceState *dev) +{ + PL011State *s =3D PL011(dev); + + s->lcr =3D 0; + s->rsr =3D 0; + s->dmacr =3D 0; + s->int_enabled =3D 0; + s->int_level =3D 0; + s->ilpr =3D 0; + s->ibrd =3D 0; + s->fbrd =3D 0; + s->read_pos =3D 0; + s->read_count =3D 0; + s->read_trigger =3D 1; + s->ifl =3D 0x12; + s->cr =3D 0x300; + s->flags =3D 0x90; +} + static void pl011_class_init(ObjectClass *oc, void *data) { DeviceClass *dc =3D DEVICE_CLASS(oc); =20 dc->realize =3D pl011_realize; + dc->reset =3D pl011_reset; dc->vmsd =3D &vmstate_pl011; device_class_set_props(dc, pl011_properties); } --=20 2.34.1