[PATCH] aspeed/sdmc: Drop unnecessary scu include

Joel Stanley posted 1 patch 2 weeks, 1 day ago
hw/misc/aspeed_sdmc.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] aspeed/sdmc: Drop unnecessary scu include
Posted by Joel Stanley 2 weeks, 1 day ago
The model includes aspeed_scu.h but doesn't appear to require it.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 hw/misc/aspeed_sdmc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index d2a3931033b3..abb272793393 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -12,7 +12,6 @@
 #include "qemu/module.h"
 #include "qemu/error-report.h"
 #include "hw/misc/aspeed_sdmc.h"
-#include "hw/misc/aspeed_scu.h"
 #include "hw/qdev-properties.h"
 #include "migration/vmstate.h"
 #include "qapi/error.h"
-- 
2.39.0
Re: [PATCH] aspeed/sdmc: Drop unnecessary scu include
Posted by Philippe Mathieu-Daudé 2 weeks, 1 day ago
On 24/1/23 07:20, Joel Stanley wrote:
> The model includes aspeed_scu.h but doesn't appear to require it.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>   hw/misc/aspeed_sdmc.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



Re: [PATCH] aspeed/sdmc: Drop unnecessary scu include
Posted by Cédric Le Goater 2 weeks, 1 day ago
On 1/24/23 07:20, Joel Stanley wrote:
> The model includes aspeed_scu.h but doesn't appear to require it.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>   hw/misc/aspeed_sdmc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
> index d2a3931033b3..abb272793393 100644
> --- a/hw/misc/aspeed_sdmc.c
> +++ b/hw/misc/aspeed_sdmc.c
> @@ -12,7 +12,6 @@
>   #include "qemu/module.h"
>   #include "qemu/error-report.h"
>   #include "hw/misc/aspeed_sdmc.h"
> -#include "hw/misc/aspeed_scu.h"
>   #include "hw/qdev-properties.h"
>   #include "migration/vmstate.h"
>   #include "qapi/error.h"