[PATCH v6 0/3] block/rbd: Add support for layered encryption

ORO@il.ibm.com posted 3 patches 1 year, 2 months ago
block/rbd.c          | 188 ++++++++++++++++++++++++++++++++++++++++---
qapi/block-core.json |  31 ++++++-
2 files changed, 205 insertions(+), 14 deletions(-)
[PATCH v6 0/3] block/rbd: Add support for layered encryption
Posted by ORO@il.ibm.com 1 year, 2 months ago
v6: nit fixes
v5: nit fixes
v4: split to multiple commits
    add support for more than just luks-any in layered encryption
    nit fixes
v3: further nit fixes suggested by @idryomov
v2: nit fixes suggested by @idryomov

Or Ozeri (3):
  block/rbd: Remove redundant stack variable passphrase_len
  block/rbd: Add luks-any encryption opening option
  block/rbd: Add support for layered encryption

 block/rbd.c          | 188 ++++++++++++++++++++++++++++++++++++++++---
 qapi/block-core.json |  31 ++++++-
 2 files changed, 205 insertions(+), 14 deletions(-)

-- 
2.25.1
Re: [PATCH v6 0/3] block/rbd: Add support for layered encryption
Posted by Ilya Dryomov 1 year, 2 months ago
On Sun, Jan 29, 2023 at 12:31 PM ORO@il.ibm.com
<oro@oro.sl.cloud9.ibm.com> wrote:
>
> v6: nit fixes
> v5: nit fixes
> v4: split to multiple commits
>     add support for more than just luks-any in layered encryption
>     nit fixes
> v3: further nit fixes suggested by @idryomov
> v2: nit fixes suggested by @idryomov
>
> Or Ozeri (3):
>   block/rbd: Remove redundant stack variable passphrase_len
>   block/rbd: Add luks-any encryption opening option
>   block/rbd: Add support for layered encryption
>
>  block/rbd.c          | 188 ++++++++++++++++++++++++++++++++++++++++---
>  qapi/block-core.json |  31 ++++++-
>  2 files changed, 205 insertions(+), 14 deletions(-)
>
> --
> 2.25.1
>

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Thanks,

                Ilya
Re: [PATCH v6 0/3] block/rbd: Add support for layered encryption
Posted by Ilya Dryomov 1 year, 2 months ago
On Mon, Jan 30, 2023 at 2:16 PM Ilya Dryomov <idryomov@gmail.com> wrote:
>
> On Sun, Jan 29, 2023 at 12:31 PM ORO@il.ibm.com
> <oro@oro.sl.cloud9.ibm.com> wrote:
> >
> > v6: nit fixes
> > v5: nit fixes
> > v4: split to multiple commits
> >     add support for more than just luks-any in layered encryption
> >     nit fixes
> > v3: further nit fixes suggested by @idryomov
> > v2: nit fixes suggested by @idryomov
> >
> > Or Ozeri (3):
> >   block/rbd: Remove redundant stack variable passphrase_len
> >   block/rbd: Add luks-any encryption opening option
> >   block/rbd: Add support for layered encryption
> >
> >  block/rbd.c          | 188 ++++++++++++++++++++++++++++++++++++++++---
> >  qapi/block-core.json |  31 ++++++-
> >  2 files changed, 205 insertions(+), 14 deletions(-)
> >
> > --
> > 2.25.1
> >
>
> Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Hi Kevin, Hanna,

What is the status of this set?  I see it on patchw and also see that
my review got picked up but it's not clear whether there is something
else to do here:

https://patchew.org/QEMU/20230129113120.722708-1-oro@oro.sl.cloud9.ibm.com/

I'm CCing Daniel who commented on previous postings of this set in case
an additional review is needed.

Thanks,

                Ilya