From nobody Thu Oct 24 00:08:23 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675160049; cv=none; d=zohomail.com; s=zohoarc; b=XjBsiZbvXTF53qLyiAA4ePALLMwfSZtKZqKbWvJADaTy43vUtTTMVvXZ0h6x2GulWzKv6JwehCfTb263BRVB0K7S2pCWXd7H4NnBaafK1u+xxovhqndSyxSgVKCSdjfudrxEQPxIA9ALx2g9iesHkUrTsxfLx66c8/p5ir8RjGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675160049; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T3lvftw6sxufJu8UjTmw+olJF55kxX9h8cxqGF98hes=; b=meTorPmI8vkImQXTFznkt70JrpuUiSEKeGzRZCpLieB+65HTnhbx9JT1mTeD9ofeLNeHSX2im0qPpWUXTr4Me6LIe41xFLyl8SPCwnh9kzvp3MYdWJv27KKmmMupPZ/2rO83/J1kxA3XUTqKugIh531VTiLacNP4KIEZL3QU1mE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167516004939921.911827288957284; Tue, 31 Jan 2023 02:14:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMnd1-0002OC-Qd; Tue, 31 Jan 2023 05:12:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMncl-0002JQ-7T for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMncg-0002UE-TF for qemu-devel@nongnu.org; Tue, 31 Jan 2023 05:12:21 -0500 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-175-oGL3GhVbNEyOZYEeJSFYpw-1; Tue, 31 Jan 2023 05:12:11 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1F3C3C02193; Tue, 31 Jan 2023 10:12:10 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7F99C15BAE; Tue, 31 Jan 2023 10:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675159937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T3lvftw6sxufJu8UjTmw+olJF55kxX9h8cxqGF98hes=; b=AByJ5ZoeaMd7vATXEzkbqURSd5JIOk7qXDWnU7/7f0x4AsOwK67Wndcgzkg50AWwXVF2l+ ueji9ON96nJ4bEnBkDIkPATK9XwO9aY30vHDZ0bNxpq31BRgHNNXry9S6CD9gFJoW3+4JT I5FAd9IAwx/OmqvgJvAd2TyDCgu9b+Y= X-MC-Unique: oGL3GhVbNEyOZYEeJSFYpw-1 From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 02/27] tests/qtest/qom-test: Stop spamming the test log Date: Tue, 31 Jan 2023 11:11:40 +0100 Message-Id: <20230131101205.1499867-3-thuth@redhat.com> In-Reply-To: <20230131101205.1499867-1-thuth@redhat.com> References: <20230131101205.1499867-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675160049999100001 We are still facing the issues that our test logs in the gitlab CI are too big (and thus cut off). A huge part is still caused by the qom-test that prints the path and name of each object it looks at by default. That's too much. Let's be silent by default, and only print the object path+name when running with V=3D2 (and the properties only with V=3D3 and higher). Message-Id: <20230118122557.1668860-1-thuth@redhat.com> Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth --- tests/qtest/qom-test.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index d380261f8f..d677f87c8e 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -14,7 +14,7 @@ #include "qemu/cutils.h" #include "libqtest.h" =20 -static bool verbose; +static int verbosity_level; =20 static void test_properties(QTestState *qts, const char *path, bool recurs= e) { @@ -24,7 +24,9 @@ static void test_properties(QTestState *qts, const char *= path, bool recurse) QListEntry *entry; GSList *children =3D NULL, *links =3D NULL; =20 - g_test_message("Obtaining properties of %s", path); + if (verbosity_level >=3D 2) { + g_test_message("Obtaining properties of %s", path); + } response =3D qtest_qmp(qts, "{ 'execute': 'qom-list'," " 'arguments': { 'path': %s } }", path); g_assert(response); @@ -51,7 +53,7 @@ static void test_properties(QTestState *qts, const char *= path, bool recurse) } } else { const char *prop =3D qdict_get_str(tuple, "name"); - if (verbose) { + if (verbosity_level >=3D 3) { g_test_message("-> %s", prop); } tmp =3D qtest_qmp(qts, @@ -109,8 +111,8 @@ int main(int argc, char **argv) { char *v_env =3D getenv("V"); =20 - if (v_env && atoi(v_env) >=3D 2) { - verbose =3D true; + if (v_env) { + verbosity_level =3D atoi(v_env); } =20 g_test_init(&argc, &argv, NULL); --=20 2.31.1