tests/tcg/s390x: Use -nostdlib for softmmu tests

[PATCH] tests/tcg/s390x: Use -nostdlib for softmmu tests

Posted by Ilya Leoshkevich 2 years, 9 months ago

The code currently uses -nostartfiles, but this does not prevent
linking with libc. On Fedora there is no cross-libc, so the linking
step fails.

Fix by using the more comprehensive -nostdlib (that's also what
probe_target_compiler() checks for as well).

Fixes: 503e549e441e ("tests/tcg/s390x: Test unaligned accesses to lowcore")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
 tests/tcg/s390x/Makefile.softmmu-target | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
index a34fa68473e..50c1b88065d 100644
--- a/tests/tcg/s390x/Makefile.softmmu-target
+++ b/tests/tcg/s390x/Makefile.softmmu-target
@@ -3,7 +3,7 @@ VPATH+=$(S390X_SRC)
 QEMU_OPTS=-action panic=exit-failure -kernel
 
 %: %.S
-	$(CC) -march=z13 -m64 -nostartfiles -static -Wl,-Ttext=0 \
+	$(CC) -march=z13 -m64 -nostdlib -static -Wl,-Ttext=0 \
 		-Wl,--build-id=none $< -o $@
 
 TESTS += unaligned-lowcore
-- 
2.39.1

Re: [PATCH] tests/tcg/s390x: Use -nostdlib for softmmu tests

Posted by Philippe Mathieu-Daudé 2 years, 8 months ago

On 31/1/23 19:20, Ilya Leoshkevich wrote:
> The code currently uses -nostartfiles, but this does not prevent
> linking with libc. On Fedora there is no cross-libc, so the linking
> step fails.
> 
> Fix by using the more comprehensive -nostdlib (that's also what
> probe_target_compiler() checks for as well).
> 
> Fixes: 503e549e441e ("tests/tcg/s390x: Test unaligned accesses to lowcore")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>   tests/tcg/s390x/Makefile.softmmu-target | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] tests/tcg/s390x: Use -nostdlib for softmmu tests

Posted by Alex Bennée 2 years, 9 months ago

Ilya Leoshkevich <iii@linux.ibm.com> writes:

> The code currently uses -nostartfiles, but this does not prevent
> linking with libc. On Fedora there is no cross-libc, so the linking
> step fails.
>
> Fix by using the more comprehensive -nostdlib (that's also what
> probe_target_compiler() checks for as well).
>
> Fixes: 503e549e441e ("tests/tcg/s390x: Test unaligned accesses to lowcore")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>  tests/tcg/s390x/Makefile.softmmu-target | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
> index a34fa68473e..50c1b88065d 100644
> --- a/tests/tcg/s390x/Makefile.softmmu-target
> +++ b/tests/tcg/s390x/Makefile.softmmu-target
> @@ -3,7 +3,7 @@ VPATH+=$(S390X_SRC)
>  QEMU_OPTS=-action panic=exit-failure -kernel
>  
>  %: %.S
> -	$(CC) -march=z13 -m64 -nostartfiles -static -Wl,-Ttext=0 \
> +	$(CC) -march=z13 -m64 -nostdlib -static -Wl,-Ttext=0 \
>  		-Wl,--build-id=none $< -o $@
>  
>  TESTS += unaligned-lowcore

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

I take it this will go via the s390x tree?

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] tests/tcg/s390x: Use -nostdlib for softmmu tests

Posted by Richard Henderson 2 years, 9 months ago

On 1/31/23 08:20, Ilya Leoshkevich wrote:
> The code currently uses -nostartfiles, but this does not prevent
> linking with libc. On Fedora there is no cross-libc, so the linking
> step fails.
> 
> Fix by using the more comprehensive -nostdlib (that's also what
> probe_target_compiler() checks for as well).
> 
> Fixes: 503e549e441e ("tests/tcg/s390x: Test unaligned accesses to lowcore")
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
>   tests/tcg/s390x/Makefile.softmmu-target | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~