From nobody Thu Apr 25 09:28:06 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1675205608; cv=pass; d=zohomail.com; s=zohoarc; b=Q+Uuo8Enz7QiLlsu6XbctB7Rkao4svMT7kcJtuTnv/3Q9Ml9+Xp7ekya//CAaKFEXdR8Qi1eF3mtghPwU+HIL4uLMVij4LEEcqkVUaDQNcq8cwJsFrPkk3AjAx+9A7dm6Fj0YqHXOfDgCGqX0zDB50rRQ+2372nTEU7eLB7QANQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675205608; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ML6cs7eQSjHyFoTbA1vwZOtdpcA9OgOwmiba5kQ3iTM=; b=ilQKQJPeqQ+ENZ3kXSfMIg/r1YYAQCb7U/IEbs2RuPXfk6HubnqeUrUhzyZGduX8xsmr3eqpXA/uF21MRpMSr28Qv1T6yOCIV8MgjC7pL2qLxZsNZ05L/A/zuOUswmHC7bYCBgf43gOWLt2E+PxxQf1nmAl0z44AAUgV3vEJH40= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675205608654820.8834754067238; Tue, 31 Jan 2023 14:53:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMzUN-0002GG-9c; Tue, 31 Jan 2023 17:52:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMzUM-0002G3-6Z for qemu-devel@nongnu.org; Tue, 31 Jan 2023 17:52:30 -0500 Received: from mail-dm6nam10on20631.outbound.protection.outlook.com ([2a01:111:f400:7e88::631] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMzUJ-0002gO-0v for qemu-devel@nongnu.org; Tue, 31 Jan 2023 17:52:29 -0500 Received: from DM6PR03CA0043.namprd03.prod.outlook.com (2603:10b6:5:100::20) by CH2PR12MB4924.namprd12.prod.outlook.com (2603:10b6:610:6b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 22:52:18 +0000 Received: from DM6NAM11FT081.eop-nam11.prod.protection.outlook.com (2603:10b6:5:100:cafe::91) by DM6PR03CA0043.outlook.office365.com (2603:10b6:5:100::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Tue, 31 Jan 2023 22:52:18 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT081.mail.protection.outlook.com (10.13.172.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6043.22 via Frontend Transport; Tue, 31 Jan 2023 22:52:17 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 31 Jan 2023 16:52:17 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 31 Jan 2023 16:52:17 -0600 Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 31 Jan 2023 16:52:16 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX79zuo1zxiVfTrZpwDba+Frk8MttNAnD09x4mWSx1PcnTbctu8cdkvNFXLNZ0n0K9a94klLX31GKCPgrJC/BLue+Fy62SxKaBdNbrK7jWpMEE2DqgrO3nzBJ10x/n81PYCVqH+C45+XiySoEBKLzFs0jgLNcb3GO++zZtiSYE4oDgH6ZCCkxbgUzj3FKCV/X9eV2YoJ+JSvli/IfMvLMnUe6NBS/IAC1AqZDNbyIz4C1lTophh68doSqSX5izLHrFazZL7lIXNYBXNAeYulX2VfqXwhBCjp+hkJH2UeCOe7Ys3+f2//WUwpYsA71nNItyJ9YWBhJ/rH2YH0ivZaiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ML6cs7eQSjHyFoTbA1vwZOtdpcA9OgOwmiba5kQ3iTM=; b=eMC9FtGmgTvg6Q/jI/19HDsEIERtbYfXBlfabidZ1mqusIttzUbymxsR0u2CgDGv96Sne07w8wyTgSTaAlFt4wjwyqFuqlYKXQPsWszixYRiUYDQZuVBLqEo79Osht3kXuU2bkF1s1tIHaXXrDuOtCL5tS08VJpAYHdurSmJRkaFX30T0qWjhVzsBwn/Zln9KykTjAb1AkKsGR0nBobfbEO9ORJ4JM/vyV39gd5PYnpev1hsoFSi5s+xRwt5wgeWsgy4dJz1l48YYffjc71jK/kXHqV9esbUtchrBtavt2FjUcPNAaXEvP6ru2tYbuAquvx2kRdXHVTkOkrjideyNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ML6cs7eQSjHyFoTbA1vwZOtdpcA9OgOwmiba5kQ3iTM=; b=WXfhAZE0/zoFH2j+/xCGXxNanlwaMMclZheYLmdoYfJqAywNNOFzVRWKxiCjoOiKSjaFeC7h0IvGFHpCR+wFwLcfrom7HAewtJkjZXEOkqHg7AbxdsCjCOw2hdTnywIhXKrgQenzfcQRc/3NRo5KotjAno8butAaz2AT5eywGCs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Vikram Garhwal To: CC: , , , , Stefano Stabellini , Anthony Perard , "Paul Durrant" Subject: [QEMU][PATCH v5 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Date: Tue, 31 Jan 2023 14:51:45 -0800 Message-ID: <20230131225149.14764-7-vikram.garhwal@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230131225149.14764-1-vikram.garhwal@amd.com> References: <20230131225149.14764-1-vikram.garhwal@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT081:EE_|CH2PR12MB4924:EE_ X-MS-Office365-Filtering-Correlation-Id: 72553e62-25a8-4d7a-4d3a-08db03ddcdf2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aDeS878/CJIXyQhsw3x3qt3R67/eDkg6cAHgF6/Cm/0mGhCkhQ45wZbamRZ2K0w82Xc3U/DTn67cSByi2xY6t9w1WzyqaycFXjQJYS3trgpO2l1aoWK2/cGnOSshD3drsWunKDGYHbQEFX1RpV9E1M1T6lxE9xCBd7NB4lv6Pj+24CX4xCU1M3llKbJ68sqVjZlzGbYUmk2A3T1ZZ+ux8pB7zXbuD5lNqjbAmqIddW2MZ9s6Qeo56nQQ8j+svpGDjww176CBmRZ897LlzDuKTeVlp5vyyGaCNxTl1NAbVggtk/fbVRg+0kZvpAvqxXbFn2gK+yht8bhtdClrNXhSdNUSk/1iqRtAH3w/lAV7JcxdK8J0Akku7xAs8iNBBWQ/pavaG023DljnXarlWECrP4+8cRkiZmWCRa5MPfA1YtG73xYU2FykLZTsx1r+009AVKzJ9BKVx7SLQoXqtU6VBzxtlFKc/WnSkX9CS0hvEjwMSOi/+Z1XHy9hA/oNzFwzYskn+Gbvzl+XCaKHyqpvxfukKb2aE4tDPMrDWb2ho3kTNpGFP7/nK8tY5LepkS/JppVqSIOXhFDnNAOs9e8N/509wqkP1SUXH6VBtuZpMZ5R1CKwCP62pMVQr0uUmagfXLKdEelwLkV6Rsts0HjPRTR71U76DLOHpgpygUvrfuhYfAWaEcySsR5BQJM2DepCtVwN7qp/dN8yibfbYTpkXDXrUt3+BN1Oy6gIVTUSsEw= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199018)(36840700001)(40470700004)(46966006)(6666004)(41300700001)(36756003)(6916009)(70206006)(54906003)(316002)(8676002)(82310400005)(4326008)(8936002)(5660300002)(70586007)(86362001)(356005)(81166007)(82740400003)(36860700001)(186003)(1076003)(26005)(336012)(426003)(40480700001)(2906002)(40460700003)(44832011)(478600001)(47076005)(83380400001)(2616005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 22:52:17.9984 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72553e62-25a8-4d7a-4d3a-08db03ddcdf2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT081.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4924 Received-SPF: softfail client-ip=2a01:111:f400:7e88::631; envelope-from=vikram.garhwal@amd.com; helo=NAM10-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1675205609192100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function xen_do_ioreq_register(). Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 53 ++++++++++++++++++++++++++++------------- 1 file changed, 36 insertions(+), 17 deletions(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c index c2e1e08124..5e3c7b073f 100644 --- a/hw/xen/xen-hvm-common.c +++ b/hw/xen/xen-hvm-common.c @@ -781,25 +781,12 @@ err: exit(1); } =20 -void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, - MemoryListener xen_memory_listener) +static void xen_do_ioreq_register(XenIOState *state, + unsigned int max_cpus, + MemoryListener xen_memory_liste= ner) { int i, rc; =20 - state->xce_handle =3D xenevtchn_open(NULL, 0); - if (state->xce_handle =3D=3D NULL) { - perror("xen: event channel open"); - goto err; - } - - state->xenstore =3D xs_daemon_open(); - if (state->xenstore =3D=3D NULL) { - perror("xen: xenstore open"); - goto err; - } - - xen_create_ioreq_server(xen_domid, &state->ioservid); - state->exit.notify =3D xen_exit_notifier; qemu_add_exit_notifier(&state->exit); =20 @@ -863,12 +850,44 @@ void xen_register_ioreq(XenIOState *state, unsigned i= nt max_cpus, QLIST_INIT(&state->dev_list); device_listener_register(&state->device_listener); =20 + return; + +err: + error_report("xen hardware virtual machine initialisation failed"); + exit(1); +} + +void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, + MemoryListener xen_memory_listener) +{ + int rc; + + state->xce_handle =3D xenevtchn_open(NULL, 0); + if (state->xce_handle =3D=3D NULL) { + perror("xen: event channel open"); + goto err; + } + + state->xenstore =3D xs_daemon_open(); + if (state->xenstore =3D=3D NULL) { + perror("xen: xenstore open"); + goto err; + } + + rc =3D xen_create_ioreq_server(xen_domid, &state->ioservid); + if (!rc) { + xen_do_ioreq_register(state, max_cpus, xen_memory_listener); + } else { + warn_report("xen: failed to create ioreq server"); + } + xen_bus_init(); =20 xen_register_backend(state); =20 return; + err: - error_report("xen hardware virtual machine initialisation failed"); + error_report("xen hardware virtual machine backend registration failed= "); exit(1); } --=20 2.17.0