From nobody Mon Sep 16 19:07:11 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1675222730; cv=none; d=zohomail.com; s=zohoarc; b=aqUzJXR/JpIUJLhjaal74HVeuZFruODqoejxeHGR4hgg2d+w4/0O10uVl7l5kTvn6KHd0dvZou31CeR8fw1XG6N5CWihT2bw0RmJ0POu3gvRp49zL+J73M2xr6YDERlPNMOv69bdsQ6Bw2W1ueN+/qLh2YvCFHzStJ6ZkLoXAFI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675222730; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=5140iHkZNuZn3I2k8biDJLxaiQwsOPdwZlAn0pvvLx0=; b=eSmTuqMrINqpl3bFQVn6haEAIj2Satq9I9yKxCdeeZOt2thPQkTABUF2gh2J8ixBUNo8JewiDhIQWvSOdK4pwvf6MUwOa7QBdKqrb9gwcGDH+FHbaFfcRB7NkUk0c61hX/PPydCX36G59Nn0U9T4JWHacobMgsynHiUC7NUzy7Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167522273036052.11376083498453; Tue, 31 Jan 2023 19:38:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pN3w0-0000hC-Cx; Tue, 31 Jan 2023 22:37:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pN3vp-0008CX-OA for qemu-devel@nongnu.org; Tue, 31 Jan 2023 22:37:10 -0500 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pN3vo-0000cS-0V for qemu-devel@nongnu.org; Tue, 31 Jan 2023 22:37:09 -0500 Received: by mail-pj1-x102a.google.com with SMTP id l4-20020a17090a850400b0023013402671so720828pjn.5 for ; Tue, 31 Jan 2023 19:37:07 -0800 (PST) Received: from alarm.flets-east.jp ([2400:4050:a840:1e00:4457:c267:5e09:481b]) by smtp.gmail.com with ESMTPSA id x15-20020a170902ec8f00b001968b529c98sm4185557plg.128.2023.01.31.19.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 19:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5140iHkZNuZn3I2k8biDJLxaiQwsOPdwZlAn0pvvLx0=; b=JRryQ5dAfQ6FnJmKIJg1YrIOiE6WIf1GTs6L4ILTl7af5+BE9b3fKh2r0qARGGpmBb dQJyuhLVX/pYoJk3SzJkddEj/l92+k01qS1Thb8TxIKZCIvFz+XtdVRW3Khnmk1jntpQ +hOkeVSohklQjuH6m8FlbIM96RQBKqTisGDTg4RZvY1Aprwg9TgDVMtbGWDH/40+Aipi o5qGQzZIQtivheJNdLymGCKF8ZS/pWenq4uSA8i92CB5EQnAOAdVbMHZi4Q4V8yjBf4r yxSMvYptaHLP8bV7MnBgIvfsl4lNHkvBrZpedaGmjhcQE8MRnWtvPcNnPCJ1xRh4NIea +m2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5140iHkZNuZn3I2k8biDJLxaiQwsOPdwZlAn0pvvLx0=; b=xhQcfn/O0vwv+Os5wH81Sy6dHsiPqNzSmjwuXOFyDev+pwvA6V6VCAAkua3HNUY4mY +oCOZyTvHlXocDGAKxV9lOYARq1Wl6wtUHCnurBQ1TmXdwexqHFhk3l0aXTBjTl1OLBT FMYZxAO82MRvFiC9cW13h8EgZCX82Wd4nAkdBihx8X3g2dtTz8Ymcmt6/tVjG8zG36Yj pRPJTXR5pcyaDY+ktgGTRZDVtOHFHu+e/+N4AEWctGc4l2wfKfAlUxqc1OY5xz1o5UIe ZrGUAj7Lb0bugQxEaVUTdii32Yxw9h8Dt5c1GCV2ziGD9+YEHHWC7dOO6vOlx4sZJ74W IIdg== X-Gm-Message-State: AO0yUKXWYbLZ2CukX4ZAxid7A1taIG8udyVU4O023udbQmO7CRE+h4Zx kQb5FIpKn8Z2esCs97rqNWuybw== X-Google-Smtp-Source: AK7set9nnmuS2niuuw0UV6kLNYIf91TnlL+tEwLXbGqjMvz3VNcmQ0pq63V0Cty4PG9sLVLTE9RKpA== X-Received: by 2002:a17:903:2309:b0:196:7a90:5f5a with SMTP id d9-20020a170903230900b001967a905f5amr1996160plh.26.1675222626358; Tue, 31 Jan 2023 19:37:06 -0800 (PST) From: Akihiko Odaki To: Cc: Jason Wang , Dmitry Fleytman , Thomas Huth , Laurent Vivier , Paolo Bonzini , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, "Michael S . Tsirkin" , Yan Vugenfirer , Yuri Benditovich , Sriram Yagnaraman , Alexander Bulekov , Akihiko Odaki Subject: [PATCH v5 25/29] hw/net/net_tx_pkt: Check the payload length Date: Wed, 1 Feb 2023 12:35:35 +0900 Message-Id: <20230201033539.30049-26-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230201033539.30049-1-akihiko.odaki@daynix.com> References: <20230201033539.30049-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::102a; envelope-from=akihiko.odaki@daynix.com; helo=mail-pj1-x102a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1675222730592100002 Content-Type: text/plain; charset="utf-8" Check the payload length if checksumming to ensure the payload contains the space for the resulting value. This bug was found by Alexander Bulekov with the fuzzer: https://patchew.org/QEMU/20230129053316.1071513-1-alxndr@bu.edu/ The fixed test case is: fuzz/crash_6aeaa33e7211ecd603726c53e834df4c6d1e08bc Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices") Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c index 4a35e8429d..986a3adfe9 100644 --- a/hw/net/net_tx_pkt.c +++ b/hw/net/net_tx_pkt.c @@ -342,11 +342,17 @@ bool net_tx_pkt_build_vheader(struct NetTxPkt *pkt, b= ool tso_enable, if (csum_enable) { switch (pkt->l4proto) { case IP_PROTO_TCP: + if (pkt->payload_len < sizeof(struct tcp_hdr)) { + return false; + } pkt->virt_hdr.flags =3D VIRTIO_NET_HDR_F_NEEDS_CSUM; pkt->virt_hdr.csum_start =3D pkt->hdr_len; pkt->virt_hdr.csum_offset =3D offsetof(struct tcp_hdr, th_sum); break; case IP_PROTO_UDP: + if (pkt->payload_len < sizeof(struct udp_hdr)) { + return false; + } pkt->virt_hdr.flags =3D VIRTIO_NET_HDR_F_NEEDS_CSUM; pkt->virt_hdr.csum_start =3D pkt->hdr_len; pkt->virt_hdr.csum_offset =3D offsetof(struct udp_hdr, uh_sum); --=20 2.39.1