On Thu, 2 Feb 2023 14:38:17 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> This commit was created with scripts/clean-includes.
>
> All .c should include qemu/osdep.h first. The script performs three
> related cleanups:
>
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c already includes
> it. Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
> Drop these, too.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> include/hw/cxl/cxl_component.h | 2 --
> include/hw/cxl/cxl_host.h | 1 -
> include/hw/cxl/cxl_pci.h | 1 -
> 3 files changed, 4 deletions(-)
>
> diff --git a/include/hw/cxl/cxl_component.h b/include/hw/cxl/cxl_component.h
> index 5dca21e95b..692d7a5507 100644
> --- a/include/hw/cxl/cxl_component.h
> +++ b/include/hw/cxl/cxl_component.h
> @@ -15,9 +15,7 @@
> #define CXL2_COMPONENT_CM_REGION_SIZE 0x1000
> #define CXL2_COMPONENT_BLOCK_SIZE 0x10000
>
> -#include "qemu/compiler.h"
> #include "qemu/range.h"
> -#include "qemu/typedefs.h"
> #include "hw/cxl/cxl_cdat.h"
> #include "hw/register.h"
> #include "qapi/error.h"
> diff --git a/include/hw/cxl/cxl_host.h b/include/hw/cxl/cxl_host.h
> index a1b662ce40..c9bc9c7c50 100644
> --- a/include/hw/cxl/cxl_host.h
> +++ b/include/hw/cxl/cxl_host.h
> @@ -7,7 +7,6 @@
> * COPYING file in the top-level directory.
> */
>
> -#include "qemu/osdep.h"
> #include "hw/cxl/cxl.h"
> #include "hw/boards.h"
>
> diff --git a/include/hw/cxl/cxl_pci.h b/include/hw/cxl/cxl_pci.h
> index 01e15ed5b4..407be95b9e 100644
> --- a/include/hw/cxl/cxl_pci.h
> +++ b/include/hw/cxl/cxl_pci.h
> @@ -10,7 +10,6 @@
> #ifndef CXL_PCI_H
> #define CXL_PCI_H
>
> -#include "qemu/compiler.h"
>
> #define CXL_VENDOR_ID 0x1e98
>