From nobody Tue May 13 12:01:04 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675414014; cv=none; d=zohomail.com; s=zohoarc; b=GTO1S1C+RBFHlARsdWQZBF3CtCCzCJ09LXfKsFUK3VAIzcw0j/m9c2bypd3TShglmpIGz5D5LfI0W1mCKSqE9LNMnfdqDAltNo4t+FZ/6cNJ9M7gGNxSAiDogHHMCGBGg6wiuZXmAjvLKS9NsFDvcL/+qw3rJsEzG+qEt7nveIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675414014; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G0USBJ7ffRWQGZBjQ0Slni9sfWQtKX+3McUxq07WeV0=; b=VQtrAGDOR9KISicEP6oIldIncvluXJWOyre+pJ4lGie63aHSE3wWp9oVWc7zRMB+4oBcPRbAN6tdYCbfaAheYHGohOMUMqyLhKtViJKunxTPmzbhGtG0X3WguYr2erFPk+zHvRj85NVg9mwtoO2bwr+R48hnbMrJcI7iRb/4LMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1675414014836160.97771651094104; Fri, 3 Feb 2023 00:46:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNri9-0008VU-Ny; Fri, 03 Feb 2023 03:46:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNrhs-0008LX-1s for qemu-devel@nongnu.org; Fri, 03 Feb 2023 03:46:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNrhl-0007UC-UA for qemu-devel@nongnu.org; Fri, 03 Feb 2023 03:46:03 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-EsUYLqrdM_qA6MXonSgVqA-1; Fri, 03 Feb 2023 03:45:52 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71067100F906; Fri, 3 Feb 2023 08:45:52 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5074E492C3C; Fri, 3 Feb 2023 08:45:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C18F221E6A28; Fri, 3 Feb 2023 09:45:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675413956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G0USBJ7ffRWQGZBjQ0Slni9sfWQtKX+3McUxq07WeV0=; b=PyOh9rvVVVdh2tbAPgmUN5R2m0E5Xe5MN5PLQPHOxjOxSnZ3tIbcXOnsZx+5AXE46u5WS+ iElal7hNy4A6Wi/PYAFKMmkJ293J3EdJnYcAKvjiKA2ewA1TNXw7ULX1OCaXFQ8WN5E++z 6TfdnmjBndocHdxC2RZY4xC2aO3zb+w= X-MC-Unique: EsUYLqrdM_qA6MXonSgVqA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PULL 08/35] hmp: Drop redundant argument check from add_completion_option() Date: Fri, 3 Feb 2023 09:45:22 +0100 Message-Id: <20230203084549.2622302-9-armbru@redhat.com> In-Reply-To: <20230203084549.2622302-1-armbru@redhat.com> References: <20230203084549.2622302-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675414015941100001 Content-Type: text/plain; charset="utf-8" No need to check for null arguments, no caller passes them. Signed-off-by: Markus Armbruster Message-Id: <20230124121946.1139465-6-armbru@redhat.com> --- monitor/misc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/monitor/misc.c b/monitor/misc.c index c18a713d9c..d58a81c452 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -1353,9 +1353,6 @@ int get_monitor_def(Monitor *mon, int64_t *pval, cons= t char *name) static void add_completion_option(ReadLineState *rs, const char *str, const char *option) { - if (!str || !option) { - return; - } if (!strncmp(option, str, strlen(str))) { readline_add_completion(rs, option); } --=20 2.39.0