[PATCH v10 02/12] parallels: Fix high_off calculation in parallels_co_check()

Alexander Ivanov posted 12 patches 1 year, 3 months ago
There is a newer version of this series
[PATCH v10 02/12] parallels: Fix high_off calculation in parallels_co_check()
Posted by Alexander Ivanov 1 year, 3 months ago
Don't let high_off be more than the file size even if we don't fix the
image.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
 block/parallels.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index 4af68adc61..436b36bbd9 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -460,12 +460,12 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
                     fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
             res->corruptions++;
             if (fix & BDRV_FIX_ERRORS) {
-                prev_off = 0;
                 s->bat_bitmap[i] = 0;
                 res->corruptions_fixed++;
                 flush_bat = true;
-                continue;
             }
+            prev_off = 0;
+            continue;
         }
 
         res->bfi.allocated_clusters++;
-- 
2.34.1
Re: [PATCH v10 02/12] parallels: Fix high_off calculation in parallels_co_check()
Posted by Vladimir Sementsov-Ogievskiy 1 year, 3 months ago
On 03.02.23 12:18, Alexander Ivanov wrote:
> Don't let high_off be more than the file size even if we don't fix the
> image.
> 
> Signed-off-by: Alexander Ivanov<alexander.ivanov@virtuozzo.com>
> Reviewed-by: Denis V. Lunev<den@openvz.org>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

-- 
Best regards,
Vladimir