[v2] hw: Use QOM alias properties and few QOM/QDev cleanups

[PATCH v2 00/15] hw: Use QOM alias properties and few QOM/QDev cleanups

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

Since v1:
- Addressed Markus & Zoltan review comments
- Introduce/use qdev_unrealize_and_unref()

These patches are extracted from a QOM/QDev refactor series,
so they are preliminary cleanups noticed while working on it:

- Use correct type when calling qdev_prop_set_xxx()
- Unify some qdev properties in MIPS models
- Replace intermediate properties by link properties
- Remove DEFINE_PROP_DMAADDR() macro which is used one time
- Use qdev_realize_and_unref() instead of open-coding it

Philippe Mathieu-Daudé (15):
  hw/pci/pcie_sriov: Replace fprintf(error_pretty) -> 
    warn_reportf_err()
  hw/qdev: Introduce qdev_unrealize_and_unref()
  linux-user/syscall: Do not open-code qdev_unrealize_and_unref()
  hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref()
  hw/i386/sgx: Do not open-code qdev_realize_and_unref()
  hw/ppc/sam460ex: Correctly set MAL properties
  hw/arm/nrf51: Alias 'flash-size' QOM property in SoC object
  hw/arm/fsl-imx: Alias 'phy-num' QOM property in SoC object
  hw/usb/hcd-ohci: Include missing 'sysbus.h' header
  hw/display/sm501: Embed OHCI QOM child in chipset
  hw/display/sm501: Alias 'dma-offset' QOM property in chipset object
  hw/display/sm501: Unify common QOM properties
  hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'
  hw/mips: Declare all length properties as unsigned
  hw/mips/itu: Pass SAAR using QOM link property

 hw/arm/fsl-imx25.c           |  3 +--
 hw/arm/fsl-imx6.c            |  3 +--
 hw/arm/fsl-imx6ul.c          |  8 ++++----
 hw/arm/fsl-imx7.c            | 12 ++++++------
 hw/arm/microbit.c            |  5 ++++-
 hw/arm/nrf51_soc.c           | 10 +---------
 hw/core/qdev.c               |  9 +++++++++
 hw/display/sm501.c           | 33 ++++++++++++++-------------------
 hw/i386/sgx.c                | 14 ++++++--------
 hw/intc/mips_gic.c           |  4 ++--
 hw/mips/boston.c             |  2 +-
 hw/mips/cps.c                | 35 ++++++++++++-----------------------
 hw/mips/malta.c              |  2 +-
 hw/misc/mips_cmgcr.c         |  2 +-
 hw/misc/mips_itu.c           | 30 ++++++++++++++++++++----------
 hw/nvram/nrf51_nvm.c         |  6 +++++-
 hw/pci/pcie_sriov.c          | 11 ++++-------
 hw/ppc/sam460ex.c            |  4 ++--
 hw/sh4/r2d.c                 |  2 +-
 hw/usb/hcd-ohci-pci.c        |  1 -
 hw/usb/hcd-ohci.c            |  3 +--
 hw/usb/hcd-ohci.h            |  1 +
 include/hw/arm/fsl-imx25.h   |  1 -
 include/hw/arm/fsl-imx6.h    |  1 -
 include/hw/arm/fsl-imx6ul.h  |  2 --
 include/hw/arm/fsl-imx7.h    |  1 -
 include/hw/arm/nrf51_soc.h   |  1 -
 include/hw/intc/mips_gic.h   |  4 ++--
 include/hw/misc/mips_cmgcr.h |  2 +-
 include/hw/misc/mips_itu.h   |  9 ++++-----
 include/hw/qdev-core.h       | 20 ++++++++++++++++++++
 include/hw/qdev-dma.h        | 16 ----------------
 linux-user/syscall.c         |  3 +--
 33 files changed, 125 insertions(+), 135 deletions(-)
 delete mode 100644 include/hw/qdev-dma.h

-- 
2.38.1

Re: [PATCH v2 00/15] hw: Use QOM alias properties and few QOM/QDev cleanups

Posted by Philippe Mathieu-Daudé 7 months, 1 week ago

On 3/2/23 15:55, Philippe Mathieu-Daudé wrote:
> Since v1:
> - Addressed Markus & Zoltan review comments
> - Introduce/use qdev_unrealize_and_unref()
> 
> These patches are extracted from a QOM/QDev refactor series,
> so they are preliminary cleanups noticed while working on it:
> 
> - Use correct type when calling qdev_prop_set_xxx()
> - Unify some qdev properties in MIPS models
> - Replace intermediate properties by link properties
> - Remove DEFINE_PROP_DMAADDR() macro which is used one time
> - Use qdev_realize_and_unref() instead of open-coding it
> 
> Philippe Mathieu-Daudé (15):
>    hw/pci/pcie_sriov: Replace fprintf(error_pretty) ->
>      warn_reportf_err()
>    hw/qdev: Introduce qdev_unrealize_and_unref()
>    linux-user/syscall: Do not open-code qdev_unrealize_and_unref()
>    hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref()
>    hw/i386/sgx: Do not open-code qdev_realize_and_unref()
>    hw/ppc/sam460ex: Correctly set MAL properties
>    hw/arm/nrf51: Alias 'flash-size' QOM property in SoC object
>    hw/arm/fsl-imx: Alias 'phy-num' QOM property in SoC object
>    hw/usb/hcd-ohci: Include missing 'sysbus.h' header
>    hw/display/sm501: Embed OHCI QOM child in chipset
>    hw/display/sm501: Alias 'dma-offset' QOM property in chipset object
>    hw/display/sm501: Unify common QOM properties
>    hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'
>    hw/mips: Declare all length properties as unsigned
>    hw/mips/itu: Pass SAAR using QOM link property

Ping for review?

Re: [PATCH v2 00/15] hw: Use QOM alias properties and few QOM/QDev cleanups

Posted by Markus Armbruster 7 months ago

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 3/2/23 15:55, Philippe Mathieu-Daudé wrote:
>> Since v1:
>> - Addressed Markus & Zoltan review comments
>> - Introduce/use qdev_unrealize_and_unref()
>> These patches are extracted from a QOM/QDev refactor series,
>> so they are preliminary cleanups noticed while working on it:
>> - Use correct type when calling qdev_prop_set_xxx()
>> - Unify some qdev properties in MIPS models
>> - Replace intermediate properties by link properties
>> - Remove DEFINE_PROP_DMAADDR() macro which is used one time
>> - Use qdev_realize_and_unref() instead of open-coding it
>> Philippe Mathieu-Daudé (15):
>>    hw/pci/pcie_sriov: Replace fprintf(error_pretty) ->
>>      warn_reportf_err()
>>    hw/qdev: Introduce qdev_unrealize_and_unref()
>>    linux-user/syscall: Do not open-code qdev_unrealize_and_unref()
>>    hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref()
>>    hw/i386/sgx: Do not open-code qdev_realize_and_unref()
>>    hw/ppc/sam460ex: Correctly set MAL properties
>>    hw/arm/nrf51: Alias 'flash-size' QOM property in SoC object
>>    hw/arm/fsl-imx: Alias 'phy-num' QOM property in SoC object
>>    hw/usb/hcd-ohci: Include missing 'sysbus.h' header
>>    hw/display/sm501: Embed OHCI QOM child in chipset
>>    hw/display/sm501: Alias 'dma-offset' QOM property in chipset object
>>    hw/display/sm501: Unify common QOM properties
>>    hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'
>>    hw/mips: Declare all length properties as unsigned
>>    hw/mips/itu: Pass SAAR using QOM link property
>
> Ping for review?

Needs a rebase.  I reviewed some all the same.  If you want more from me
before you respin, let me know.