From nobody Tue Apr 23 21:52:49 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675444571; cv=none; d=zohomail.com; s=zohoarc; b=W93XtkGsRUVw6pfkI5xZ1wMhoeeuFtnIS8B07Io3HyRvvSqmZUV9GQzgRrWNBPwH0DNnH8qtKM71y3pBg/c4rri9rVyG3c2gOHnyrgsmycnp8iqpzXfJif0ok7XOwmEOxttCXwRVyKujUdoiFh9Q8Q5YpFygt4JOo7tJODYOvSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675444571; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5i389KyvIdvqVOsoPuC6m23mDusUiOnk0MRlqE5W7TU=; b=eRpFPBCNOA1YqLWDH+rHMNpRMmvDuBJb92k85+FgZojAIIyAPEcSec7Y92fnNMrGssL4k+TKqp4WN6QPRWCZRikV15glvJC49pGsN8lKtG5V8FBiAu8+mFxhbX64pdz6b2WnoSBCysLJ7ZkLHKvNSr1RG7vHPy2rplQ6N4Ji2OI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167544457173019.74221161501805; Fri, 3 Feb 2023 09:16:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNzeo-00061y-HK; Fri, 03 Feb 2023 12:15:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNzen-00061q-BL for qemu-devel@nongnu.org; Fri, 03 Feb 2023 12:15:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNzel-0003PL-Gm for qemu-devel@nongnu.org; Fri, 03 Feb 2023 12:15:25 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-657-irWonZiDN3CXGaYC87pJKA-1; Fri, 03 Feb 2023 12:15:18 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 00BAF802314; Fri, 3 Feb 2023 17:15:18 +0000 (UTC) Received: from laptop.redhat.com (unknown [10.39.192.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D506403D0C1; Fri, 3 Feb 2023 17:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675444521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5i389KyvIdvqVOsoPuC6m23mDusUiOnk0MRlqE5W7TU=; b=J+cAuc9T14VsdACFcBXqWHVkjqMbIYZGc4IkFYZKo46NluE8tDeIQFozi0qrW2kiVxtAVQ EOHBIEnnlrn8eEg6i4BS+ZrrnHvIA2HpHMtULRMXD7JvTyr/3PstotpUGdx8qvd4Ie1x1N FUOtEXpU+EzxLLXAnh/gxUqrmm0+tp0= X-MC-Unique: irWonZiDN3CXGaYC87pJKA-1 From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, richard.henderson@linaro.org, peter.maydell@linaro.org, pbonzini@redhat.com, qemu-devel@nongnu.org Cc: iii@linux.ibm.com Subject: [PATCH] accel/tcg: test CPUJumpCache in tb_jmp_cache_clear_page() Date: Fri, 3 Feb 2023 18:15:10 +0100 Message-Id: <20230203171510.2867451-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675444572360100001 Content-Type: text/plain; charset="utf-8" After commit 4e4fa6c12d ("accel/tcg: Complete cpu initialization before registration"), it looks the CPUJumpCache handle can be NULL. This causes a SIGSEV when running debug-wp-migration kvm unit test. At the first place it should be clarified why this TCG code is called with KVM acceleration. This may hide another bug. Fixes: 4e4fa6c12d ("accel/tcg: Complete cpu initialization before registrat= ion") Signed-off-by: Eric Auger --- accel/tcg/cputlb.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 4e040a1cb9..ac0245ee6c 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -103,6 +103,10 @@ static void tb_jmp_cache_clear_page(CPUState *cpu, tar= get_ulong page_addr) int i, i0 =3D tb_jmp_cache_hash_page(page_addr); CPUJumpCache *jc =3D cpu->tb_jmp_cache; =20 + if (!jc) { + return; + } + for (i =3D 0; i < TB_JMP_PAGE_SIZE; i++) { qatomic_set(&jc->array[i0 + i].tb, NULL); } --=20 2.37.3