From nobody Wed May 8 22:53:43 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1676977666; cv=none; d=zohomail.com; s=zohoarc; b=fntkYxxniQj7s1gGkuZ6mZi2BWBHihAxfXhicj93no5X3pDNncdZJZ5AdKSgOVbkdeRA3t7b0RgPnqKdKrZ67mBqmPcJOl2o4DWuF++oQskL+dwNM0PgLIE+cpjokiXMdB9FbH7Y4aHNZ/6oXMuLhVZ/c5L9JpvJHOnwpvbDsM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676977666; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=H/7hifj/TdQErbbFrIHWXuABFcNzRKLymVMeIp6GJ6Y=; b=JpfZauF4+aYMwvO2zpUx1otqUAvTK2MnJ8gDXtllcpwVdxwytsS/bFcQmsZXHc8GRHvQjT5DoWes43xvSlWfzXdzU2JvaoAXVjp65By8MsIvvcYDxQEa8Mei9rx2f+01RIk0YvtwNUWJOXDoH/pO6zWe1gd/psKovwhxj4YxVrI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676977666870704.404682654778; Tue, 21 Feb 2023 03:07:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUQU6-0006zQ-Vl; Tue, 21 Feb 2023 06:06:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUQU2-0006z7-UT; Tue, 21 Feb 2023 06:06:55 -0500 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUQU0-00070E-UW; Tue, 21 Feb 2023 06:06:54 -0500 Received: by mail-qt1-x834.google.com with SMTP id h19so1139512qtk.7; Tue, 21 Feb 2023 03:06:51 -0800 (PST) Received: from debian.hsd1.ma.comcast.net ([2601:182:cc00:77b0::675]) by smtp.gmail.com with ESMTPSA id q65-20020ae9dc44000000b0073bb50640d8sm7423871qkf.71.2023.02.21.03.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 03:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=H/7hifj/TdQErbbFrIHWXuABFcNzRKLymVMeIp6GJ6Y=; b=We461EPJApD0WYFZm0Pkot1O9xzonXG/AFtJHl/iWetFJOWVXl0WDfLKV0rPOk2vg2 SZQ69wpa9O8LiuXe23awPvU6xNypc3IXy5FbHD30TOzU7JIs732EPpH7QqjjgC/gIXdq Hpitce0fU9OWWAjg+EizyHL1/HJpLJY0Q67pYi9JNqqeMOOJR9sg5eulWhHlBD1eyyzO tskIZfGS2mTfWSHnBAdiY2Q49DmxSEPie7DtgXafdP90akfDjybtCglsmsgiFRVU4Nvu KyvNxGII13V/sjUXyo97OVAn4CC+hyShwsKWVNAnkVznjkV23wpJNF3p21+1Gsom8NAD nwKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H/7hifj/TdQErbbFrIHWXuABFcNzRKLymVMeIp6GJ6Y=; b=rDHCwz6nV5oMbm2NKeRo/uN29Lrxl0Q6qRocraiUUynr7srk8+wzE1CkPz087UStrn on3kG++Gk2kJPLZN4Pqn2mcdaUniBJ86+ltvxd+gjI4nfyqK5rEixnXQWpCk+0Y5bxud 1vpQN0CFhO8eyIRe8uNlGqwI7W3iLpbUo+OYPyRHzqjRpXQcRsikzBs2JZ+EYjaGU04u n5MLDU7zVg3VuXo4ZxGT5s+OXD/CZrjzL4UPex2ncMIgfZZ57R/QoHm2zGEN6JbxLeEh cs9/EmL2nQnV3B/95STuYzloZFQv8f+BwU0VzMBRBYmRRxEC/xx0AY62l/e1i2+QKW47 US3A== X-Gm-Message-State: AO0yUKVWy4UdLxk8qW7XkTlAcefRjOpOQgg43+ccKqE/TTbyC7HFfXkN RMuwtq96xWiNqZ5tX9MBoR4IWTnbi0Hlsw== X-Google-Smtp-Source: AK7set9AR23O2xW+O2Nvueep48RUF/Y6yuFw3RAt9IGpOeOVInX529pgehHFyrHG7iC6vklrir3sAg== X-Received: by 2002:ac8:5c08:0:b0:3b8:63fa:11be with SMTP id i8-20020ac85c08000000b003b863fa11bemr5227631qti.66.1676977610905; Tue, 21 Feb 2023 03:06:50 -0800 (PST) From: Dinah Baum To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Dinah Baum , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth Subject: [PATCH v4] configure: Add 'mkdir build' check Date: Tue, 21 Feb 2023 06:06:30 -0500 Message-Id: <20230221110631.4142-1-dinahbaum123@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::834; envelope-from=dinahbaum123@gmail.com; helo=mail-qt1-x834.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1676977749046100001 Content-Type: text/plain; charset="utf-8" QEMU configure script goes into an infinite error printing loop when in read only directory due to 'build' dir never being created. Checking if 'mkdir dir' succeeds prevents this error. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/321 Signed-off-by: Dinah Baum Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- configure | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index cf6db3d551..1ef3e7f77d 100755 --- a/configure +++ b/configure @@ -31,7 +31,12 @@ then fi fi =20 - mkdir build + if ! mkdir build || ! touch $MARKER + then + echo "ERROR: Could not create ./build directory. Check the permiss= ions on" + echo "your source directory, or try doing an out-of-tree build." + exit 1 + fi touch $MARKER =20 cat > GNUmakefile <<'EOF' --=20 2.30.2