[v3] tcg: Simplify temporary usage

[PATCH v3 10/30] tcg: Use tcg_constant_i32 in tcg_gen_io_start

Posted by Richard Henderson 2 years, 2 months ago

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 include/exec/gen-icount.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h
index c57204ddad..4d8b1f9ae5 100644
--- a/include/exec/gen-icount.h
+++ b/include/exec/gen-icount.h
@@ -10,11 +10,9 @@ static TCGOp *icount_start_insn;
 
 static inline void gen_io_start(void)
 {
-    TCGv_i32 tmp = tcg_const_i32(1);
-    tcg_gen_st_i32(tmp, cpu_env,
+    tcg_gen_st_i32(tcg_constant_i32(1), cpu_env,
                    offsetof(ArchCPU, parent_obj.can_do_io) -
                    offsetof(ArchCPU, env));
-    tcg_temp_free_i32(tmp);
 }
 
 static inline void gen_tb_start(const TranslationBlock *tb)
-- 
2.34.1

Re: [PATCH v3 10/30] tcg: Use tcg_constant_i32 in tcg_gen_io_start

Posted by Philippe Mathieu-Daudé 2 years, 2 months ago

On 25/2/23 09:59, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/exec/gen-icount.h | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH v3 10/30] tcg: Use tcg_constant_i32 in tcg_gen_io_start

Posted by Daniel Henrique Barboza 2 years, 2 months ago


On 2/25/23 05:59, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

>   include/exec/gen-icount.h | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h
> index c57204ddad..4d8b1f9ae5 100644
> --- a/include/exec/gen-icount.h
> +++ b/include/exec/gen-icount.h
> @@ -10,11 +10,9 @@ static TCGOp *icount_start_insn;
>   
>   static inline void gen_io_start(void)
>   {
> -    TCGv_i32 tmp = tcg_const_i32(1);
> -    tcg_gen_st_i32(tmp, cpu_env,
> +    tcg_gen_st_i32(tcg_constant_i32(1), cpu_env,
>                      offsetof(ArchCPU, parent_obj.can_do_io) -
>                      offsetof(ArchCPU, env));
> -    tcg_temp_free_i32(tmp);
>   }
>   
>   static inline void gen_tb_start(const TranslationBlock *tb)