From nobody Wed May 14 03:04:44 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1677449345; cv=none; d=zohomail.com; s=zohoarc; b=YKv4V1NIH+SgT+2uh04HnlrN0MG7btH+tfuu9YPMVfnmbv6IOxjedDNvgHuCZX+7/6gEdGFlfKcc3JoXJcD8Z8OFqJUoNLog6UE9rUUxSEhMVoy10zQgAIpDlSFWl9JBYBKDG0RiBP+fvciG8Pa3R+zGRDYHbXghkLzU6ad7e0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677449345; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JlPd0DK9kbtSrRzcFmcepGFWM8AX5M3SBMBW2iYq3WM=; b=D9hNOqd4H5pasZ4nr1Oi+4AyLUdq7A7YnFmfHBO0IfsDq2iNO4OHJeBWpsKVEOKgUW6c//g8v96TXz4Jx4qg/jTYmYoIBCxZmyIbiggYPIXQ7Q5mvQgj1LGBGanJL/a+8T1T61pjQr7Bz/wJeEiMWcOGECRNiaIULRWRwYrlWho= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167744934547575.60294411451105; Sun, 26 Feb 2023 14:09:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWPB0-0002YZ-P5; Sun, 26 Feb 2023 17:07:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3Gdj7YwgKCt4SMOSTAFAGOOGLE.COMQEMU-DEVELNONGNU.ORG@flex--smostafa.bounces.google.com>) id 1pWPAz-0002Wa-7T for qemu-devel@nongnu.org; Sun, 26 Feb 2023 17:07:25 -0500 Received: from mail-wm1-x34a.google.com ([2a00:1450:4864:20::34a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3Gdj7YwgKCt4SMOSTAFAGOOGLE.COMQEMU-DEVELNONGNU.ORG@flex--smostafa.bounces.google.com>) id 1pWPAx-0003wi-Ja for qemu-devel@nongnu.org; Sun, 26 Feb 2023 17:07:24 -0500 Received: by mail-wm1-x34a.google.com with SMTP id bi21-20020a05600c3d9500b003e836e354e0so2093520wmb.5 for ; Sun, 26 Feb 2023 14:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=JlPd0DK9kbtSrRzcFmcepGFWM8AX5M3SBMBW2iYq3WM=; b=DvRjjjPJkjrXk4AXCvm1125zelt8dSeJ5E9qjwdUqRHnk/zxMoAxP3wn5TdSIIs6NZ plzuznAQMjl0BZKIs6zrtC+9RDOv57cEE9pcDjEa2Dub5oVdgv0xmzNowTSflSE8356J gTXc1+4Y2SSrbRpSEqBv7wXLLAP/STz52VVdE1H9PZBwkEHbGy7Ofa5mOrNACBIf5P9v AVv6whbEup9Q5DoimHUSP5/cmmL6KjJq7GsY8pQ5hCNnMxWUX+I3qzpa5EtkDhE2iFhA dr0o4VdTpBZYP9q0Tl6NuDrRpYbexE4U6D8tWms5cRu9FJ7n1HUxICMuDOb08AIeRm80 otSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JlPd0DK9kbtSrRzcFmcepGFWM8AX5M3SBMBW2iYq3WM=; b=nElR2Qz6TTPzt7R1uw+k86DjCAfa2mLYhsf2ZTxZa0K2EpgM/gvtVH4ZkI/x/0fG76 sg+CmHYWpWN1JWZm7w9GUZ6UM0vP+DUmoMN/GKr7g0zcI5hfVIEqFE7xoKT4q+3QYsPk w9+/nCIHbOAEKWB10JIG1UuCwnKHzjbbXhaidtRYPaJqJ+u5967hIaL9lvl1si9vGPUQ Mgy8HguhvbvDI9JSr8Fum4OPFT+gOd2IUGT45c0sWu4QiIGxDJDOl9OltyNSQQtkbr6o iw1v43zR/xeMDUf9MvUsSUoiHPsmg8fmm0tqltNPglWhjUAe+z9/4c4hRGaaPzYzoRIG 2PLA== X-Gm-Message-State: AO0yUKVz/PtxCucmzZkCfbJ1nymlgeaH2ZOcu4I5miu6+M0hv/FemRJJ l+0qYIYC4QI2y2rpPcYnUu1RTMner8r9tfGC93uAiewSP5ta18PIk5ZqyrvEPITvoySsJOzLYEc 6SYtbs24SbqXaVtoWlSUySyEaOa+eHtrLRXk6BZejzXKaYti6TwCUfZn3vNOitlmbgg== X-Google-Smtp-Source: AK7set+7T1u2b5OEEZZVm3Jw/IL/8WEufDVTX7NLJClDEWnejXxm8DttQmcAb5iCnss7NYgH0A8TaAmDo9GC5w== X-Received: from mostafa.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:333c]) (user=smostafa job=sendgmr) by 2002:adf:fc51:0:b0:2c3:e6f6:7f37 with SMTP id e17-20020adffc51000000b002c3e6f67f37mr2416440wrs.5.1677449241757; Sun, 26 Feb 2023 14:07:21 -0800 (PST) Date: Sun, 26 Feb 2023 22:06:48 +0000 In-Reply-To: <20230226220650.1480786-1-smostafa@google.com> Mime-Version: 1.0 References: <20230226220650.1480786-1-smostafa@google.com> X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog Message-ID: <20230226220650.1480786-10-smostafa@google.com> Subject: [RFC PATCH v2 09/11] hw/arm/smmuv3: Add stage-2 support in iova notifier From: Mostafa Saleh To: qemu-devel@nongnu.org Cc: jean-philippe@linaro.org, eric.auger@redhat.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, richard.henderson@linaro.org, Mostafa Saleh Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::34a; envelope-from=3Gdj7YwgKCt4SMOSTAFAGOOGLE.COMQEMU-DEVELNONGNU.ORG@flex--smostafa.bounces.google.com; helo=mail-wm1-x34a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1677449346454100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In smmuv3_notify_iova, read the granule based on translation stage and use VMID if valid value is sent. Signed-off-by: Mostafa Saleh Reviewed-by: Eric Auger --- hw/arm/smmuv3.c | 39 ++++++++++++++++++++++++++------------- hw/arm/trace-events | 2 +- 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 8c76a48c8d..7297f6adc1 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -971,18 +971,21 @@ epilogue: * @mr: IOMMU mr region handle * @n: notifier to be called * @asid: address space ID or negative value if we don't care + * @vmid: virtual machine ID or negative value if we don't care * @iova: iova * @tg: translation granule (if communicated through range invalidation) * @num_pages: number of @granule sized pages (if tg !=3D 0), otherwise 1 */ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr, IOMMUNotifier *n, - int asid, dma_addr_t iova, - uint8_t tg, uint64_t num_pages) + int asid, int vmid, + dma_addr_t iova, uint8_t tg, + uint64_t num_pages) { SMMUDevice *sdev =3D container_of(mr, SMMUDevice, iommu); IOMMUTLBEvent event; uint8_t granule; + SMMUv3State *s =3D sdev->smmu; =20 if (!tg) { SMMUEventInfo event =3D {.inval_ste_allowed =3D true}; @@ -997,11 +1000,20 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr, return; } =20 - tt =3D select_tt(cfg, iova); - if (!tt) { + if (vmid >=3D 0 && cfg->s2cfg.vmid !=3D vmid) { return; } - granule =3D tt->granule_sz; + + if (STAGE1_SUPPORTED(s)) { + tt =3D select_tt(cfg, iova); + if (!tt) { + return; + } + granule =3D tt->granule_sz; + } else { + granule =3D cfg->s2cfg.granule_sz; + } + } else { granule =3D tg * 2 + 10; } @@ -1015,9 +1027,10 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr, memory_region_notify_iommu_one(n, &event); } =20 -/* invalidate an asid/iova range tuple in all mr's */ -static void smmuv3_inv_notifiers_iova(SMMUState *s, int asid, dma_addr_t i= ova, - uint8_t tg, uint64_t num_pages) +/* invalidate an asid/vmid/iova range tuple in all mr's */ +static void smmuv3_inv_notifiers_iova(SMMUState *s, int asid, int vmid, + dma_addr_t iova, uint8_t tg, + uint64_t num_pages) { SMMUDevice *sdev; =20 @@ -1025,11 +1038,11 @@ static void smmuv3_inv_notifiers_iova(SMMUState *s,= int asid, dma_addr_t iova, IOMMUMemoryRegion *mr =3D &sdev->iommu; IOMMUNotifier *n; =20 - trace_smmuv3_inv_notifiers_iova(mr->parent_obj.name, asid, iova, - tg, num_pages); + trace_smmuv3_inv_notifiers_iova(mr->parent_obj.name, asid, vmid, + iova, tg, num_pages); =20 IOMMU_NOTIFIER_FOREACH(n, mr) { - smmuv3_notify_iova(mr, n, asid, iova, tg, num_pages); + smmuv3_notify_iova(mr, n, asid, vmid, iova, tg, num_pages); } } } @@ -1060,7 +1073,7 @@ static void smmuv3_range_inval(SMMUState *s, Cmd *cmd) =20 if (!tg) { trace_smmuv3_range_inval(vmid, asid, addr, tg, 1, ttl, leaf); - smmuv3_inv_notifiers_iova(s, asid, addr, tg, 1); + smmuv3_inv_notifiers_iova(s, asid, vmid, addr, tg, 1); smmu_iotlb_inv_iova(s, asid, vmid, addr, tg, 1, ttl); return; } @@ -1078,7 +1091,7 @@ static void smmuv3_range_inval(SMMUState *s, Cmd *cmd) =20 num_pages =3D (mask + 1) >> granule; trace_smmuv3_range_inval(vmid, asid, addr, tg, num_pages, ttl, lea= f); - smmuv3_inv_notifiers_iova(s, asid, addr, tg, num_pages); + smmuv3_inv_notifiers_iova(s, asid, vmid, addr, tg, num_pages); smmu_iotlb_inv_iova(s, asid, vmid, addr, tg, num_pages, ttl); addr +=3D mask + 1; } diff --git a/hw/arm/trace-events b/hw/arm/trace-events index f8fdf1ca9f..cdc1ea06a8 100644 --- a/hw/arm/trace-events +++ b/hw/arm/trace-events @@ -53,5 +53,5 @@ smmuv3_cmdq_tlbi_s12_vmid(uint16_t vmid) "vmid=3D%d" smmuv3_config_cache_inv(uint32_t sid) "Config cache INV for sid=3D0x%x" smmuv3_notify_flag_add(const char *iommu) "ADD SMMUNotifier node for iommu= mr=3D%s" smmuv3_notify_flag_del(const char *iommu) "DEL SMMUNotifier node for iommu= mr=3D%s" -smmuv3_inv_notifiers_iova(const char *name, uint16_t asid, uint64_t iova, = uint8_t tg, uint64_t num_pages) "iommu mr=3D%s asid=3D%d iova=3D0x%"PRIx64"= tg=3D%d num_pages=3D0x%"PRIx64 +smmuv3_inv_notifiers_iova(const char *name, uint16_t asid, uint16_t vmid, = uint64_t iova, uint8_t tg, uint64_t num_pages) "iommu mr=3D%s asid=3D%d vmi= d=3D%d iova=3D0x%"PRIx64" tg=3D%d num_pages=3D0x%"PRIx64 =20 --=20 2.39.2.637.g21b0678d19-goog