From nobody Fri Dec 27 01:09:41 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677476754; cv=none; d=zohomail.com; s=zohoarc; b=d63wjLS/vEb/sBT7GgqC+R3P0S82kPSF7/wbhMYVrKqlNdFngwIXOtu44glu70Rxl6N2K0xezvYrmMGcXnXddssWWTBFFYifc3bO+aoQmORZ3vvFK2FuFtCZr9Rj4/y6kLHq2KwQmpOuIDILmVIJCo9DTAG4vkO2vPkXWCYoJJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677476754; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EN6i3124GbzuDzAfWYCmS/x0Jquz/HN39rL+uzxBiIE=; b=Y6CJ2KKP0fqdZUDGgvmtJF806iTzA385rt09qQfZsMRFqLyO1l/7EKJgokQMqcqRdpBXa7eLHifamNWJySQFk0UmpPnRbQmw82TByYUBl+7jPIWrkqS9usHPmFwN0gRncKoZCCPhtaHoywsb28dqOlydlpMBKxsOYr6x2qemCpk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677476754423378.5156237737209; Sun, 26 Feb 2023 21:45:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWWE7-0007Ye-J0; Mon, 27 Feb 2023 00:39:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWWD4-0003Ne-SB for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:38:09 -0500 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWWD2-0002ox-C2 for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:38:02 -0500 Received: by mail-pj1-x102b.google.com with SMTP id m8-20020a17090a4d8800b002377bced051so8944546pjh.0 for ; Sun, 26 Feb 2023 21:37:59 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id k12-20020aa792cc000000b005a7c892b435sm3342137pfa.25.2023.02.26.21.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 21:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EN6i3124GbzuDzAfWYCmS/x0Jquz/HN39rL+uzxBiIE=; b=Uxj4uRpCpqZL5iI8xx/448eGHU8w2e36Mkh8lGpxZnx+zHg3hUkvE3AKZizAKCrFdq IyX0ueIDuHosRIJtKY1Fildw0KQq5ywVaXP/sE2UisifYHh4z7MbPAn2dLtUfJxA9Gvo g2bv/iEqDfq90WTkjQ2aV7G7GcqH0ZUstjgPUTVQ3KllTAhRURmDqoZfChMfQZ4+MeOv bw4qGO+MKBlRE+75LYBKLp0a1P1jvyUQHq2FIk5tRzgOgdzmsw7ZuypFKhcaMTSUPdOe gO3Yy7RzmkosVbYVgWvyfB40+c91kGsuT6qSi6zgon1Zp+I8hcLIZayoPLZrvsGolnLr oteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EN6i3124GbzuDzAfWYCmS/x0Jquz/HN39rL+uzxBiIE=; b=dXPfWxmWyDj6CJrCGEdm2/anQXJx6s1W4CKlb+fBam5VhGw+C98PIJfCQl94ORSQil TwEyNGCaRIXmWyHgjicQjjjBf0gEIyyI5QtWEejqo7WBTJejdv48jmZq4c/eCYLQFMAb f87wt1t6iEIcK7kg9Clzqo98Mf3gL3X6kWJMRV5x4EGUANULn1B4Qn6r5bLfBhBGCLo5 eS9P7IZdO66/QSLLPg7U2f+0bFc7wpSko361EZ/B7+NrUmTWSung0DUPO07lp1XGMFjy Nf4ermK00hu9+CxhnaDOc3Z2FQRwwIcqKimoURfQaA9o677nygeuUv6pM9Hdyw0JYfRx 4TNA== X-Gm-Message-State: AO0yUKVEe4XlqdYW39qSOZ6+7Kkt4OEt3NlzmpMbmDnP3kaFjzVemwSV NdTLLa0ei+2P53kQ/OCc47ZDrqWJNGi55ZGFV+Y= X-Google-Smtp-Source: AK7set8waP010j+FmSTOcz5vRnyljIKP6pyZxBu4MjL+krvn+gH1zWvcXMU+BBkjK31Gsz9Qx6FAoA== X-Received: by 2002:a05:6a21:3396:b0:cd:1808:87bb with SMTP id yy22-20020a056a21339600b000cd180887bbmr4899219pzb.7.1677476278683; Sun, 26 Feb 2023 21:37:58 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com, Peter Maydell Subject: [PATCH v4 19/31] target/arm: Drop copies in gen_sve_{ldr,str} Date: Sun, 26 Feb 2023 19:36:49 -1000 Message-Id: <20230227053701.368744-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230227053701.368744-1-richard.henderson@linaro.org> References: <20230227053701.368744-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677476755915100003 Content-Type: text/plain; charset="utf-8" Since we now get TEMP_TB temporaries by default, we no longer need to make copies across these loops. These were the only uses of new_tmp_a64_local(), so remove that as well. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.h | 1 - target/arm/translate-a64.c | 6 ------ target/arm/translate-sve.c | 32 -------------------------------- 3 files changed, 39 deletions(-) diff --git a/target/arm/translate-a64.h b/target/arm/translate-a64.h index ad3762d1ac..ca24c39dbe 100644 --- a/target/arm/translate-a64.h +++ b/target/arm/translate-a64.h @@ -19,7 +19,6 @@ #define TARGET_ARM_TRANSLATE_A64_H =20 TCGv_i64 new_tmp_a64(DisasContext *s); -TCGv_i64 new_tmp_a64_local(DisasContext *s); TCGv_i64 new_tmp_a64_zero(DisasContext *s); TCGv_i64 cpu_reg(DisasContext *s, int reg); TCGv_i64 cpu_reg_sp(DisasContext *s, int reg); diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 67e9c4ee79..9da5010fe1 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -436,12 +436,6 @@ TCGv_i64 new_tmp_a64(DisasContext *s) return s->tmp_a64[s->tmp_a64_count++] =3D tcg_temp_new_i64(); } =20 -TCGv_i64 new_tmp_a64_local(DisasContext *s) -{ - assert(s->tmp_a64_count < TMP_A64_MAX); - return s->tmp_a64[s->tmp_a64_count++] =3D tcg_temp_local_new_i64(); -} - TCGv_i64 new_tmp_a64_zero(DisasContext *s) { TCGv_i64 t =3D new_tmp_a64(s); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 621a2abb22..02150d93e8 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -4344,17 +4344,6 @@ void gen_sve_ldr(DisasContext *s, TCGv_ptr base, int= vofs, TCGLabel *loop =3D gen_new_label(); TCGv_ptr tp, i =3D tcg_const_local_ptr(0); =20 - /* Copy the clean address into a local temp, live across the loop.= */ - t0 =3D clean_addr; - clean_addr =3D new_tmp_a64_local(s); - tcg_gen_mov_i64(clean_addr, t0); - - if (base !=3D cpu_env) { - TCGv_ptr b =3D tcg_temp_local_new_ptr(); - tcg_gen_mov_ptr(b, base); - base =3D b; - } - gen_set_label(loop); =20 t0 =3D tcg_temp_new_i64(); @@ -4370,11 +4359,6 @@ void gen_sve_ldr(DisasContext *s, TCGv_ptr base, int= vofs, =20 tcg_gen_brcondi_ptr(TCG_COND_LTU, i, len_align, loop); tcg_temp_free_ptr(i); - - if (base !=3D cpu_env) { - tcg_temp_free_ptr(base); - assert(len_remain =3D=3D 0); - } } =20 /* @@ -4445,17 +4429,6 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int= vofs, TCGLabel *loop =3D gen_new_label(); TCGv_ptr tp, i =3D tcg_const_local_ptr(0); =20 - /* Copy the clean address into a local temp, live across the loop.= */ - t0 =3D clean_addr; - clean_addr =3D new_tmp_a64_local(s); - tcg_gen_mov_i64(clean_addr, t0); - - if (base !=3D cpu_env) { - TCGv_ptr b =3D tcg_temp_local_new_ptr(); - tcg_gen_mov_ptr(b, base); - base =3D b; - } - gen_set_label(loop); =20 t0 =3D tcg_temp_new_i64(); @@ -4471,11 +4444,6 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int= vofs, =20 tcg_gen_brcondi_ptr(TCG_COND_LTU, i, len_align, loop); tcg_temp_free_ptr(i); - - if (base !=3D cpu_env) { - tcg_temp_free_ptr(base); - assert(len_remain =3D=3D 0); - } } =20 /* Predicate register stores can be any multiple of 2. */ --=20 2.34.1