From nobody Fri Dec 27 00:24:23 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677476560; cv=none; d=zohomail.com; s=zohoarc; b=XR55vol2JO9engr27VreHhWvprADYAe+zYzAXKXPwDfYhWtlbK3HEFMMTc8UmxGTqaL6svQKC8kE31qhhbnKcTHYvoLUzLKt11mszgfJHYixiBZmY2tWawLhwjQSR/8eOc5EKtT3itJeKl3nBs1QeC9T9E+FxPKEBYPWNgx2ST8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677476560; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z2yx2ICVs1zB6ngtjHL2Am0/1UDD6BkdCpu6nOfJ5a4=; b=JMxX+0cyGkxxPphjwdHLrnwVWKZcL+Gr0cqnT2G28UhCZv9Sx4qaIPv6ONLsLQQV95UzhmTRI4ald2xNory9CcADi0Q8pAyX/fQv3bJbUSyyNOXVRIXyEOqjCaR56jbXLsmKYSJVW1NtqlrlTBNiPn5imlpC9/IPKouAY8PxoWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677476560943749.6155925970812; Sun, 26 Feb 2023 21:42:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWWCr-0003CU-SI; Mon, 27 Feb 2023 00:37:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWWCX-0002ZB-4V for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:37:29 -0500 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWWCV-0002aF-8T for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:37:28 -0500 Received: by mail-pf1-x42d.google.com with SMTP id g12so2832958pfi.0 for ; Sun, 26 Feb 2023 21:37:26 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id k12-20020aa792cc000000b005a7c892b435sm3342137pfa.25.2023.02.26.21.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 21:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z2yx2ICVs1zB6ngtjHL2Am0/1UDD6BkdCpu6nOfJ5a4=; b=y99zt4oaIdGSFxgTnRbqMaQNSMHu3V9TkK4/lrhBhyM9ixnNM7WLXvwqkP9v2Z1ip/ GqngGiSAjitx4fbgTDzL2d1HBjWMjR9IrRBnTuHpw98gpR2tYE0oLkf+RfkE5YNxQdzW oj/9zwOtWnryCwsRh2TaJRImktZC5IC3C7SKE74nFfUqslYEpqwU9/YRhvMhyYa4zx7Z arerNif6+5Fxl92NPcuQbOY3Zt6OxG0LIo4Mwy06nX3LDh19OpR/TX6BGdCXR+o6TFRE ajoA1XtzwnRQsYHtODhYoF5wx+WBoSNeSHavq7ceYQfGp6jJHzn4lAEsAN7itLWC/nRX HxaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z2yx2ICVs1zB6ngtjHL2Am0/1UDD6BkdCpu6nOfJ5a4=; b=IDPgqtkrN8FO8gTCvdLbE9WaoUYiCmiP1w7zxA/Hy/ZzJsHevJoi8x0yH/UC+XSW66 94LasV07IcTEa5Ljn7SU6QSNgkg4wcq7Zg/sPrBzofx80HnzCMmF3+FyKPP/K0aBuhxa MZM5nJGV5Y16bxCHwjaoYBCsG5vbyldRHiEip5r2YHID2MDCvdA5peURYEYzv3dMUsCs w99XiregIKrHU1H0RVDaTiAJ6tbMXaJAf50AR/kCBhJP96W8Be4pxPCMM9C/tbLpDPeF HVy0tDCuK/8hSrb5rrxgL5xwqyx2nJKmxi67auEONCMk1UHo+50i1bew+2H5JqEEA+yZ ve9Q== X-Gm-Message-State: AO0yUKXdkI5etRAGbH6PuCx10OnUsBvz5jIKCIgwlC91LWAy9HEg8aob Lz7pDeU254Pz0yp23h50QwiCI7zO41U6XferSdY= X-Google-Smtp-Source: AK7set9I0oPNr+2dSXzXrqx2AIX03HdrMSqTFwqKLfgD1t8s58t4S4SiDayXAqZADoyc6erCBTDyAA== X-Received: by 2002:a05:6a00:47:b0:5cd:d766:8a2b with SMTP id i7-20020a056a00004700b005cdd7668a2bmr18687656pfk.6.1677476245649; Sun, 26 Feb 2023 21:37:25 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com Subject: [PATCH v4 07/31] tcg: Add liveness_pass_0 Date: Sun, 26 Feb 2023 19:36:37 -1000 Message-Id: <20230227053701.368744-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230227053701.368744-1-richard.henderson@linaro.org> References: <20230227053701.368744-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677476562735100003 Content-Type: text/plain; charset="utf-8" Attempt to reduce the lifetime of TEMP_TB. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- tcg/tcg.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 7ee935701a..6646770268 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2858,6 +2858,75 @@ static void la_cross_call(TCGContext *s, int nt) } } =20 +/* + * Liveness analysis: Verify the lifetime of TEMP_TB, and reduce + * to TEMP_EBB, if possible. + */ +static void __attribute__((noinline)) +liveness_pass_0(TCGContext *s) +{ + void * const multiple_ebb =3D (void *)(uintptr_t)-1; + int nb_temps =3D s->nb_temps; + TCGOp *op, *ebb; + + for (int i =3D s->nb_globals; i < nb_temps; ++i) { + s->temps[i].state_ptr =3D NULL; + } + + /* + * Represent each EBB by the op at which it begins. In the case of + * the first EBB, this is the first op, otherwise it is a label. + * Collect the uses of each TEMP_TB: NULL for unused, EBB for use + * within a single EBB, else MULTIPLE_EBB. + */ + ebb =3D QTAILQ_FIRST(&s->ops); + QTAILQ_FOREACH(op, &s->ops, link) { + const TCGOpDef *def; + int nb_oargs, nb_iargs; + + switch (op->opc) { + case INDEX_op_set_label: + ebb =3D op; + continue; + case INDEX_op_discard: + continue; + case INDEX_op_call: + nb_oargs =3D TCGOP_CALLO(op); + nb_iargs =3D TCGOP_CALLI(op); + break; + default: + def =3D &tcg_op_defs[op->opc]; + nb_oargs =3D def->nb_oargs; + nb_iargs =3D def->nb_iargs; + break; + } + + for (int i =3D 0; i < nb_oargs + nb_iargs; ++i) { + TCGTemp *ts =3D arg_temp(op->args[i]); + + if (ts->kind !=3D TEMP_TB) { + continue; + } + if (ts->state_ptr =3D=3D NULL) { + ts->state_ptr =3D ebb; + } else if (ts->state_ptr !=3D ebb) { + ts->state_ptr =3D multiple_ebb; + } + } + } + + /* + * For TEMP_TB that turned out not to be used beyond one EBB, + * reduce the liveness to TEMP_EBB. + */ + for (int i =3D s->nb_globals; i < nb_temps; ++i) { + TCGTemp *ts =3D &s->temps[i]; + if (ts->kind =3D=3D TEMP_TB && ts->state_ptr !=3D multiple_ebb) { + ts->kind =3D TEMP_EBB; + } + } +} + /* Liveness analysis : update the opc_arg_life array to tell if a given input arguments is dead. Instructions updating dead temporaries are removed. */ @@ -4873,6 +4942,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb,= target_ulong pc_start) #endif =20 reachable_code_pass(s); + liveness_pass_0(s); liveness_pass_1(s); =20 if (s->nb_indirects > 0) { --=20 2.34.1